From: Olaf Hering <olaf@aepfle.de>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Subject: Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first
Date: Tue, 20 Oct 2020 11:16:05 +0200 [thread overview]
Message-ID: <20201020091605.GA2301@aepfle.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f
On Mon, Sep 07, Laszlo Ersek wrote:
> In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule",
> 2020-04-16), part of edk2-stable202005, the Brotli compressor /
> decompressor source code that edk2 had flattened into BaseTools was
> replaced with a git submodule.
>
> This means we have to initialize edk2's own submodules before building
> BaseTools not just in "roms/Makefile.edk2", but in "roms/Makefile" (for
> the sake of the "efirom" target) and "tests/uefi-test-tools/Makefile" as
> well.
> +++ b/roms/Makefile
> edk2-basetools:
> + cd edk2/BaseTools && git submodule update --init --force
> build-edk2-tools:
> + cd $(edk2_dir)/BaseTools && git submodule update --init --force
This change can not possibly be correct.
With current qemu.git#master one is forced to have network access to
build the roms. This fails with exported (and complete) sources in an
offline environment.
Please revert this patch.
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2020-10-20 9:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:16 Olaf Hering [this message]
2020-10-20 9:29 ` roms/efirom, tests/uefi-test-tools: update edk2's own submodules first Philippe Mathieu-Daudé
2020-10-20 9:35 ` Olaf Hering
2020-10-20 9:38 ` Philippe Mathieu-Daudé
2020-10-20 9:44 ` Daniel P. Berrangé
2020-10-20 9:54 ` Philippe Mathieu-Daudé
2020-10-21 12:05 ` Laszlo Ersek
2020-10-21 12:30 ` Olaf Hering
2020-10-21 13:28 ` Laszlo Ersek
2020-10-21 13:46 ` Daniel P. Berrangé
2020-10-21 17:27 ` Laszlo Ersek
2020-10-20 12:52 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020091605.GA2301@aepfle.de \
--to=olaf@aepfle.de \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.