From: Cornelia Huck <cohuck@redhat.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: thuth@redhat.com, pmorel@linux.ibm.com, david@redhat.com,
farman@linux.ibm.com, schnelle@linux.ibm.com,
qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net
Subject: Re: [PATCH] s390x/s390-virtio-ccw: Reset PCI devices during subsystem reset
Date: Tue, 20 Oct 2020 11:57:58 +0200 [thread overview]
Message-ID: <20201020115758.43f140a7.cohuck@redhat.com> (raw)
In-Reply-To: <1602767767-32713-1-git-send-email-mjrosato@linux.ibm.com>
On Thu, 15 Oct 2020 09:16:07 -0400
Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> Currently, a subsystem reset event leaves PCI devices enabled, causing
> issues post-reset in the guest (an example would be after a kexec). These
> devices need to be reset during a subsystem reset, allowing them to be
> properly re-enabled afterwards. Add the S390 PCI host bridge to the list
> of qdevs to be reset during subsystem reset.
>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index e52182f..2e90033 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -101,6 +101,7 @@ static const char *const reset_dev_types[] = {
> "s390-sclp-event-facility",
> "s390-flic",
> "diag288",
> + TYPE_S390_PCI_HOST_BRIDGE,
> };
>
> static void subsystem_reset(void)
Thanks, applied (with cc:stable added.)
prev parent reply other threads:[~2020-10-20 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 13:16 [PATCH] s390x/s390-virtio-ccw: Reset PCI devices during subsystem reset Matthew Rosato
2020-10-15 13:32 ` Christian Borntraeger
2020-10-15 13:34 ` Christian Borntraeger
2020-10-15 13:37 ` Niklas Schnelle
2020-10-15 13:45 ` Matthew Rosato
2020-10-16 15:36 ` Halil Pasic
2020-10-20 9:57 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020115758.43f140a7.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=schnelle@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.