All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Elena Afanasova <eafanasova@gmail.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging/rtl8192u/ieee80211: use __func__ macro
Date: Tue, 20 Oct 2020 17:19:49 +0200	[thread overview]
Message-ID: <20201020151949.GA852005@kroah.com> (raw)
In-Reply-To: <20201020150823.35734-1-eafanasova@gmail.com>

On Tue, Oct 20, 2020 at 08:08:23AM -0700, Elena Afanasova wrote:
> Replace function names with __func__ macro.
> Remove unnecessary characters in error messages.
> Reported by checkpatch.pl.
> 
> Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/dot11d.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.c b/drivers/staging/rtl8192u/ieee80211/dot11d.c
> index bc642076b96f..f972edcde8a0 100644
> --- a/drivers/staging/rtl8192u/ieee80211/dot11d.c
> +++ b/drivers/staging/rtl8192u/ieee80211/dot11d.c
> @@ -15,7 +15,7 @@ void rtl8192u_dot11d_init(struct ieee80211_device *ieee)
>  	memset(dot11d_info->max_tx_pwr_dbm_list, 0xFF, MAX_CHANNEL_NUMBER + 1);
>  	RESET_CIE_WATCHDOG(ieee);
>  
> -	netdev_info(ieee->dev, "rtl8192u_dot11d_init()\n");
> +	netdev_info(ieee->dev, "%s\n", __func__);

This is a pure debugging line, and should just be removed.  Can you do
that as an add-on patch to this?

thanks,

greg k-h


  reply	other threads:[~2020-10-20 15:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 15:08 [PATCH] staging/rtl8192u/ieee80211: use __func__ macro Elena Afanasova
2020-10-20 15:19 ` Greg KH [this message]
2020-10-20 15:26   ` Elena Afanasova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201020151949.GA852005@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=eafanasova@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.