From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFCv2 13/16] KVM: Rework copy_to/from_guest() to avoid direct mapping
Date: Tue, 20 Oct 2020 17:40:45 +0800 [thread overview]
Message-ID: <202010201724.pbM23WrR-lkp@intel.com> (raw)
In-Reply-To: <20201020061859.18385-14-kirill.shutemov@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 4850 bytes --]
Hi "Kirill,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/x86/core]
[also build test ERROR on v5.9]
[cannot apply to kvm/linux-next hnaz-linux-mm/master next-20201016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kirill-A-Shutemov/KVM-protected-memory-extension/20201020-142130
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 238c91115cd05c71447ea071624a4c9fe661f970
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/1af02c27a796b91d58cd8b6d50d7e7b9b5564ce4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kirill-A-Shutemov/KVM-protected-memory-extension/20201020-142130
git checkout 1af02c27a796b91d58cd8b6d50d7e7b9b5564ce4
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> virt/lib/mem_protected.c:11:7: warning: no previous prototype for 'kvm_map_page_atomic' [-Wmissing-prototypes]
11 | void *kvm_map_page_atomic(struct page *page)
| ^~~~~~~~~~~~~~~~~~~
>> virt/lib/mem_protected.c:24:6: warning: no previous prototype for 'kvm_unmap_page_atomic' [-Wmissing-prototypes]
24 | void kvm_unmap_page_atomic(void *vaddr)
| ^~~~~~~~~~~~~~~~~~~~~
>> virt/lib/mem_protected.c:33:5: warning: no previous prototype for 'kvm_init_protected_memory' [-Wmissing-prototypes]
33 | int kvm_init_protected_memory(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> virt/lib/mem_protected.c:51:6: warning: no previous prototype for 'kvm_exit_protected_memory' [-Wmissing-prototypes]
51 | void kvm_exit_protected_memory(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/mm.h:33,
from include/linux/kvm_host.h:14,
from virt/lib/mem_protected.c:1:
virt/lib/mem_protected.c: In function 'adjust_direct_mapping_pte_range':
>> include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
virt/lib/mem_protected.c:79:8: note: in expansion of macro 'pte_offset_map'
79 | pte = pte_offset_map(pmd, addr);
| ^~~~~~~~~~~~~~
virt/lib/mem_protected.c: At top level:
virt/lib/mem_protected.c:102:5: warning: no previous prototype for '__kvm_protect_memory' [-Wmissing-prototypes]
102 | int __kvm_protect_memory(unsigned long start, unsigned long end, bool protect)
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/kvm_map_page_atomic +11 virt/lib/mem_protected.c
10
> 11 void *kvm_map_page_atomic(struct page *page)
12 {
13 pte_t *pte;
14 void *vaddr;
15
16 preempt_disable();
17 pte = guest_map_ptes[smp_processor_id()];
18 vaddr = guest_map_area->addr + smp_processor_id() * PAGE_SIZE;
19 set_pte(pte, mk_pte(page, PAGE_KERNEL));
20 return vaddr;
21 }
22 EXPORT_SYMBOL_GPL(kvm_map_page_atomic);
23
> 24 void kvm_unmap_page_atomic(void *vaddr)
25 {
26 pte_t *pte = guest_map_ptes[smp_processor_id()];
27 set_pte(pte, __pte(0));
28 flush_tlb_one_kernel((unsigned long)vaddr);
29 preempt_enable();
30 }
31 EXPORT_SYMBOL_GPL(kvm_unmap_page_atomic);
32
> 33 int kvm_init_protected_memory(void)
34 {
35 guest_map_ptes = kmalloc_array(num_possible_cpus(),
36 sizeof(pte_t *), GFP_KERNEL);
37 if (!guest_map_ptes)
38 return -ENOMEM;
39
40 guest_map_area = alloc_vm_area(PAGE_SIZE * num_possible_cpus(),
41 guest_map_ptes);
42 if (!guest_map_ptes) {
43 kfree(guest_map_ptes);
44 return -ENOMEM;
45 }
46
47 return 0;
48 }
49 EXPORT_SYMBOL_GPL(kvm_init_protected_memory);
50
> 51 void kvm_exit_protected_memory(void)
52 {
53 if (guest_map_area)
54 free_vm_area(guest_map_area);
55 if (guest_map_ptes)
56 kfree(guest_map_ptes);
57 }
58 EXPORT_SYMBOL_GPL(kvm_exit_protected_memory);
59
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74751 bytes --]
next prev parent reply other threads:[~2020-10-20 9:40 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 6:18 [RFCv2 00/16] KVM protected memory extension Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 01/16] x86/mm: Move force_dma_unencrypted() to common code Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 02/16] x86/kvm: Introduce KVM memory protection feature Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 03/16] x86/kvm: Make DMA pages shared Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 04/16] x86/kvm: Use bounce buffers for KVM memory protection Kirill A. Shutemov
2020-10-20 7:46 ` kernel test robot
2020-10-20 8:48 ` kernel test robot
2020-10-20 6:18 ` [RFCv2 05/16] x86/kvm: Make VirtIO use DMA API in KVM guest Kirill A. Shutemov
2020-10-20 8:06 ` Christoph Hellwig
2020-10-20 12:47 ` Kirill A. Shutemov
2020-10-20 9:18 ` kernel test robot
2020-10-22 3:31 ` Halil Pasic
2020-10-20 6:18 ` [RFCv2 06/16] x86/kvmclock: Share hvclock memory with the host Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 07/16] x86/realmode: Share trampoline area if KVM memory protection enabled Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 08/16] KVM: Use GUP instead of copy_from/to_user() to access guest memory Kirill A. Shutemov
2020-10-20 8:25 ` John Hubbard
2020-10-20 12:51 ` Kirill A. Shutemov
2020-10-22 11:49 ` Matthew Wilcox
2020-10-22 19:58 ` John Hubbard
2020-10-26 4:21 ` Matthew Wilcox
2020-10-26 4:44 ` John Hubbard
2020-10-26 13:28 ` Matthew Wilcox
2020-10-26 14:16 ` Jason Gunthorpe
2020-10-26 20:52 ` John Hubbard
2020-10-20 17:29 ` Ira Weiny
2020-10-22 11:37 ` Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 09/16] KVM: mm: Introduce VM_KVM_PROTECTED Kirill A. Shutemov
2020-10-21 18:47 ` Edgecombe, Rick P
2020-10-22 12:01 ` Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 10/16] KVM: x86: Use GUP for page walk instead of __get_user() Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 11/16] KVM: Protected memory extension Kirill A. Shutemov
2020-10-20 7:17 ` Peter Zijlstra
2020-10-20 12:55 ` Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 12/16] KVM: x86: Enabled protected " Kirill A. Shutemov
2020-10-20 9:01 ` kernel test robot
2020-10-20 6:18 ` [RFCv2 13/16] KVM: Rework copy_to/from_guest() to avoid direct mapping Kirill A. Shutemov
2020-10-20 9:40 ` kernel test robot [this message]
2020-10-20 6:18 ` [RFCv2 14/16] KVM: Handle protected memory in __kvm_map_gfn()/__kvm_unmap_gfn() Kirill A. Shutemov
2020-10-20 10:34 ` kernel test robot
2020-10-20 11:56 ` kernel test robot
2020-10-21 18:50 ` Edgecombe, Rick P
2020-10-22 12:06 ` Kirill A. Shutemov
2020-10-22 16:59 ` Edgecombe, Rick P
2020-10-23 10:36 ` Kirill A. Shutemov
2020-10-22 3:26 ` Halil Pasic
2020-10-22 12:07 ` Kirill A. Shutemov
2020-10-20 6:18 ` [RFCv2 15/16] KVM: Unmap protected pages from direct mapping Kirill A. Shutemov
2020-10-20 7:12 ` Peter Zijlstra
2020-10-20 12:18 ` David Hildenbrand
2020-10-20 13:20 ` David Hildenbrand
2020-10-21 1:20 ` Edgecombe, Rick P
2020-10-26 19:55 ` Tom Lendacky
2020-10-21 18:49 ` Edgecombe, Rick P
2020-10-23 12:37 ` Mike Rapoport
2020-10-23 16:32 ` Sean Christopherson
2020-10-20 6:18 ` [RFCv2 16/16] mm: Do not use zero page for VM_KVM_PROTECTED VMAs Kirill A. Shutemov
2020-10-20 7:46 ` [RFCv2 00/16] KVM protected memory extension Vitaly Kuznetsov
2020-10-20 13:49 ` Kirill A. Shutemov
2020-10-21 14:46 ` Vitaly Kuznetsov
2020-10-23 11:35 ` Kirill A. Shutemov
2020-10-23 12:01 ` Vitaly Kuznetsov
2020-10-21 18:20 ` Andy Lutomirski
2020-10-26 15:29 ` Kirill A. Shutemov
2020-10-26 23:58 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010201724.pbM23WrR-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.