From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
netdev@vger.kernel.org
Subject: Re: [PATCH russell-kings-net-queue v2 2/3] net: phy: sfp: add support for multigig RollBall modules
Date: Tue, 20 Oct 2020 18:14:38 +0200 [thread overview]
Message-ID: <20201020181438.1b3e972a@kernel.org> (raw)
In-Reply-To: <20201020155126.GH139700@lunn.ch>
On Tue, 20 Oct 2020 17:51:26 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> > @@ -2006,6 +2040,23 @@ static int sfp_sm_mod_probe(struct sfp *sfp, bool report)
> >
> > sfp->id = id;
> >
> > + sfp->phy_addr = SFP_PHY_ADDR;
> > +
> > + rollball = ((!memcmp(id.base.vendor_name, "OEM ", 16) ||
> > + !memcmp(id.base.vendor_name, "Turris ", 16)) &&
> > + (!memcmp(id.base.vendor_pn, "SFP-10G-T ", 16) ||
> > + !memcmp(id.base.vendor_pn, "RTSFP-10", 8)));
>
> Are you customising the SFP, so that it has your vendor name?
>
> Is the generic SFP OEM/SFP-10G-T, and your customized one Turris/
> RTSFP-10?
>
> Andrew
Hilink puts OEM/SFP-10G-T into their modules.
RollBall puts OEM/RTSFP-10 and sometimes OEM/RTSFP-10G.
They are rebranding these modules for us to Turris/RTSFP-10.
Marek
next prev parent reply other threads:[~2020-10-20 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:06 [PATCH russell-kings-net-queue v2 0/3] Support for RollBall 10G copper SFP modules Marek Behún
2020-10-20 15:06 ` [PATCH russell-kings-net-queue v2 1/3] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall " Marek Behún
2020-10-20 16:00 ` Andrew Lunn
2020-10-20 16:15 ` Marek Behún
2020-10-20 15:06 ` [PATCH russell-kings-net-queue v2 2/3] net: phy: sfp: add support for multigig RollBall modules Marek Behún
2020-10-20 15:51 ` Andrew Lunn
2020-10-20 16:14 ` Marek Behún [this message]
2020-10-20 15:06 ` [PATCH russell-kings-net-queue v2 3/3] net: phylink: don't fail attaching phy on 1000base-x/2500base-x mode Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020181438.1b3e972a@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.