From: Guillaume Nault <gnault@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>, Po Liu <Po.Liu@nxp.com>
Subject: Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()
Date: Wed, 21 Oct 2020 09:52:43 +0200 [thread overview]
Message-ID: <20201021075243.GA3789@linux.home> (raw)
In-Reply-To: <CAM_iQpXEPshoMYc5hkePa85T-H5uP3EGfHFRSDDqYrLuuB-bbg@mail.gmail.com>
On Tue, Oct 20, 2020 at 05:37:22PM -0700, Cong Wang wrote:
> On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault <gnault@redhat.com> wrote:
> >
> > We need to jump to the "err_out_locked" label when
> > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits
> > with ->tcfa_lock still held.
> >
> > Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading")
> > Signed-off-by: Guillaume Nault <gnault@redhat.com>
>
> Looks like the err_out label can be just removed after this patch?
That'd require reworking the error path, as err_out is used there. I
don't feel that doing so would improve readability much.
> If any compiler complains, you have to fix it in v2, otherwise can be in a
> separate patch.
>
> Other than this,
>
> Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks.
prev parent reply other threads:[~2020-10-21 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:34 [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action() Guillaume Nault
2020-10-21 0:37 ` Cong Wang
2020-10-21 4:04 ` Jakub Kicinski
2020-10-21 7:52 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021075243.GA3789@linux.home \
--to=gnault@redhat.com \
--cc=Po.Liu@nxp.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.