From: Shawn Guo <shawn.guo@linaro.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Sean Paul <seanpaul@chromium.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing
Date: Wed, 21 Oct 2020 17:11:27 +0800 [thread overview]
Message-ID: <20201021091126.GI5182@dragon> (raw)
In-Reply-To: <20201019154829.GG401619@phenom.ffwll.local>
On Mon, Oct 19, 2020 at 05:48:29PM +0200, Daniel Vetter wrote:
> On Fri, Oct 16, 2020 at 07:46:41PM +0800, Shawn Guo wrote:
> > Indeed! Adding drm_crtc_vblank_reset() into driver crtc reset hook
> > removes the WARNING for me. Really appreciate your comments, Daniel!
>
> This should work automatically if you're using the atomic state helpers.
> Please try to unify as much as possible, so you're not missing any future
> bugfixes in this area. Although I thought I've completely reviewed all
> drivers to fix as many as possible for this bug. Are you on some older
> kernel that didn't have this? Maybe good idea to submit the bugfix in
> upstream to stable, if that's the case.
Yes, I'm running a 4.19 stable kernel with msm/mdp5 device. The bug was
addressed (unintentionally?) by one patch that is part of the series
adding Nexus 5 display support. And later on, you commit 51f644b40b4b
("drm/atomic-helper: reset vblank on crtc reset") switches the driver to
use atomic state helper.
Shawn
[1] https://lore.kernel.org/patchwork/patch/1082564/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-10-21 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 7:12 [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing Shawn Guo
2020-10-16 7:58 ` Daniel Vetter
2020-10-16 8:54 ` Shawn Guo
2020-10-16 9:30 ` Daniel Vetter
2020-10-16 11:46 ` Shawn Guo
2020-10-19 15:48 ` Daniel Vetter
2020-10-21 9:11 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021091126.GI5182@dragon \
--to=shawn.guo@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.