From: Stephen Hemminger <stephen@networkplumber.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, martin.varghese@nokia.com
Subject: Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions
Date: Wed, 21 Oct 2020 11:32:34 -0700 [thread overview]
Message-ID: <20201021113234.56052cb2@hermes.local> (raw)
In-Reply-To: <a35ef5479e7a47f25d0f07e31d13b89256f4b4cc.1603120726.git.gnault@redhat.com>
On Mon, 19 Oct 2020 17:23:01 +0200
Guillaume Nault <gnault@redhat.com> wrote:
> + } else if (matches(*argv, "pop_eth") == 0) {
Using matches allows for shorter command lines but can be make
for bad user experience if strings overlap.
For example 'p' here will match the pop_eth and not the push_eth.
Is it time to use full string compare for these options?
next prev parent reply other threads:[~2020-10-21 18:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:22 [PATCH v2 iproute2-next 0/2] tc: support for new MPLS L2 VPN actions Guillaume Nault
2020-10-19 15:23 ` [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions Guillaume Nault
2020-10-21 18:32 ` Stephen Hemminger [this message]
2020-10-21 18:42 ` David Ahern
2020-10-22 8:36 ` Guillaume Nault
2020-10-22 14:11 ` David Ahern
2020-10-22 14:21 ` Guillaume Nault
2020-10-19 15:23 ` [PATCH v2 iproute2-next 2/2] m_mpls: add mac_push action Guillaume Nault
2020-10-20 14:59 ` [PATCH v2 iproute2-next 0/2] tc: support for new MPLS L2 VPN actions David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021113234.56052cb2@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=gnault@redhat.com \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.