From: Peter Zijlstra <peterz@infradead.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
Sultan Alsawaf <sultan@kerneltoast.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
kitsunyan <kitsunyan@airmail.cc>,
"Brown, Len" <len.brown@intel.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX
Date: Wed, 21 Oct 2020 15:24:33 +0200 [thread overview]
Message-ID: <20201021132433.GI2628@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <ae3367ab7d4eb4778b51f798436ab975d7f8a303.camel@linux.intel.com>
On Tue, Oct 20, 2020 at 10:21:48AM -0700, Srinivas Pandruvada wrote:
> On Mon, 2020-10-19 at 19:15 +0200, Borislav Petkov wrote:
> These command id are model specific. There is no guarantee that even
> meaning changes. So I don't think we should write any code in kernel
> which can't stick.
>
>
> > In any case, my point is that we could have a sysfs interface for
> > those userspace-suppliable values like the undervolt value at
> > [31:21],
> > dunno if the index can be inferred by the kernel automatically or
> > enumerated and the commands we should issue ourselves depending on
> > the
> > functionality, etc.
Why not have a full undervolt driver. That is, don't expose OC_MAILBOX
_at_all_, but have a model specific driver that provides undervolt
capabilities.
Someone is now maintaining this thing in userspace, might as well do it
as a kernel driver and keep all the icky bits inside.
next prev parent reply other threads:[~2020-10-21 13:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:48 [PATCH] x86/msr: do not warn on writes to OC_MAILBOX Jason A. Donenfeld
2020-09-07 10:06 ` Borislav Petkov
2020-09-07 10:46 ` Jason A. Donenfeld
2020-09-07 11:11 ` Borislav Petkov
2020-09-07 11:15 ` Jason A. Donenfeld
2020-09-07 11:23 ` Borislav Petkov
2020-09-08 17:10 ` Srinivas Pandruvada
2020-09-08 17:12 ` Jason A. Donenfeld
2020-09-08 17:25 ` Borislav Petkov
2020-09-08 17:29 ` Jason A. Donenfeld
2020-09-08 17:36 ` Borislav Petkov
2020-09-08 17:42 ` Jason A. Donenfeld
2020-09-08 18:01 ` Borislav Petkov
2020-09-08 19:07 ` Jason A. Donenfeld
2020-09-08 19:18 ` Sultan Alsawaf
2020-09-08 19:30 ` Borislav Petkov
2020-09-08 20:35 ` Andy Lutomirski
2020-09-08 22:32 ` Matthew Garrett
2020-09-09 23:56 ` Andy Lutomirski
2020-09-09 1:02 ` Srinivas Pandruvada
2020-09-10 0:08 ` Andy Lutomirski
2020-10-19 17:15 ` Borislav Petkov
2020-10-20 17:21 ` Srinivas Pandruvada
2020-10-20 17:47 ` Borislav Petkov
2020-10-20 18:40 ` Srinivas Pandruvada
2020-10-20 19:40 ` Dave Hansen
2020-10-21 13:11 ` Srinivas Pandruvada
2020-10-22 19:28 ` Borislav Petkov
2020-10-21 13:24 ` Peter Zijlstra [this message]
2020-09-08 17:31 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021132433.GI2628@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Jason@zx2c4.com \
--cc=bp@alien8.de \
--cc=kitsunyan@airmail.cc \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sultan@kerneltoast.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.