From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
alexaundru.ardelean@analog.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net,
ardeleanalex@gmail.com, kuba@kernel.org
Subject: Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg
Date: Wed, 21 Oct 2020 15:58:02 +0200 [thread overview]
Message-ID: <20201021135802.GM139700@lunn.ch> (raw)
In-Reply-To: <20201021135140.51300-1-alexandru.ardelean@analog.com>
On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote:
> The LINKING_EN bit is always cleared during reset. Initially it was set
> during the downshift setup, because it's in the same register as the
> downshift retry count (PHY_CTRL1).
Hi Alexandru
For those of us how have not read the datasheet, could you give a
brief explanation what LINKING_EN does?
> This change moves the handling of LINKING_EN from the downshift handler to
> the autonegotiation handler. Also, during autonegotiation setup, the
> diagnostics clock is cleared.
And what is the diagnostics clock used for?
Andrew
next prev parent reply other threads:[~2020-10-21 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 13:51 [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg Alexandru Ardelean
2020-10-21 13:51 ` [PATCH 2/2] net: phy: adin: implement cable-test support Alexandru Ardelean
2020-10-21 14:08 ` Andrew Lunn
2020-10-21 14:16 ` Alexandru Ardelean
2020-10-21 14:28 ` Andrew Lunn
2020-10-21 14:46 ` Alexandru Ardelean
2020-10-21 13:58 ` Andrew Lunn [this message]
2020-10-21 14:05 ` [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg Alexandru Ardelean
2020-10-21 14:13 ` Andrew Lunn
2020-10-21 14:23 ` Alexandru Ardelean
2020-10-21 16:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021135802.GM139700@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.ardelean@analog.com \
--cc=alexaundru.ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.