From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 0/3] qom: Simplify pointer property getters/setters
Date: Wed, 21 Oct 2020 15:09:24 +0200 [thread overview]
Message-ID: <20201021150924.5187602e@redhat.com> (raw)
In-Reply-To: <20201009191520.1799419-1-ehabkost@redhat.com>
On Fri, 9 Oct 2020 15:15:17 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:
> The existing pointer property getters/setters are awkward because
> they are expected to work with const variables. If we remove
> that requirement, they can become a lot simpler and simply call
> the visit_type_uint*() functions directly.
see my reply on 'qom: Make all -object types use only class properties' thread.
we should drop pointer property getters/setter instead of extending it.
>
> Git tree: https://github.com/ehabkost/qemu work/qom-ptr-prop-not-const
> Based-on: 20201009160122.1662082-1-ehabkost@redhat.com
>
> Eduardo Habkost (3):
> acpi: Don't pass const pointers to object_property_add_uint*_ptr()
> qom: Make object_property_add_uint*_ptr() get non-const pointers
> qom: Simplify and merge pointer property getters/setters
>
> include/qom/object.h | 8 +--
> hw/acpi/ich9.c | 2 +-
> hw/acpi/piix4.c | 10 ++--
> hw/isa/lpc_ich9.c | 4 +-
> qom/object.c | 122 +++++++++----------------------------------
> 5 files changed, 38 insertions(+), 108 deletions(-)
>
prev parent reply other threads:[~2020-10-21 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 19:15 [PATCH 0/3] qom: Simplify pointer property getters/setters Eduardo Habkost
2020-10-09 19:15 ` [PATCH 1/3] acpi: Don't pass const pointers to object_property_add_uint*_ptr() Eduardo Habkost
2020-10-09 19:15 ` [PATCH 2/3] qom: Make object_property_add_uint*_ptr() get non-const pointers Eduardo Habkost
2020-10-09 19:15 ` [PATCH 3/3] qom: Simplify and merge pointer property getters/setters Eduardo Habkost
2020-10-09 20:02 ` Eric Blake
2020-10-09 20:09 ` fixup! " Eduardo Habkost
2020-10-21 13:09 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021150924.5187602e@redhat.com \
--to=imammedo@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.