All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [jpirko-mlxsw:jiri_devel_xmrouter 11/26] drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:289:55: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry.
Date: Thu, 22 Oct 2020 03:01:55 +0800	[thread overview]
Message-ID: <202010220348.IFLKyJob-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4231 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Jiri Pirko <jiri@nvidia.com>

tree:   https://github.com/jpirko/linux_mlxsw jiri_devel_xmrouter
head:   c452ac0a6496122cc1fcd4f54e3fca1631ac6427
commit: a85ae9826ed2a51277b63beae8413410db09ddae [11/26] mlxsw: spectrum_router_xm: Implement L-value tracking for M-index
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:289:55: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry. [nullPointerRedundantCheck]
    struct mlxsw_sp_router_xm_ltable_node *ltable_node = fib_entry->ltable_node;
                                                         ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:293:6: note: Assuming that condition '!fib_entry' is not redundant
    if (!fib_entry || !fib_entry->ltable_node)
        ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:289:55: note: Null pointer dereference
    struct mlxsw_sp_router_xm_ltable_node *ltable_node = fib_entry->ltable_node;
                                                         ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:291:14: warning: Either the condition '!fib_entry' is redundant or there is possible null pointer dereference: fib_entry. [nullPointerRedundantCheck]
    u8 lvalue = fib_entry->lvalue;
                ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:293:6: note: Assuming that condition '!fib_entry' is not redundant
    if (!fib_entry || !fib_entry->ltable_node)
        ^
   drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c:291:14: note: Null pointer dereference
    u8 lvalue = fib_entry->lvalue;
                ^

vim +289 drivers/net/ethernet/mellanox/mlxsw/spectrum_router_xm.c

a85ae9826ed2a51 Jiri Pirko 2020-07-17  285  
a85ae9826ed2a51 Jiri Pirko 2020-07-17  286  static void mlxsw_sp_router_xm_ml_entry_del(struct mlxsw_sp *mlxsw_sp,
a85ae9826ed2a51 Jiri Pirko 2020-07-17  287  					    struct mlxsw_sp_router_xm_fib_entry *fib_entry)
a85ae9826ed2a51 Jiri Pirko 2020-07-17  288  {
a85ae9826ed2a51 Jiri Pirko 2020-07-17 @289  	struct mlxsw_sp_router_xm_ltable_node *ltable_node = fib_entry->ltable_node;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  290  	struct mlxsw_sp_router_xm *router_xm = mlxsw_sp->router->xm;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  291  	u8 lvalue = fib_entry->lvalue;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  292  
a85ae9826ed2a51 Jiri Pirko 2020-07-17  293  	if (!fib_entry || !fib_entry->ltable_node)
a85ae9826ed2a51 Jiri Pirko 2020-07-17  294  		return;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  295  
a85ae9826ed2a51 Jiri Pirko 2020-07-17  296  	ltable_node->lvalue_ref[lvalue]--;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  297  	if (lvalue == ltable_node->current_lvalue && lvalue &&
a85ae9826ed2a51 Jiri Pirko 2020-07-17  298  	    !ltable_node->lvalue_ref[lvalue]) {
a85ae9826ed2a51 Jiri Pirko 2020-07-17  299  		u8 new_lvalue = lvalue - 1;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  300  
a85ae9826ed2a51 Jiri Pirko 2020-07-17  301  		/* Find the biggest L-value left out there. */
a85ae9826ed2a51 Jiri Pirko 2020-07-17  302  		while (new_lvalue > 0 && !ltable_node->lvalue_ref[lvalue])
a85ae9826ed2a51 Jiri Pirko 2020-07-17  303  			new_lvalue--;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  304  
a85ae9826ed2a51 Jiri Pirko 2020-07-17  305  		ltable_node->current_lvalue = new_lvalue;
a85ae9826ed2a51 Jiri Pirko 2020-07-17  306  		mlxsw_sp_router_xm_ltable_lvalue_set(mlxsw_sp, ltable_node);
a85ae9826ed2a51 Jiri Pirko 2020-07-17  307  	}
a85ae9826ed2a51 Jiri Pirko 2020-07-17  308  
a85ae9826ed2a51 Jiri Pirko 2020-07-17  309  	mlxsw_sp_router_xm_ltable_node_put(router_xm, ltable_node);
a85ae9826ed2a51 Jiri Pirko 2020-07-17  310  }
a85ae9826ed2a51 Jiri Pirko 2020-07-17  311  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

                 reply	other threads:[~2020-10-21 19:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010220348.IFLKyJob-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.