From: Deepak R Varma <mh12gx2825@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com, vaibhav.sr@gmail.com,
mgreer@animalcreek.com, devel@driverdev.osuosl.org
Subject: Re: [Outreachy kernel] Clean up query: greybus/audio_manager_module.c
Date: Thu, 22 Oct 2020 12:16:50 +0530 [thread overview]
Message-ID: <20201022064650.GA351945@ubuntu204> (raw)
In-Reply-To: <20201022052931.GA6093@kroah.com>
On Thu, Oct 22, 2020 at 07:29:31AM +0200, Greg KH wrote:
> On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> > Hello,
> > I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> > and have found that there are several gb_audio_module_*_show functions
> > that accept "struct gb_audio_manager_module_attribute * " as a function
> > parameter. However, this parameter is not used and should not be
> > necessary. Would you suggest cleaning up such functions.
>
> Try removing it and see why it is really needed to be there :)
Sounds exciting. I will definitely do that.
>
> good luck!
Thank you.
Deepak.
>
> greg k-h
next prev parent reply other threads:[~2020-10-22 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 3:37 Clean up query: greybus/audio_manager_module.c Deepak R Varma
2020-10-22 5:29 ` [Outreachy kernel] " Greg KH
2020-10-22 6:46 ` Deepak R Varma [this message]
2020-10-22 7:25 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022064650.GA351945@ubuntu204 \
--to=mh12gx2825@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=mgreer@animalcreek.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.