From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74BFC4363A for ; Thu, 22 Oct 2020 09:09:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA17223FB for ; Thu, 22 Oct 2020 09:09:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA17223FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVWaq-00085a-8G for qemu-devel@archiver.kernel.org; Thu, 22 Oct 2020 05:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVWZi-00072z-0U for qemu-devel@nongnu.org; Thu, 22 Oct 2020 05:07:58 -0400 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]:60717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVWZc-0004RH-U8 for qemu-devel@nongnu.org; Thu, 22 Oct 2020 05:07:57 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.156.21]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 6D0D167DCC09; Thu, 22 Oct 2020 11:07:51 +0200 (CEST) Received: from kaod.org (37.59.142.105) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 22 Oct 2020 11:07:50 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-105G006d9a41d26-7295-4b62-aba0-0190c50c7d81, 519BB44447FDA57395BBEBCDF0C34CC9BD4694BF) smtp.auth=groug@kaod.org Date: Thu, 22 Oct 2020 11:07:49 +0200 From: Greg Kurz To: Christian Schoenebeck Subject: Re: [PATCH v2 7/8] tests/9pfs: add local Tlink test Message-ID: <20201022110749.15488113@bahia.lan> In-Reply-To: <5874251.7R3Ejnc4BG@silver> References: <5874251.7R3Ejnc4BG@silver> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.105] X-ClientProxiedBy: DAG3EX2.mxp5.local (172.16.2.22) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: d9ae243e-f653-4cd9-9ab0-af033f65f2cc X-Ovh-Tracer-Id: 5469340274086877594 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrjeejgdduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeeftdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeetgffffffggfekgeffteekhffhueelffdvhedvgfdthfeiudetvddulefgveevteenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrgh Received-SPF: pass client-ip=178.32.125.2; envelope-from=groug@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 04:37:03 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 21 Oct 2020 20:20:08 +0200 Christian Schoenebeck wrote: > On Mittwoch, 21. Oktober 2020 14:51:09 CEST Christian Schoenebeck wrote: > > This test case uses a Tlink request to create a hard link to a regular > > file using the 9pfs 'local' fs driver. > > > > Signed-off-by: Christian Schoenebeck > > --- > > tests/qtest/virtio-9p-test.c | 71 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > > > diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c > > index 33cba24b18..460fa49fe3 100644 > > --- a/tests/qtest/virtio-9p-test.c > > +++ b/tests/qtest/virtio-9p-test.c > > @@ -260,6 +260,7 @@ static const char *rmessage_name(uint8_t id) > > id == P9_RMKDIR ? "RMKDIR" : > > id == P9_RLCREATE ? "RLCREATE" : > > id == P9_RSYMLINK ? "RSYMLINK" : > > + id == P9_RLINK ? "RLINK" : > > id == P9_RUNLINKAT ? "RUNLINKAT" : > > id == P9_RFLUSH ? "RFLUSH" : > > id == P9_RREADDIR ? "READDIR" : > > @@ -767,6 +768,33 @@ static void v9fs_rsymlink(P9Req *req, v9fs_qid *qid) > > v9fs_req_free(req); > > } > > > > +/* size[4] Tlink tag[2] dfid[4] fid[4] name[s] */ > > +static P9Req *v9fs_tlink(QVirtio9P *v9p, uint32_t dfid, uint32_t fid, > > + const char *name, uint16_t tag) > > +{ > > + P9Req *req; > > + > > + uint32_t body_size = 4 + 4; > > + uint16_t string_size = v9fs_string_size(name); > > + > > + g_assert_cmpint(body_size, <=, UINT32_MAX - string_size); > > + body_size += string_size; > > + > > + req = v9fs_req_init(v9p, body_size, P9_TLINK, tag); > > + v9fs_uint32_write(req, dfid); > > + v9fs_uint32_write(req, fid); > > + v9fs_string_write(req, name); > > + v9fs_req_send(req); > > + return req; > > +} > > + > > +/* size[4] Rlink tag[2] */ > > +static void v9fs_rlink(P9Req *req) > > +{ > > + v9fs_req_recv(req, P9_RLINK); > > + v9fs_req_free(req); > > +} > > + > > /* size[4] Tunlinkat tag[2] dirfd[4] name[s] flags[4] */ > > static P9Req *v9fs_tunlinkat(QVirtio9P *v9p, uint32_t dirfd, const char > > *name, uint32_t flags, uint16_t tag) > > @@ -1142,6 +1170,21 @@ static void do_symlink(QVirtio9P *v9p, const char > > *path, const char *clink, g_free(name); > > } > > > > +/* create a hard link named @a clink in directory @a path pointing to @a to > > */ +static void do_hardlink(QVirtio9P *v9p, const char *path, const char > > *clink, + const char *to) > > +{ > > + uint32_t dfid, fid; > > + P9Req *req; > > + > > + dfid = do_walk(v9p, path); > > + fid = do_walk(v9p, to); > > + > > + req = v9fs_tlink(v9p, dfid, fid, clink, 0); > > + v9fs_req_wait_for_reply(req, NULL); > > + v9fs_rlink(req); > > +} > > + > > static void do_unlinkat(QVirtio9P *v9p, const char *atpath, const char > > *rpath, uint32_t flags) > > { > > @@ -1321,6 +1364,33 @@ static void fs_unlinkat_symlink(void *obj, void > > *data, g_free(real_file); > > } > > > > +static void fs_hardlink_file(void *obj, void *data, QGuestAllocator > > *t_alloc) +{ > > + QVirtio9P *v9p = obj; > > + alloc = t_alloc; > > + struct stat st_real, st_link; > > + char *real_file = virtio_9p_test_path("07/real_file"); > > + char *hardlink_file = virtio_9p_test_path("07/hardlink_file"); > > + > > + do_attach(v9p); > > + do_mkdir(v9p, "/", "07"); > > + do_lcreate(v9p, "07", "real_file"); > > + g_assert(stat(real_file, &st_real) == 0); > > + g_assert((st_real.st_mode & S_IFMT) == S_IFREG); > > + > > + do_hardlink(v9p, "07", "hardlink_file", "07/real_file"); > > + > > + /* check if link exists now ... */ > > + g_assert(stat(hardlink_file, &st_link) == 0); > > + /* ... and it's a hard link, right? */ > > + g_assert((st_link.st_mode & S_IFMT) == S_IFREG); > > + g_assert(st_link.st_dev == st_real.st_dev); > > + g_assert(st_link.st_ino == st_real.st_ino); > > + > > + g_free(hardlink_file); > > + g_free(real_file); > > +} > > + > > static void *assign_9p_local_driver(GString *cmd_line, void *arg) > > { > > virtio_9p_assign_local_driver(cmd_line, "security_model=mapped-xattr"); > > @@ -1367,6 +1437,7 @@ static void register_virtio_9p_test(void) > > qos_add_test("local/symlink_file", "virtio-9p", fs_symlink_file, > > &opts); qos_add_test("local/unlinkat_symlink", "virtio-9p", > > fs_unlinkat_symlink, &opts); > > + qos_add_test("local/hardlink_file", "virtio-9p", fs_hardlink_file, > > &opts); } > > > > libqos_init(register_virtio_9p_test); > > Ok, I found the problem on the mentioned box that failed to create hard links > with 9p: it is libvirt auto generating AppArmor policy rules for 9p export > pathes, which libvirt generates with "rw" AA (AppArmor) permissions. Once I > manually adjusted the AA rule to "rwl", creating hard links worked again. > > I guess I'll send a patch for libvirt to change that. At least IMO creating > hard links with 9pfs is a very basic operation and should be enabled for the > respective 9p export path by default. > > Actually I think it should also include "k" which means "file locking", as > file locking is also a fundamental operation with 9pfs, right? > Well, I don't know exactly why libvirt is generating a strict AppArmor policy but I'm not that surprised. If the user can _easily_ change the policy to fit its needs, it's fine to have a "better safe than sorry" default. > Best regards, > Christian Schoenebeck > >