From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B075BC388F7 for ; Thu, 22 Oct 2020 16:12:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3101922248 for ; Thu, 22 Oct 2020 16:12:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LCzgmstH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="hA7vjpw/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3101922248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D+kVeiSMBaQhsiSJ8Np7vHZPA3nqtRp2Nn/1E/62zn8=; b=LCzgmstHTwWvo9P2nAMhWNK+P nnDvd5dTWvIIFuVG67PLp/mm6pbdxQoI0Kiji2oPmLWVf4ePNEGgF0orw6QSP63axDY8P9gzj3V83 m7ufQdmBLexeCg8KvnL0i/aysTufEH9/HUJUBnDWFvVSR8XGfnx5VXV17uk2oGkzRlCH+5eM4iiYN j5c6dMp+6BCFZc2QMw3Od70cngdxuVVBnwySmDQH2+PNerDsj6T+TxLzkHTPM571PUnmC4Y5SkH8I tmP43GkTPutasXrL8043qkMZe6Xnv+P8NXdwZDI2kSQZnkciZQwgqGX6GxSUeoTzdVEI1URwMNBN3 vzRNEXg7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVdBW-0006Gc-VN; Thu, 22 Oct 2020 16:11:26 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVdBT-0006Fe-PG for linux-arm-kernel@lists.infradead.org; Thu, 22 Oct 2020 16:11:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7dbaiXNZz6VyWN3TkEKY5ylA2arGx7rJcc1WOH9NF+w=; b=hA7vjpw/LgKjasSODeHPA1I6W NEr3qPwZbwPLcZyEVmzSQpeB+RPlkD1rM0/lXkMarHftmK7MIKSAyHiget4QxRp3WgSh3akNAlnmx qyBEWLgCPnr2pegsppXwoEEbf8QukqFlPWEGVMGAiIK2kYgfqFQA91q3PQOMKkfLzMnXjRH4WD3TH xuk0OL/YW2Caf3CDCdxjWsp33ASp6658mSe70GC4o8ZdH0XZnj9bGymal85K7HODY+N7jSCz92GtH 0Q2OIi6Z6pt+OGtUVLSNBtKZzQFtcHOnHIrP1OggI9/vqlh+rHI64fa6+znaWvpUh3xb/pLD+wUFK M96pClZhw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49574) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVdBO-0002H0-UV; Thu, 22 Oct 2020 17:11:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVdBO-0007Xh-8L; Thu, 22 Oct 2020 17:11:18 +0100 Date: Thu, 22 Oct 2020 17:11:18 +0100 From: Russell King - ARM Linux admin To: Ard Biesheuvel Subject: Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error Message-ID: <20201022161118.GP1551@shell.armlinux.org.uk> References: <20201021225737.739-1-digetx@gmail.com> <202010211637.7CFD8435@keescook> <773fbdb0-5fc4-ab39-e72d-89845faa4c6d@gmail.com> <202010212028.32E8A5EF9B@keescook> <1d2e2b5d-3035-238c-d2ca-14c0c209a6a1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201022_121123_843253_12D0F78B X-CRM114-Status: GOOD ( 35.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Nick Desaulniers , Linux Kernel Mailing List , clang-built-linux , Dmitry Osipenko , Ingo Molnar , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMjIsIDIwMjAgYXQgMDY6MDY6MzJQTSArMDIwMCwgQXJkIEJpZXNoZXV2ZWwg d3JvdGU6Cj4gT24gVGh1LCAyMiBPY3QgMjAyMCBhdCAxNzo1NywgRG1pdHJ5IE9zaXBlbmtvIDxk aWdldHhAZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiAyMi4xMC4yMDIwIDEwOjA2LCBBcmQgQmll c2hldXZlbCDQv9C40YjQtdGCOgo+ID4gPiBPbiBUaHUsIDIyIE9jdCAyMDIwIGF0IDA1OjMwLCBL ZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4gd3JvdGU6Cj4gPiA+Pgo+ID4gPj4gT24g VGh1LCBPY3QgMjIsIDIwMjAgYXQgMDM6MDA6MDZBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdy b3RlOgo+ID4gPj4+IDIyLjEwLjIwMjAgMDI6NDAsIEtlZXMgQ29vayDQv9C40YjQtdGCOgo+ID4g Pj4+PiBPbiBUaHUsIE9jdCAyMiwgMjAyMCBhdCAwMTo1NzozN0FNICswMzAwLCBEbWl0cnkgT3Np cGVua28gd3JvdGU6Cj4gPiA+Pj4+PiBUaGUgdmZwX2ttb2RlX2V4Y2VwdGlvbigpIGZ1bmN0aW9u IG5vdyBpcyB1bnJlYWNoYWJsZSB1c2luZyByZWxhdGl2ZQo+ID4gPj4+Pj4gYnJhbmNoaW5nIGlu IFRIVU1CMiBrZXJuZWwgY29uZmlndXJhdGlvbiwgcmVzdWx0aW5nIGluIGEgInJlbG9jYXRpb24K PiA+ID4+Pj4+IHRydW5jYXRlZCB0byBmaXQ6IFJfQVJNX1RITV9KVU1QMTkgYWdhaW5zdCBzeW1i b2wgYHZmcF9rbW9kZV9leGNlcHRpb24nIgo+ID4gPj4+Pj4gbGlua2VyIGVycm9yLiBMZXQncyB1 c2UgbG9uZyBqdW1wIGluIG9yZGVyIHRvIGZpeCB0aGUgaXNzdWUuCj4gPiA+Pj4+Cj4gPiA+Pj4+ IEVlay4gSXMgdGhpcyB3aXRoIGdjYyBvciBjbGFuZz8KPiA+ID4+Pgo+ID4gPj4+IEdDQyA5LjMu MAo+ID4gPj4+Cj4gPiA+Pj4+PiBGaXhlczogZWZmODcyOGZlNjk4ICgidm1saW51eC5sZHMuaDog QWRkIFBHTyBhbmQgQXV0b0ZETyBpbnB1dCBzZWN0aW9ucyIpCj4gPiA+Pj4+Cj4gPiA+Pj4+IEFy ZSB5b3Ugc3VyZSBpdCB3YXNuJ3QgNTEyZGQyZWViZTU1ICgiYXJtL2J1aWxkOiBBZGQgbWlzc2lu ZyBzZWN0aW9ucyIpID8KPiA+ID4+Pj4gVGhhdCBjb21taXQgbWF5IGhhdmUgaW1wbGljaXRseSBt b3ZlZCB0aGUgbG9jYXRpb24gb2YgLnZmcDExX3ZlbmVlciwKPiA+ID4+Pj4gdGhvdWdoIEkgdGhv dWdodCBJIGhhZCBjaG9zZW4gdGhlIGNvcnJlY3QgcG9zaXRpb24uCj4gPiA+Pj4KPiA+ID4+PiBJ IHJlLWNoZWNrZWQgdGhhdCB0aGUgZml4ZXMgdGFnIGlzIGNvcnJlY3QuCj4gPiA+Pj4KPiA+ID4+ Pj4+IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPiA+ ID4+Pj4+IC0tLQo+ID4gPj4+Pj4gIGFyY2gvYXJtL3ZmcC92ZnBody5TIHwgMyArKy0KPiA+ID4+ Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ Pj4+Pgo+ID4gPj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL3ZmcC92ZnBody5TIGIvYXJjaC9h cm0vdmZwL3ZmcGh3LlMKPiA+ID4+Pj4+IGluZGV4IDRmY2ZmOWY1OTk0Ny4uNmUyYjI5ZjBjNDhk IDEwMDY0NAo+ID4gPj4+Pj4gLS0tIGEvYXJjaC9hcm0vdmZwL3ZmcGh3LlMKPiA+ID4+Pj4+ICsr KyBiL2FyY2gvYXJtL3ZmcC92ZnBody5TCj4gPiA+Pj4+PiBAQCAtODIsNyArODIsOCBAQCBFTlRS WSh2ZnBfc3VwcG9ydF9lbnRyeSkKPiA+ID4+Pj4+ICAgIGxkciAgICAgcjMsIFtzcCwgI1NfUFNS XSAgICAgICAgQCBOZWl0aGVyIGxhenkgcmVzdG9yZSBub3IgRlAgZXhjZXB0aW9ucwo+ID4gPj4+ Pj4gICAgYW5kICAgICByMywgcjMsICNNT0RFX01BU0sgICAgICBAIGFyZSBzdXBwb3J0ZWQgaW4g a2VybmVsIG1vZGUKPiA+ID4+Pj4+ICAgIHRlcSAgICAgcjMsICNVU1JfTU9ERQo+ID4gPj4+Pj4g LSAgYm5lICAgICB2ZnBfa21vZGVfZXhjZXB0aW9uICAgICBAIFJldHVybnMgdGhyb3VnaCBscgo+ ID4gPj4+Pj4gKyAgbGRyICAgICByMSwgPXZmcF9rbW9kZV9leGNlcHRpb24KPiA+ID4+Pj4+ICsg IGJ4bmUgICAgcjEgICAgICAgICAgICAgICAgICAgICAgQCBSZXR1cm5zIHRocm91Z2ggbHIKPiA+ ID4+Pj4+Cj4gPiA+Pj4+PiAgICBWRlBGTVJYIHIxLCBGUEVYQyAgICAgICAgICAgICAgIEAgSXMg dGhlIFZGUCBlbmFibGVkPwo+ID4gPj4+Pj4gICAgREJHU1RSMSAiZnBleGMgJTA4eCIsIHIxCj4g PiA+Pj4+Cj4gPiA+Pj4+IFRoaXMgc2VlbXMgbGlrZSBhIHdvcmthcm91bmQgdGhvdWdoPyBJIHN1 c3BlY3QgdGhlIHZmcDExX3ZlbmVlciBuZWVkcwo+ID4gPj4+PiBtb3Zpbmc/Cj4gPiA+Pj4+Cj4g PiA+Pj4KPiA+ID4+PiBJIGRvbid0IGtub3cgd2hlcmUgaXQgbmVlZHMgdG8gYmUgbW92ZWQuIFBs ZWFzZSBmZWVsIGZyZWUgdG8gbWFrZSBhCj4gPiA+Pj4gcGF0Y2ggaWYgeW91IGhhdmUgYSBiZXR0 ZXIgaWRlYSwgSSdsbCBiZSBnbGFkIHRvIHRlc3QgaXQuCj4gPiA+Pgo+ID4gPj4gSSBtaWdodCBo YXZlIGp1c3QgYmVlbiBkaXN0cmFjdGVkIGJ5IHRoZSBjb21tb24gInZmcCIgcHJlZml4LiBJdCdz Cj4gPiA+PiBwb3NzaWJsZSB0aGF0IHRoZSB0ZXh0IHNlY3Rpb24gc2h1ZmZsaW5nIGp1c3QgZW5k ZWQgdXAgYmVpbmcgdmVyeSBsYXJnZSwKPiA+ID4+IHNvIHByb2JhYmx5IHRoaXMgcGF0Y2ggaXMg cmlnaHQgdGhlbiEKPiA+ID4+Cj4gPiA+Cj4gPiA+IEkgYWxyZWFkeSBzZW50IGEgZml4IGZvciB0 aGlzIGlzc3VlOgo+ID4gPgo+ID4gPiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxv cGVyL3BhdGNoZXMvdmlld3BhdGNoLnBocD9pZD05MDE4LzEKPiA+ID4KPiA+Cj4gPiBUaGUgb2Zm ZW5kaW5nIGNvbW1pdCBjb250YWlucyBzdGFibGUgdGFnLCBzbyBJIGFzc3VtZSB0aGF0IGZpeGVz IHRhZyBpcwo+ID4gbWFuZGF0b3J5LiBZb3VycyBwYXRjaCBtaXNzZXMgdGhlIGZpeGVzIHRhZy4K PiAKPiBSdXNzZWxsLCBtaW5kIGFkZGluZyB0aGF0PyBPciB3b3VsZCB5b3UgbGlrZSBtZSB0byB1 cGRhdGUgdGhlIHBhdGNoIGluCj4gdGhlIHBhdGNoIHN5c3RlbT8KClJhdGhlciB0aGFuIGFkZGlu ZyB0aGUgSVQsIEknbSBzdWdnZXN0aW5nIHRoYXQgd2Ugc29sdmUgaXQgYSBkaWZmZXJlbnQKd2F5 IC0gZW5zdXJpbmcgdGhhdCB0aGUgdHdvIGJpdHMgb2YgY29kZSBhcmUgY28tbG9jYXRlZC4gVGhl cmUncyBubwpyZWFzb24gZm9yIHRoZW0gdG8gYmUgc2VwYXJhdGVkLCBhbmQgdGhlIGFzc2VtYmx5 IGNvZGUgZW50cnkgcG9pbnQgaXMKYWxyZWFkeSBjYWxsZWQgaW5kaXJlY3RseS4KClRoZSBwcm9i bGVtIGlzIHRoZSBhc3NlbWJseSBlbmRzIHVwIGluIHRoZSAudGV4dCBzZWN0aW9uIHdoaWNoIGVu ZHMgdXAKYXQgdGhlIHN0YXJ0IG9mIHRoZSBiaW5hcnksIGJ1dCBkZXBlbmRpbmcgb24gdGhlIGNv bXBpbGVyLCBmdW5jdGlvbnMKaW4gLmMgZmlsZXMgZW5kIHVwIGluIHRoZWlyIG93biBzZWN0aW9u cy4gSXQgd291bGQgYmUgZ29vZCBpZiwgYXMKRG1pdHJ5IGhhcyBzaG93biB0aGF0IGl0IGlzIGlu ZGVlZCBwb3NzaWJsZSwgdG8gaGF2ZSB0aGVtIGNvLWxvY2F0ZWQuCgotLSAKUk1LJ3MgUGF0Y2gg c3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZU VFAgaXMgaGVyZSEgNDBNYnBzIGRvd24gMTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0 IGxhc3QhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B0BC388F7 for ; Thu, 22 Oct 2020 16:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8CA72463D for ; Thu, 22 Oct 2020 16:11:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="hA7vjpw/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895927AbgJVQLW (ORCPT ); Thu, 22 Oct 2020 12:11:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895886AbgJVQLW (ORCPT ); Thu, 22 Oct 2020 12:11:22 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB3B4C0613CE for ; Thu, 22 Oct 2020 09:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7dbaiXNZz6VyWN3TkEKY5ylA2arGx7rJcc1WOH9NF+w=; b=hA7vjpw/LgKjasSODeHPA1I6W NEr3qPwZbwPLcZyEVmzSQpeB+RPlkD1rM0/lXkMarHftmK7MIKSAyHiget4QxRp3WgSh3akNAlnmx qyBEWLgCPnr2pegsppXwoEEbf8QukqFlPWEGVMGAiIK2kYgfqFQA91q3PQOMKkfLzMnXjRH4WD3TH xuk0OL/YW2Caf3CDCdxjWsp33ASp6658mSe70GC4o8ZdH0XZnj9bGymal85K7HODY+N7jSCz92GtH 0Q2OIi6Z6pt+OGtUVLSNBtKZzQFtcHOnHIrP1OggI9/vqlh+rHI64fa6+znaWvpUh3xb/pLD+wUFK M96pClZhw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49574) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVdBO-0002H0-UV; Thu, 22 Oct 2020 17:11:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVdBO-0007Xh-8L; Thu, 22 Oct 2020 17:11:18 +0100 Date: Thu, 22 Oct 2020 17:11:18 +0100 From: Russell King - ARM Linux admin To: Ard Biesheuvel Cc: Dmitry Osipenko , Kees Cook , Nick Desaulniers , Linux Kernel Mailing List , clang-built-linux , Ingo Molnar , Linux ARM Subject: Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error Message-ID: <20201022161118.GP1551@shell.armlinux.org.uk> References: <20201021225737.739-1-digetx@gmail.com> <202010211637.7CFD8435@keescook> <773fbdb0-5fc4-ab39-e72d-89845faa4c6d@gmail.com> <202010212028.32E8A5EF9B@keescook> <1d2e2b5d-3035-238c-d2ca-14c0c209a6a1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2020 at 06:06:32PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Oct 2020 at 17:57, Dmitry Osipenko wrote: > > > > 22.10.2020 10:06, Ard Biesheuvel пишет: > > > On Thu, 22 Oct 2020 at 05:30, Kees Cook wrote: > > >> > > >> On Thu, Oct 22, 2020 at 03:00:06AM +0300, Dmitry Osipenko wrote: > > >>> 22.10.2020 02:40, Kees Cook пишет: > > >>>> On Thu, Oct 22, 2020 at 01:57:37AM +0300, Dmitry Osipenko wrote: > > >>>>> The vfp_kmode_exception() function now is unreachable using relative > > >>>>> branching in THUMB2 kernel configuration, resulting in a "relocation > > >>>>> truncated to fit: R_ARM_THM_JUMP19 against symbol `vfp_kmode_exception'" > > >>>>> linker error. Let's use long jump in order to fix the issue. > > >>>> > > >>>> Eek. Is this with gcc or clang? > > >>> > > >>> GCC 9.3.0 > > >>> > > >>>>> Fixes: eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections") > > >>>> > > >>>> Are you sure it wasn't 512dd2eebe55 ("arm/build: Add missing sections") ? > > >>>> That commit may have implicitly moved the location of .vfp11_veneer, > > >>>> though I thought I had chosen the correct position. > > >>> > > >>> I re-checked that the fixes tag is correct. > > >>> > > >>>>> Signed-off-by: Dmitry Osipenko > > >>>>> --- > > >>>>> arch/arm/vfp/vfphw.S | 3 ++- > > >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) > > >>>>> > > >>>>> diff --git a/arch/arm/vfp/vfphw.S b/arch/arm/vfp/vfphw.S > > >>>>> index 4fcff9f59947..6e2b29f0c48d 100644 > > >>>>> --- a/arch/arm/vfp/vfphw.S > > >>>>> +++ b/arch/arm/vfp/vfphw.S > > >>>>> @@ -82,7 +82,8 @@ ENTRY(vfp_support_entry) > > >>>>> ldr r3, [sp, #S_PSR] @ Neither lazy restore nor FP exceptions > > >>>>> and r3, r3, #MODE_MASK @ are supported in kernel mode > > >>>>> teq r3, #USR_MODE > > >>>>> - bne vfp_kmode_exception @ Returns through lr > > >>>>> + ldr r1, =vfp_kmode_exception > > >>>>> + bxne r1 @ Returns through lr > > >>>>> > > >>>>> VFPFMRX r1, FPEXC @ Is the VFP enabled? > > >>>>> DBGSTR1 "fpexc %08x", r1 > > >>>> > > >>>> This seems like a workaround though? I suspect the vfp11_veneer needs > > >>>> moving? > > >>>> > > >>> > > >>> I don't know where it needs to be moved. Please feel free to make a > > >>> patch if you have a better idea, I'll be glad to test it. > > >> > > >> I might have just been distracted by the common "vfp" prefix. It's > > >> possible that the text section shuffling just ended up being very large, > > >> so probably this patch is right then! > > >> > > > > > > I already sent a fix for this issue: > > > > > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9018/1 > > > > > > > The offending commit contains stable tag, so I assume that fixes tag is > > mandatory. Yours patch misses the fixes tag. > > Russell, mind adding that? Or would you like me to update the patch in > the patch system? Rather than adding the IT, I'm suggesting that we solve it a different way - ensuring that the two bits of code are co-located. There's no reason for them to be separated, and the assembly code entry point is already called indirectly. The problem is the assembly ends up in the .text section which ends up at the start of the binary, but depending on the compiler, functions in .c files end up in their own sections. It would be good if, as Dmitry has shown that it is indeed possible, to have them co-located. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!