From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2EEC388F9 for ; Thu, 22 Oct 2020 16:25:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ED782463D for ; Thu, 22 Oct 2020 16:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BRJ/L2/U"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="oBZuHDgw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ED782463D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WDsSC86ZATO+Ke8DJxGT1mJGtJDpDgrOXXznxg5Aqh0=; b=BRJ/L2/UU6OSYnMdAsIdzDH/4 Hz1eLIQFB227uE0fq7agWj6bQ4derkTmbJ2OOY2p1KTRUZnT98DykrIg1C5nJd89odO1CKiO+KqJQ zrWMz9Kr34dAhaynTzwOWb7AH6WbQrKdwtpsQBfOfLAHcGAYhd9yJh4t2pAN9W27DnqJ9i3gxteCW /GHwJuofLALPYLD+BHE5af9L9vqAyRutlsxJuutHFoXDeSrIqqfzYA9INixInvKb+TogU6K3nqWuQ D8NSCCUh5TAqP8of8HMr5p8AGiojIpf3X+UhnOPMcJvF5V4vEQjdKKOrSv5q43P673sJveUfr2hBa XH8UicUYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVdNP-00089J-Gq; Thu, 22 Oct 2020 16:23:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVdNN-00088N-3w for linux-arm-kernel@lists.infradead.org; Thu, 22 Oct 2020 16:23:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qx//rllWCp4Aw9Y+j8oLuNI/zBX7cIb9yVaUMv2x7k0=; b=oBZuHDgw4DeXYQPGB8Q+Brmz9 RAEQbjI7+qzhoYXHsbPL6b4mjeKA71Sqa5q5eprKA04jF5Ay00ZHmkvDUTFnk96GhmUcYGwuOtzBp /StxxSD4J8d6nqfLvglLXidTl9pdbbkdNbtlXKr4cfCdG5DIgSR0jnOklIzWbx9QCM2d+gxfYDcUx nRNHN6siVg7Sx2YJLl6So1coJl5KNPsLHrfRWrXhN2A4iQx3A1ezC5uzt2hcIPt/N8PODBcd0BvGt 2KgHJskbg/AQkwyzwgqWCpHpsVMzE4vqMvataxXeG9i24GWPAbJf1JVffWSLMpMquWN4s8Kf+OYE1 4lux2JiMQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49576) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVdNH-0002I1-1q; Thu, 22 Oct 2020 17:23:35 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVdNG-0007Xt-Bf; Thu, 22 Oct 2020 17:23:34 +0100 Date: Thu, 22 Oct 2020 17:23:34 +0100 From: Russell King - ARM Linux admin To: Ard Biesheuvel Subject: Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error Message-ID: <20201022162334.GQ1551@shell.armlinux.org.uk> References: <20201021225737.739-1-digetx@gmail.com> <202010211637.7CFD8435@keescook> <773fbdb0-5fc4-ab39-e72d-89845faa4c6d@gmail.com> <202010212028.32E8A5EF9B@keescook> <1d2e2b5d-3035-238c-d2ca-14c0c209a6a1@gmail.com> <20201022161118.GP1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201022_122341_166603_685136C2 X-CRM114-Status: GOOD ( 41.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Nick Desaulniers , Linux Kernel Mailing List , clang-built-linux , Dmitry Osipenko , Ingo Molnar , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMjIsIDIwMjAgYXQgMDY6MjA6NDBQTSArMDIwMCwgQXJkIEJpZXNoZXV2ZWwg d3JvdGU6Cj4gT24gVGh1LCAyMiBPY3QgMjAyMCBhdCAxODoxMSwgUnVzc2VsbCBLaW5nIC0gQVJN IExpbnV4IGFkbWluCj4gPGxpbnV4QGFybWxpbnV4Lm9yZy51az4gd3JvdGU6Cj4gPgo+ID4gT24g VGh1LCBPY3QgMjIsIDIwMjAgYXQgMDY6MDY6MzJQTSArMDIwMCwgQXJkIEJpZXNoZXV2ZWwgd3Jv dGU6Cj4gPiA+IE9uIFRodSwgMjIgT2N0IDIwMjAgYXQgMTc6NTcsIERtaXRyeSBPc2lwZW5rbyA8 ZGlnZXR4QGdtYWlsLmNvbT4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiAyMi4xMC4yMDIwIDEwOjA2 LCBBcmQgQmllc2hldXZlbCDQv9C40YjQtdGCOgo+ID4gPiA+ID4gT24gVGh1LCAyMiBPY3QgMjAy MCBhdCAwNTozMCwgS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5vcmc+IHdyb3RlOgo+ID4g PiA+ID4+Cj4gPiA+ID4gPj4gT24gVGh1LCBPY3QgMjIsIDIwMjAgYXQgMDM6MDA6MDZBTSArMDMw MCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+ID4gPiA+ID4+PiAyMi4xMC4yMDIwIDAyOjQwLCBL ZWVzIENvb2sg0L/QuNGI0LXRgjoKPiA+ID4gPiA+Pj4+IE9uIFRodSwgT2N0IDIyLCAyMDIwIGF0 IDAxOjU3OjM3QU0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+ID4gPiA+Pj4+PiBU aGUgdmZwX2ttb2RlX2V4Y2VwdGlvbigpIGZ1bmN0aW9uIG5vdyBpcyB1bnJlYWNoYWJsZSB1c2lu ZyByZWxhdGl2ZQo+ID4gPiA+ID4+Pj4+IGJyYW5jaGluZyBpbiBUSFVNQjIga2VybmVsIGNvbmZp Z3VyYXRpb24sIHJlc3VsdGluZyBpbiBhICJyZWxvY2F0aW9uCj4gPiA+ID4gPj4+Pj4gdHJ1bmNh dGVkIHRvIGZpdDogUl9BUk1fVEhNX0pVTVAxOSBhZ2FpbnN0IHN5bWJvbCBgdmZwX2ttb2RlX2V4 Y2VwdGlvbiciCj4gPiA+ID4gPj4+Pj4gbGlua2VyIGVycm9yLiBMZXQncyB1c2UgbG9uZyBqdW1w IGluIG9yZGVyIHRvIGZpeCB0aGUgaXNzdWUuCj4gPiA+ID4gPj4+Pgo+ID4gPiA+ID4+Pj4gRWVr LiBJcyB0aGlzIHdpdGggZ2NjIG9yIGNsYW5nPwo+ID4gPiA+ID4+Pgo+ID4gPiA+ID4+PiBHQ0Mg OS4zLjAKPiA+ID4gPiA+Pj4KPiA+ID4gPiA+Pj4+PiBGaXhlczogZWZmODcyOGZlNjk4ICgidm1s aW51eC5sZHMuaDogQWRkIFBHTyBhbmQgQXV0b0ZETyBpbnB1dCBzZWN0aW9ucyIpCj4gPiA+ID4g Pj4+Pgo+ID4gPiA+ID4+Pj4gQXJlIHlvdSBzdXJlIGl0IHdhc24ndCA1MTJkZDJlZWJlNTUgKCJh cm0vYnVpbGQ6IEFkZCBtaXNzaW5nIHNlY3Rpb25zIikgPwo+ID4gPiA+ID4+Pj4gVGhhdCBjb21t aXQgbWF5IGhhdmUgaW1wbGljaXRseSBtb3ZlZCB0aGUgbG9jYXRpb24gb2YgLnZmcDExX3ZlbmVl ciwKPiA+ID4gPiA+Pj4+IHRob3VnaCBJIHRob3VnaHQgSSBoYWQgY2hvc2VuIHRoZSBjb3JyZWN0 IHBvc2l0aW9uLgo+ID4gPiA+ID4+Pgo+ID4gPiA+ID4+PiBJIHJlLWNoZWNrZWQgdGhhdCB0aGUg Zml4ZXMgdGFnIGlzIGNvcnJlY3QuCj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+Pj4gU2lnbmVkLW9m Zi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPgo+ID4gPiA+ID4+Pj4+IC0t LQo+ID4gPiA+ID4+Pj4+ICBhcmNoL2FybS92ZnAvdmZwaHcuUyB8IDMgKystCj4gPiA+ID4gPj4+ Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4g PiA+Pj4+Pgo+ID4gPiA+ID4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS92ZnAvdmZwaHcuUyBi L2FyY2gvYXJtL3ZmcC92ZnBody5TCj4gPiA+ID4gPj4+Pj4gaW5kZXggNGZjZmY5ZjU5OTQ3Li42 ZTJiMjlmMGM0OGQgMTAwNjQ0Cj4gPiA+ID4gPj4+Pj4gLS0tIGEvYXJjaC9hcm0vdmZwL3ZmcGh3 LlMKPiA+ID4gPiA+Pj4+PiArKysgYi9hcmNoL2FybS92ZnAvdmZwaHcuUwo+ID4gPiA+ID4+Pj4+ IEBAIC04Miw3ICs4Miw4IEBAIEVOVFJZKHZmcF9zdXBwb3J0X2VudHJ5KQo+ID4gPiA+ID4+Pj4+ ICAgIGxkciAgICAgcjMsIFtzcCwgI1NfUFNSXSAgICAgICAgQCBOZWl0aGVyIGxhenkgcmVzdG9y ZSBub3IgRlAgZXhjZXB0aW9ucwo+ID4gPiA+ID4+Pj4+ICAgIGFuZCAgICAgcjMsIHIzLCAjTU9E RV9NQVNLICAgICAgQCBhcmUgc3VwcG9ydGVkIGluIGtlcm5lbCBtb2RlCj4gPiA+ID4gPj4+Pj4g ICAgdGVxICAgICByMywgI1VTUl9NT0RFCj4gPiA+ID4gPj4+Pj4gLSAgYm5lICAgICB2ZnBfa21v ZGVfZXhjZXB0aW9uICAgICBAIFJldHVybnMgdGhyb3VnaCBscgo+ID4gPiA+ID4+Pj4+ICsgIGxk ciAgICAgcjEsID12ZnBfa21vZGVfZXhjZXB0aW9uCj4gPiA+ID4gPj4+Pj4gKyAgYnhuZSAgICBy MSAgICAgICAgICAgICAgICAgICAgICBAIFJldHVybnMgdGhyb3VnaCBscgo+ID4gPiA+ID4+Pj4+ Cj4gPiA+ID4gPj4+Pj4gICAgVkZQRk1SWCByMSwgRlBFWEMgICAgICAgICAgICAgICBAIElzIHRo ZSBWRlAgZW5hYmxlZD8KPiA+ID4gPiA+Pj4+PiAgICBEQkdTVFIxICJmcGV4YyAlMDh4IiwgcjEK PiA+ID4gPiA+Pj4+Cj4gPiA+ID4gPj4+PiBUaGlzIHNlZW1zIGxpa2UgYSB3b3JrYXJvdW5kIHRo b3VnaD8gSSBzdXNwZWN0IHRoZSB2ZnAxMV92ZW5lZXIgbmVlZHMKPiA+ID4gPiA+Pj4+IG1vdmlu Zz8KPiA+ID4gPiA+Pj4+Cj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+IEkgZG9uJ3Qga25vdyB3aGVy ZSBpdCBuZWVkcyB0byBiZSBtb3ZlZC4gUGxlYXNlIGZlZWwgZnJlZSB0byBtYWtlIGEKPiA+ID4g PiA+Pj4gcGF0Y2ggaWYgeW91IGhhdmUgYSBiZXR0ZXIgaWRlYSwgSSdsbCBiZSBnbGFkIHRvIHRl c3QgaXQuCj4gPiA+ID4gPj4KPiA+ID4gPiA+PiBJIG1pZ2h0IGhhdmUganVzdCBiZWVuIGRpc3Ry YWN0ZWQgYnkgdGhlIGNvbW1vbiAidmZwIiBwcmVmaXguIEl0J3MKPiA+ID4gPiA+PiBwb3NzaWJs ZSB0aGF0IHRoZSB0ZXh0IHNlY3Rpb24gc2h1ZmZsaW5nIGp1c3QgZW5kZWQgdXAgYmVpbmcgdmVy eSBsYXJnZSwKPiA+ID4gPiA+PiBzbyBwcm9iYWJseSB0aGlzIHBhdGNoIGlzIHJpZ2h0IHRoZW4h Cj4gPiA+ID4gPj4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBJIGFscmVhZHkgc2VudCBhIGZpeCBmb3Ig dGhpcyBpc3N1ZToKPiA+ID4gPiA+Cj4gPiA+ID4gPiBodHRwczovL3d3dy5hcm1saW51eC5vcmcu dWsvZGV2ZWxvcGVyL3BhdGNoZXMvdmlld3BhdGNoLnBocD9pZD05MDE4LzEKPiA+ID4gPiA+Cj4g PiA+ID4KPiA+ID4gPiBUaGUgb2ZmZW5kaW5nIGNvbW1pdCBjb250YWlucyBzdGFibGUgdGFnLCBz byBJIGFzc3VtZSB0aGF0IGZpeGVzIHRhZyBpcwo+ID4gPiA+IG1hbmRhdG9yeS4gWW91cnMgcGF0 Y2ggbWlzc2VzIHRoZSBmaXhlcyB0YWcuCj4gPiA+Cj4gPiA+IFJ1c3NlbGwsIG1pbmQgYWRkaW5n IHRoYXQ/IE9yIHdvdWxkIHlvdSBsaWtlIG1lIHRvIHVwZGF0ZSB0aGUgcGF0Y2ggaW4KPiA+ID4g dGhlIHBhdGNoIHN5c3RlbT8KPiA+Cj4gPiBSYXRoZXIgdGhhbiBhZGRpbmcgdGhlIElULCBJJ20g c3VnZ2VzdGluZyB0aGF0IHdlIHNvbHZlIGl0IGEgZGlmZmVyZW50Cj4gPiB3YXkgLSBlbnN1cmlu ZyB0aGF0IHRoZSB0d28gYml0cyBvZiBjb2RlIGFyZSBjby1sb2NhdGVkLiBUaGVyZSdzIG5vCj4g PiByZWFzb24gZm9yIHRoZW0gdG8gYmUgc2VwYXJhdGVkLCBhbmQgdGhlIGFzc2VtYmx5IGNvZGUg ZW50cnkgcG9pbnQgaXMKPiA+IGFscmVhZHkgY2FsbGVkIGluZGlyZWN0bHkuCj4gPgo+ID4gVGhl IHByb2JsZW0gaXMgdGhlIGFzc2VtYmx5IGVuZHMgdXAgaW4gdGhlIC50ZXh0IHNlY3Rpb24gd2hp Y2ggZW5kcyB1cAo+ID4gYXQgdGhlIHN0YXJ0IG9mIHRoZSBiaW5hcnksIGJ1dCBkZXBlbmRpbmcg b24gdGhlIGNvbXBpbGVyLCBmdW5jdGlvbnMKPiA+IGluIC5jIGZpbGVzIGVuZCB1cCBpbiB0aGVp ciBvd24gc2VjdGlvbnMuIEl0IHdvdWxkIGJlIGdvb2QgaWYsIGFzCj4gPiBEbWl0cnkgaGFzIHNo b3duIHRoYXQgaXQgaXMgaW5kZWVkIHBvc3NpYmxlLCB0byBoYXZlIHRoZW0gY28tbG9jYXRlZC4K PiAKPiBXaHkgaXMgdGhhdCBiZXR0ZXI/IEkgcHJvdmlkZWQgYSBtaW5pbWFsIGZpeCB3aGljaCBo YXMgemVybyBpbXBhY3Qgb24KPiBBUk0gYnVpbGRzLCBhbmQgbWluaW1hbCBpbXBhY3Qgb24gVGh1 bWIyIGJ1aWxkcywgZ2l2ZW4gdGhhdCBpdCByZXRhaW5zCj4gdGhlIGV4YWN0IHNhbWUgc2VtYW50 aWNzIGFzIGJlZm9yZSwgYnV0IHVzaW5nIGEgZGlmZmVyZW50IG9wY29kZS4KCkkgdGhpbmsgeW91 IGp1c3QgZGVzY3JpYmVkIHRoZSByZWFzb24gdGhlcmUuIFdoeSBzaG91bGQgd2UgZm9yY2UKZXZl cnl0aGluZyB0byB1c2UgYSBkaWZmZXJlbnQgb3Bjb2RlIHdoZW4gYSBzaG9ydCBqdW1wIF9zaG91 bGRfCnN1ZmZpY2U/CgpZb3VyIHBhdGNoIG1heSBiZSBhIHNpbmdsZSBsaW5lLCBidXQgaXQgaGFz IGEgc2xpZ2h0bHkgZ3JlYXRlcgppbXBhY3QgdGhhbiB0aGUgYWx0ZXJuYXRpdmUgdHdvIGxpbmUg c29sdXRpb24uCgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5v cmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVFAgaXMgaGVyZSEgNDBNYnBzIGRvd24gMTBNYnBz IHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0IGxhc3QhCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F25C388F7 for ; Thu, 22 Oct 2020 16:23:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B096C24641 for ; Thu, 22 Oct 2020 16:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="oBZuHDgw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2901670AbgJVQXi (ORCPT ); Thu, 22 Oct 2020 12:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2901662AbgJVQXi (ORCPT ); Thu, 22 Oct 2020 12:23:38 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A65CC0613CE for ; Thu, 22 Oct 2020 09:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qx//rllWCp4Aw9Y+j8oLuNI/zBX7cIb9yVaUMv2x7k0=; b=oBZuHDgw4DeXYQPGB8Q+Brmz9 RAEQbjI7+qzhoYXHsbPL6b4mjeKA71Sqa5q5eprKA04jF5Ay00ZHmkvDUTFnk96GhmUcYGwuOtzBp /StxxSD4J8d6nqfLvglLXidTl9pdbbkdNbtlXKr4cfCdG5DIgSR0jnOklIzWbx9QCM2d+gxfYDcUx nRNHN6siVg7Sx2YJLl6So1coJl5KNPsLHrfRWrXhN2A4iQx3A1ezC5uzt2hcIPt/N8PODBcd0BvGt 2KgHJskbg/AQkwyzwgqWCpHpsVMzE4vqMvataxXeG9i24GWPAbJf1JVffWSLMpMquWN4s8Kf+OYE1 4lux2JiMQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49576) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVdNH-0002I1-1q; Thu, 22 Oct 2020 17:23:35 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVdNG-0007Xt-Bf; Thu, 22 Oct 2020 17:23:34 +0100 Date: Thu, 22 Oct 2020 17:23:34 +0100 From: Russell King - ARM Linux admin To: Ard Biesheuvel Cc: Dmitry Osipenko , Kees Cook , Nick Desaulniers , Linux Kernel Mailing List , clang-built-linux , Ingo Molnar , Linux ARM Subject: Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error Message-ID: <20201022162334.GQ1551@shell.armlinux.org.uk> References: <20201021225737.739-1-digetx@gmail.com> <202010211637.7CFD8435@keescook> <773fbdb0-5fc4-ab39-e72d-89845faa4c6d@gmail.com> <202010212028.32E8A5EF9B@keescook> <1d2e2b5d-3035-238c-d2ca-14c0c209a6a1@gmail.com> <20201022161118.GP1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2020 at 06:20:40PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Oct 2020 at 18:11, Russell King - ARM Linux admin > wrote: > > > > On Thu, Oct 22, 2020 at 06:06:32PM +0200, Ard Biesheuvel wrote: > > > On Thu, 22 Oct 2020 at 17:57, Dmitry Osipenko wrote: > > > > > > > > 22.10.2020 10:06, Ard Biesheuvel пишет: > > > > > On Thu, 22 Oct 2020 at 05:30, Kees Cook wrote: > > > > >> > > > > >> On Thu, Oct 22, 2020 at 03:00:06AM +0300, Dmitry Osipenko wrote: > > > > >>> 22.10.2020 02:40, Kees Cook пишет: > > > > >>>> On Thu, Oct 22, 2020 at 01:57:37AM +0300, Dmitry Osipenko wrote: > > > > >>>>> The vfp_kmode_exception() function now is unreachable using relative > > > > >>>>> branching in THUMB2 kernel configuration, resulting in a "relocation > > > > >>>>> truncated to fit: R_ARM_THM_JUMP19 against symbol `vfp_kmode_exception'" > > > > >>>>> linker error. Let's use long jump in order to fix the issue. > > > > >>>> > > > > >>>> Eek. Is this with gcc or clang? > > > > >>> > > > > >>> GCC 9.3.0 > > > > >>> > > > > >>>>> Fixes: eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections") > > > > >>>> > > > > >>>> Are you sure it wasn't 512dd2eebe55 ("arm/build: Add missing sections") ? > > > > >>>> That commit may have implicitly moved the location of .vfp11_veneer, > > > > >>>> though I thought I had chosen the correct position. > > > > >>> > > > > >>> I re-checked that the fixes tag is correct. > > > > >>> > > > > >>>>> Signed-off-by: Dmitry Osipenko > > > > >>>>> --- > > > > >>>>> arch/arm/vfp/vfphw.S | 3 ++- > > > > >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > >>>>> > > > > >>>>> diff --git a/arch/arm/vfp/vfphw.S b/arch/arm/vfp/vfphw.S > > > > >>>>> index 4fcff9f59947..6e2b29f0c48d 100644 > > > > >>>>> --- a/arch/arm/vfp/vfphw.S > > > > >>>>> +++ b/arch/arm/vfp/vfphw.S > > > > >>>>> @@ -82,7 +82,8 @@ ENTRY(vfp_support_entry) > > > > >>>>> ldr r3, [sp, #S_PSR] @ Neither lazy restore nor FP exceptions > > > > >>>>> and r3, r3, #MODE_MASK @ are supported in kernel mode > > > > >>>>> teq r3, #USR_MODE > > > > >>>>> - bne vfp_kmode_exception @ Returns through lr > > > > >>>>> + ldr r1, =vfp_kmode_exception > > > > >>>>> + bxne r1 @ Returns through lr > > > > >>>>> > > > > >>>>> VFPFMRX r1, FPEXC @ Is the VFP enabled? > > > > >>>>> DBGSTR1 "fpexc %08x", r1 > > > > >>>> > > > > >>>> This seems like a workaround though? I suspect the vfp11_veneer needs > > > > >>>> moving? > > > > >>>> > > > > >>> > > > > >>> I don't know where it needs to be moved. Please feel free to make a > > > > >>> patch if you have a better idea, I'll be glad to test it. > > > > >> > > > > >> I might have just been distracted by the common "vfp" prefix. It's > > > > >> possible that the text section shuffling just ended up being very large, > > > > >> so probably this patch is right then! > > > > >> > > > > > > > > > > I already sent a fix for this issue: > > > > > > > > > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9018/1 > > > > > > > > > > > > > The offending commit contains stable tag, so I assume that fixes tag is > > > > mandatory. Yours patch misses the fixes tag. > > > > > > Russell, mind adding that? Or would you like me to update the patch in > > > the patch system? > > > > Rather than adding the IT, I'm suggesting that we solve it a different > > way - ensuring that the two bits of code are co-located. There's no > > reason for them to be separated, and the assembly code entry point is > > already called indirectly. > > > > The problem is the assembly ends up in the .text section which ends up > > at the start of the binary, but depending on the compiler, functions > > in .c files end up in their own sections. It would be good if, as > > Dmitry has shown that it is indeed possible, to have them co-located. > > Why is that better? I provided a minimal fix which has zero impact on > ARM builds, and minimal impact on Thumb2 builds, given that it retains > the exact same semantics as before, but using a different opcode. I think you just described the reason there. Why should we force everything to use a different opcode when a short jump _should_ suffice? Your patch may be a single line, but it has a slightly greater impact than the alternative two line solution. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!