Re: [RFC bpf-next 10/16] bpf: Add BPF_TRAMPOLINE_BATCH_DETACH support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4263 bytes --]

Hi Jiri,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Jiri-Olsa/bpf-Speed-up-trampoline-attach/20201022-162338
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-r002-20201022 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ee6abef5323d59b983129bf3514ef6775d1d6cd5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/df2d07719c4fd2fa52f40906d5d156e0ffe072f0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jiri-Olsa/bpf-Speed-up-trampoline-attach/20201022-162338
        git checkout df2d07719c4fd2fa52f40906d5d156e0ffe072f0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/bpf/syscall.c:2508:28: error: too many arguments to function call, expected 2, have 3
                                                   tr_link->trampoline, NULL));
                                                                        ^~~~
   include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
   #define NULL ((void *)0)
                ^~~~~~~~~~~
   include/asm-generic/bug.h:102:25: note: expanded from macro 'WARN_ON_ONCE'
           int __ret_warn_on = !!(condition);                      \
                                  ^~~~~~~~~
   include/linux/bpf.h:712:19: note: 'bpf_trampoline_unlink_prog' declared here
   static inline int bpf_trampoline_unlink_prog(struct bpf_prog *prog,
                     ^
   kernel/bpf/syscall.c:2919:10: error: implicit declaration of function 'bpf_trampoline_batch_alloc' [-Werror,-Wimplicit-function-declaration]
           batch = bpf_trampoline_batch_alloc(count);
                   ^
   kernel/bpf/syscall.c:2919:10: note: did you mean 'bpf_trampoline_batch'?
   kernel/bpf/syscall.c:2885:12: note: 'bpf_trampoline_batch' declared here
   static int bpf_trampoline_batch(const union bpf_attr *attr, int cmd)
              ^
   kernel/bpf/syscall.c:2919:8: warning: incompatible integer to pointer conversion assigning to 'struct bpf_trampoline_batch *' from 'int' [-Wint-conversion]
           batch = bpf_trampoline_batch_alloc(count);
                 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2960:64: error: too many arguments to function call, expected 2, have 3
                           bpf_trampoline_unlink_prog(link->prog, tr_link->trampoline, batch);
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~                                  ^~~~~
   include/linux/bpf.h:712:19: note: 'bpf_trampoline_unlink_prog' declared here
   static inline int bpf_trampoline_unlink_prog(struct bpf_prog *prog,
                     ^
   kernel/bpf/syscall.c:2975:2: error: implicit declaration of function 'bpf_trampoline_batch_free' [-Werror,-Wimplicit-function-declaration]
           bpf_trampoline_batch_free(batch);
           ^
   1 warning and 4 errors generated.

vim +2508 kernel/bpf/syscall.c

  2501	
  2502	static void bpf_tracing_link_release(struct bpf_link *link)
  2503	{
  2504		struct bpf_tracing_link *tr_link =
  2505			container_of(link, struct bpf_tracing_link, link);
  2506	
  2507		WARN_ON_ONCE(bpf_trampoline_unlink_prog(link->prog,
> 2508							tr_link->trampoline, NULL));
  2509	
  2510		bpf_trampoline_put(tr_link->trampoline);
  2511	
  2512		/* tgt_prog is NULL if target is a kernel function */
  2513		if (tr_link->tgt_prog)
  2514			bpf_prog_put(tr_link->tgt_prog);
  2515	}
  2516	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35931 bytes --]