Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip RPS tests on Ironlake (only IPS)

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Oct 22, 2020 at 10:08:14PM +0100, Chris Wilson wrote:
> Since Ironlake uses intel_ips.ko for its dynamic frequency adjustment,
> we do not have direct control over the frequency management so such
> tests are defunct.

We could just ignore what ips is saying, but maybe we don't want to.

> Similarly, we can't check the gen6+ RPS registers on
> Ironlake.

I can definitely get behind that one.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Hopefully this catches all the invalid tests now that Ironlake has
> rejoined the dynamic GPU frequency club.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gt/selftest_rps.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index 3540ba9bd459..aa5675ecb5cc 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -219,7 +219,7 @@ int live_rps_clock_interval(void *arg)
>  	struct igt_spinner spin;
>  	int err = 0;
>  
> -	if (!intel_rps_is_enabled(rps))
> +	if (!intel_rps_is_enabled(rps) || INTEL_GEN(gt->i915) < 6)
>  		return 0;
>  
>  	if (igt_spinner_init(&spin, gt))
> @@ -1028,7 +1028,7 @@ int live_rps_interrupt(void *arg)
>  	 * First, let's check whether or not we are receiving interrupts.
>  	 */
>  
> -	if (!intel_rps_has_interrupts(rps))
> +	if (!intel_rps_has_interrupts(rps) || INTEL_GEN(gt->i915) < 6)
>  		return 0;
>  
>  	intel_gt_pm_get(gt);
> @@ -1133,7 +1133,7 @@ int live_rps_power(void *arg)
>  	 * that theory.
>  	 */
>  
> -	if (!intel_rps_is_enabled(rps))
> +	if (!intel_rps_is_enabled(rps) || INTEL_GEN(gt->i915) < 6)
>  		return 0;
>  
>  	if (!librapl_energy_uJ())
> @@ -1237,7 +1237,7 @@ int live_rps_dynamic(void *arg)
>  	 * moving parts into dynamic reclocking based on load.
>  	 */
>  
> -	if (!intel_rps_is_enabled(rps))
> +	if (!intel_rps_is_enabled(rps) || INTEL_GEN(gt->i915) < 6)
>  		return 0;
>  
>  	if (igt_spinner_init(&spin, gt))
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx