All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emily Shaffer <emilyshaffer@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] MyFirstContribution: clarify asciidoc dependency
Date: Thu, 22 Oct 2020 16:14:05 -0700	[thread overview]
Message-ID: <20201022231405.GF2774782@google.com> (raw)
In-Reply-To: <xmqq362dait4.fsf@gitster.c.googlers.com>

On Fri, Oct 16, 2020 at 03:48:39PM -0700, Junio C Hamano wrote:
> 
> Taylor Blau <me@ttaylorr.com> writes:
> 
> > On Fri, Oct 16, 2020 at 02:21:53PM -0700, Junio C Hamano wrote:
> >> As this is only moving the existing note around in the
> >> documentation, it is not making things any worse, so I am OK to take
> >> the patch as-is, but if somebody (it is fine if it were done by you,
> >> Emily) can double check "apt-get install asciidoc" on a vanilla box
> >> does bring in what we need, that would be quite good.  FWIW, we
> >> write in our top-level INSTALL file that we require asciidox/xmlto
> >> toolchain (the latter is needed if you format for manpage, i.e. if
> >> you do "git subcmd --help").
> >
> > I was curious myself, and surprised to learn that 'apt-get install
> > asciidoc' installs more than 2GB of dependencies. Yikes. Unsurprisingly,
> > somewhere in those 2GB we manage to fit in everything that seems to
> > matter, since:
> >
> >   $ cat /etc/os-release | grep PRETTY
> >   PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
> >   $ apt-get update && apt-get install asciidoc
> >   $ cd copy-of-git
> >   $ make -C doc
> >
> > ...works just fine.
> 
> OK, that makes me feel even better.

Thanks for checking it, Taylor.
 - Emily

  reply	other threads:[~2020-10-22 23:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 20:52 [PATCH 0/2] some small clarifying docfixes Emily Shaffer
2020-10-16 20:52 ` [PATCH 1/2] MyFirstContribution: clarify asciidoc dependency Emily Shaffer
2020-10-16 21:21   ` Junio C Hamano
2020-10-16 21:52     ` Taylor Blau
2020-10-16 22:48       ` Junio C Hamano
2020-10-22 23:14         ` Emily Shaffer [this message]
2020-10-16 20:52 ` [PATCH 2/2] docs: demonstrate difference between 'am' and 'apply' Emily Shaffer
2020-10-16 21:13   ` Jeff King
2020-10-16 22:04     ` Junio C Hamano
2020-10-16 21:53   ` Junio C Hamano
2020-10-16 21:59     ` Junio C Hamano
2020-10-16 22:12     ` Junio C Hamano
2020-10-22 23:13     ` Emily Shaffer
2020-10-23  3:57       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201022231405.GF2774782@google.com \
    --to=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.