From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25418C388F9 for ; Fri, 23 Oct 2020 11:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B728221F9 for ; Fri, 23 Oct 2020 11:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cJLW7KXh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S463142AbgJWLnz (ORCPT ); Fri, 23 Oct 2020 07:43:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S463125AbgJWLny (ORCPT ); Fri, 23 Oct 2020 07:43:54 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21495C0613CE for ; Fri, 23 Oct 2020 04:43:54 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id t25so1907243ejd.13 for ; Fri, 23 Oct 2020 04:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=w1hT410pcvPp1e/jISfMDxaGMiE6qEWo/7L0amMfRgU=; b=cJLW7KXhZrozobsjIxLY2+buIwLvxqKyr27AnZ7HYQWa0uUdukWbasKJ2czJU24TAv +xOQlWLO6+S1xUJvXWypAbTgXaMAaueeDEY79s+fzRprkFavmAc4GWPNEArbGHty9Gen X9E+dVy9ofbqsgurh6cROggxU5YEL5D66l3f384zkftR4EosrgAMXRSRkMByyTKWVveo biP2CbDeOAiFRBbE/JyiUlPoN3H+aGVTUr5eNfYhM/yyLuc32ibRrp/B5bQyt08h6B4O hCYerAR9pgUKtxCUaLnWYi4cGUe26zmp9KDA1qKweDdurQd8Oe3cqfTdLeoeKCXXyOJv G7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=w1hT410pcvPp1e/jISfMDxaGMiE6qEWo/7L0amMfRgU=; b=opzqC+lZqQXvihYdpP4mi+RmK+7Y8KWa02G3Du0Ulgkl1sn3EUvbLm9qE5d5M7k6k+ JKQ8E4FdI96oBRdsovVQ80/i9Z2bXyYyRkj5GU/xfCpSwiHRXjqJ2pX3k1IDeQJ0Xc1V vH0r+KBgVszBB/pOHccLMZrwjC2kB0FZx6/fjdRsz3aY7ea/nY3ouqqSgK8G1wVtlrjI T7FNK82DM/fSiQylzCsjZARQMzpWYfETJ2uSbRqasd+Y7NfIaqrRc3/oFqPa+dCVZGIg KSB1TUP6J3x/+ek7SSHnnrZnOR0GZO2Z+W1nDqZRkNQOd1+fmC/ZsR5ucu7EEd8aBFpF UwEQ== X-Gm-Message-State: AOAM532cS7h8vCFpQp6TnOYLYFKIbiz+dGyhK196EoE9j10xtTCGBKtB yQI6WoZt2KyRoCy0e8SQFeUgwA== X-Google-Smtp-Source: ABdhPJwVjOkSax5nJV5uOP3pmNaE8Fo5w1uLm4eJe7FAqS8w5MKoOR0dfzix1SVIRw2yiVXX9NDP/Q== X-Received: by 2002:a17:906:66d2:: with SMTP id k18mr1469410ejp.113.1603453432716; Fri, 23 Oct 2020 04:43:52 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id sb29sm678261ejb.76.2020.10.23.04.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 04:43:52 -0700 (PDT) Date: Fri, 23 Oct 2020 13:43:32 +0200 From: Jean-Philippe Brucker To: Jacob Pan Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , Alex Williamson , Lu Baolu , David Woodhouse , Jonathan Corbet , linux-api@vger.kernel.org, Jean-Philippe Brucker , Eric Auger , Jacob Pan , Yi Liu , "Tian, Kevin" , Raj Ashok , Wu Hao , Yi Sun , Dave Jiang , Randy Dunlap Subject: Re: [PATCH v3 11/14] iommu/ioasid: Support mm type ioasid_set notifications Message-ID: <20201023114332.GD2265982@myrica> References: <1601329121-36979-1-git-send-email-jacob.jun.pan@linux.intel.com> <1601329121-36979-12-git-send-email-jacob.jun.pan@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1601329121-36979-12-git-send-email-jacob.jun.pan@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Sep 28, 2020 at 02:38:38PM -0700, Jacob Pan wrote: > As a system-wide resource, IOASID is often shared by multiple kernel > subsystems that are independent of each other. However, at the > ioasid_set level, these kernel subsystems must communicate with each > other for ownership checking, event notifications, etc. For example, on > Intel Scalable IO Virtualization (SIOV) enabled platforms, KVM and VFIO > instances under the same process/guest must be aware of a shared IOASID > set. > IOASID_SET_TYPE_MM token type was introduced to explicitly mark an > IOASID set that belongs to a process, thus use the same mm_struct > pointer as a token. Users of the same process can then identify with > each other based on this token. > > This patch introduces MM token specific event registration APIs. Event > subscribers such as KVM instances can register IOASID event handler > without the knowledge of its ioasid_set. Event handlers are registered > based on its mm_struct pointer as a token. In case when subscribers > register handler *prior* to the creation of the ioasid_set, the > handler’s notification block is stored in a pending list within IOASID > core. Once the ioasid_set of the MM token is created, the notification > block will be registered by the IOASID core. > > Signed-off-by: Liu Yi L > Signed-off-by: Wu Hao > Signed-off-by: Jacob Pan > --- > drivers/iommu/ioasid.c | 117 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/ioasid.h | 15 +++++++ > 2 files changed, 132 insertions(+) > > diff --git a/drivers/iommu/ioasid.c b/drivers/iommu/ioasid.c > index 894b17c06ead..d5faeb559a43 100644 > --- a/drivers/iommu/ioasid.c > +++ b/drivers/iommu/ioasid.c > @@ -889,6 +889,29 @@ void ioasid_set_put(struct ioasid_set *set) > } > EXPORT_SYMBOL_GPL(ioasid_set_put); > > +/* > + * ioasid_find_mm_set - Retrieve IOASID set with mm token > + * Take a reference of the set if found. > + */ > +static struct ioasid_set *ioasid_find_mm_set(struct mm_struct *token) > +{ > + struct ioasid_set *set; > + unsigned long index; > + > + spin_lock(&ioasid_allocator_lock); This could deadlock since ioasid_set_put() takes the nb_lock while holding the allocator_lock. > + > + xa_for_each(&ioasid_sets, index, set) { > + if (set->type == IOASID_SET_TYPE_MM && set->token == token) { > + refcount_inc(&set->ref); > + goto exit_unlock; > + } > + } > + set = NULL; > +exit_unlock: > + spin_unlock(&ioasid_allocator_lock); > + return set; > +} > + > /** > * ioasid_adjust_set - Adjust the quota of an IOASID set > * @set: IOASID set to be assigned > @@ -1121,6 +1144,100 @@ void ioasid_unregister_notifier(struct ioasid_set *set, > } > EXPORT_SYMBOL_GPL(ioasid_unregister_notifier); > > +/** > + * ioasid_register_notifier_mm - Register a notifier block on the IOASID set > + * created by the mm_struct pointer as the token > + * > + * @mm: the mm_struct token of the ioasid_set > + * @nb: notfier block to be registered on the ioasid_set Maybe add that the priority in @nb needs to be set by the caller using a ioasid_notifier_priority value > + * > + * This a variant of ioasid_register_notifier() where the caller intends to > + * listen to IOASID events belong the ioasid_set created under the same that belong to > + * process. Caller is not aware of the ioasid_set, no need to hold reference > + * of the ioasid_set. > + */ > +int ioasid_register_notifier_mm(struct mm_struct *mm, struct notifier_block *nb) > +{ > + struct ioasid_set_nb *curr; > + struct ioasid_set *set; > + int ret = 0; > + > + if (!mm) > + return -EINVAL; > + > + spin_lock(&ioasid_nb_lock); > + > + /* Check for duplicates, nb is unique per set */ > + list_for_each_entry(curr, &ioasid_nb_pending_list, list) { > + if (curr->token == mm && curr->nb == nb) { > + ret = -EBUSY; > + goto exit_unlock; > + } > + } > + > + /* Check if the token has an existing set */ > + set = ioasid_find_mm_set(mm); > + if (!set) { > + /* Add to the rsvd list as inactive */ > + curr->active = false; curr is invalid here > + } else { > + /* REVISIT: Only register empty set for now. Can add an option > + * in the future to playback existing PASIDs. > + */ You can drop this comment > + if (set->nr_ioasids) { > + pr_warn("IOASID set %d not empty\n", set->id); > + ret = -EBUSY; > + goto exit_unlock; > + } > + curr = kzalloc(sizeof(*curr), GFP_ATOMIC); Needs to be in the common path, before this block > + if (!curr) { > + ret = -ENOMEM; > + goto exit_unlock; > + } > + curr->token = mm; > + curr->nb = nb; > + curr->active = true; > + curr->set = set; > + > + /* Set already created, add to the notifier chain */ > + atomic_notifier_chain_register(&set->nh, nb); > + /* > + * Do not hold a reference, if the set gets destroyed, the nb > + * entry will be marked inactive. > + */ > + ioasid_set_put(set); > + } > + > + list_add(&curr->list, &ioasid_nb_pending_list); > + > +exit_unlock: > + spin_unlock(&ioasid_nb_lock); > + return ret; > +} > +EXPORT_SYMBOL_GPL(ioasid_register_notifier_mm); > + > +void ioasid_unregister_notifier_mm(struct mm_struct *mm, struct notifier_block *nb) > +{ > + struct ioasid_set_nb *curr; > + > + spin_lock(&ioasid_nb_lock); > + list_for_each_entry(curr, &ioasid_nb_pending_list, list) { > + if (curr->token == mm && curr->nb == nb) { > + list_del(&curr->list); > + spin_unlock(&ioasid_nb_lock); > + if (curr->active) { > + atomic_notifier_chain_unregister(&curr->set->nh, > + nb); I think it's possible for ioasid_set_put_locked() to free the set right after we release the lock, then this unregister() will be use-after-free. Best keep holding the lock for this. > + } > + kfree(curr); > + return; > + } > + } > + pr_warn("No ioasid set found for mm token %llx\n", (u64)mm); Use %p Overall I think error messages in this series could be demoted to pr_debug, since they're useful when developing users to this API, but figuring out whether they can be user-triggered and need care is too much work. Thanks, Jean > + spin_unlock(&ioasid_nb_lock); > +} > +EXPORT_SYMBOL_GPL(ioasid_unregister_notifier_mm); > + > MODULE_AUTHOR("Jean-Philippe Brucker "); > MODULE_AUTHOR("Jacob Pan "); > MODULE_DESCRIPTION("IO Address Space ID (IOASID) allocator"); > diff --git a/include/linux/ioasid.h b/include/linux/ioasid.h > index 1b551c99d568..c6cc855aadb6 100644 > --- a/include/linux/ioasid.h > +++ b/include/linux/ioasid.h > @@ -132,6 +132,9 @@ void ioasid_unregister_notifier(struct ioasid_set *set, > void ioasid_set_for_each_ioasid(struct ioasid_set *sdata, > void (*fn)(ioasid_t id, void *data), > void *data); > +int ioasid_register_notifier_mm(struct mm_struct *mm, struct notifier_block *nb); > +void ioasid_unregister_notifier_mm(struct mm_struct *mm, struct notifier_block *nb); > + > #else /* !CONFIG_IOASID */ > static inline void ioasid_install_capacity(ioasid_t total) > { > @@ -238,5 +241,17 @@ static inline void ioasid_set_for_each_ioasid(struct ioasid_set *sdata, > void *data) > { > } > + > +static inline int ioasid_register_notifier_mm(struct mm_struct *mm, > + struct notifier_block *nb) > +{ > + return -ENOTSUPP; > +} > + > +static inline void ioasid_unregister_notifier_mm(struct mm_struct *mm, > + struct notifier_block *nb) > +{ > +} > + > #endif /* CONFIG_IOASID */ > #endif /* __LINUX_IOASID_H */ > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C56B4C56201 for ; Fri, 23 Oct 2020 11:43:59 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A9C72225F for ; Fri, 23 Oct 2020 11:43:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cJLW7KXh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A9C72225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B9B2487855; Fri, 23 Oct 2020 11:43:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 36a-3oq4gVTj; Fri, 23 Oct 2020 11:43:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id E684F87854; Fri, 23 Oct 2020 11:43:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CBDC1C088B; Fri, 23 Oct 2020 11:43:57 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1476FC0051 for ; Fri, 23 Oct 2020 11:43:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0F6D386842 for ; Fri, 23 Oct 2020 11:43:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RgGF4mwtT7aJ for ; Fri, 23 Oct 2020 11:43:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id 83BBE86767 for ; Fri, 23 Oct 2020 11:43:54 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id p9so1953756eji.4 for ; Fri, 23 Oct 2020 04:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=w1hT410pcvPp1e/jISfMDxaGMiE6qEWo/7L0amMfRgU=; b=cJLW7KXhZrozobsjIxLY2+buIwLvxqKyr27AnZ7HYQWa0uUdukWbasKJ2czJU24TAv +xOQlWLO6+S1xUJvXWypAbTgXaMAaueeDEY79s+fzRprkFavmAc4GWPNEArbGHty9Gen X9E+dVy9ofbqsgurh6cROggxU5YEL5D66l3f384zkftR4EosrgAMXRSRkMByyTKWVveo biP2CbDeOAiFRBbE/JyiUlPoN3H+aGVTUr5eNfYhM/yyLuc32ibRrp/B5bQyt08h6B4O hCYerAR9pgUKtxCUaLnWYi4cGUe26zmp9KDA1qKweDdurQd8Oe3cqfTdLeoeKCXXyOJv G7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=w1hT410pcvPp1e/jISfMDxaGMiE6qEWo/7L0amMfRgU=; b=uX+zCDtRN224QnSUZLdaA9myt2odPg38qE6kngVGY8Isjr830FP3sEc8mfE57abwAZ L31ilKq8eYiGsy7QadNl3XA9eN/cWsmPnaEez427x7i6go+pexzd4wWhcUUlQuRZxCbM OOQtcxs8lB0sp+6F3rzmQO8nwF+JrL5MGCppIbGR3BdCLh82X/Se1foPcoIqiQ8/V+Df SVrqzwo9n56oPw3pcx7uK6Ke72ZylqRiBx/NsFJUIKogAKuN7QSSdnEWneD+pa9g9P/F 7HHFvXpZHHVg1j0GqMnnwDgF242Gmy6ORZghPw92PUttcZ3FtsnUc4DGZclMEyHpv1MG ASmw== X-Gm-Message-State: AOAM530NFoyd3EKW2d+fWfO7Ay48srSy9E21Xs9y9T9bYGiKEYF20jTk 9MsOswZy3zRZS3GSz3sgpuBtTw== X-Google-Smtp-Source: ABdhPJwVjOkSax5nJV5uOP3pmNaE8Fo5w1uLm4eJe7FAqS8w5MKoOR0dfzix1SVIRw2yiVXX9NDP/Q== X-Received: by 2002:a17:906:66d2:: with SMTP id k18mr1469410ejp.113.1603453432716; Fri, 23 Oct 2020 04:43:52 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id sb29sm678261ejb.76.2020.10.23.04.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 04:43:52 -0700 (PDT) Date: Fri, 23 Oct 2020 13:43:32 +0200 From: Jean-Philippe Brucker To: Jacob Pan Subject: Re: [PATCH v3 11/14] iommu/ioasid: Support mm type ioasid_set notifications Message-ID: <20201023114332.GD2265982@myrica> References: <1601329121-36979-1-git-send-email-jacob.jun.pan@linux.intel.com> <1601329121-36979-12-git-send-email-jacob.jun.pan@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1601329121-36979-12-git-send-email-jacob.jun.pan@linux.intel.com> Cc: "Tian, Kevin" , Dave Jiang , Raj Ashok , Jonathan Corbet , linux-api@vger.kernel.org, Randy Dunlap , Alex Williamson , LKML , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, Wu Hao , David Woodhouse , Yi Sun X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gTW9uLCBTZXAgMjgsIDIwMjAgYXQgMDI6Mzg6MzhQTSAtMDcwMCwgSmFjb2IgUGFuIHdyb3Rl Ogo+IEFzIGEgc3lzdGVtLXdpZGUgcmVzb3VyY2UsIElPQVNJRCBpcyBvZnRlbiBzaGFyZWQgYnkg bXVsdGlwbGUga2VybmVsCj4gc3Vic3lzdGVtcyB0aGF0IGFyZSBpbmRlcGVuZGVudCBvZiBlYWNo IG90aGVyLiBIb3dldmVyLCBhdCB0aGUKPiBpb2FzaWRfc2V0IGxldmVsLCB0aGVzZSBrZXJuZWwg c3Vic3lzdGVtcyBtdXN0IGNvbW11bmljYXRlIHdpdGggZWFjaAo+IG90aGVyIGZvciBvd25lcnNo aXAgY2hlY2tpbmcsIGV2ZW50IG5vdGlmaWNhdGlvbnMsIGV0Yy4gRm9yIGV4YW1wbGUsIG9uCj4g SW50ZWwgU2NhbGFibGUgSU8gVmlydHVhbGl6YXRpb24gKFNJT1YpIGVuYWJsZWQgcGxhdGZvcm1z LCBLVk0gYW5kIFZGSU8KPiBpbnN0YW5jZXMgdW5kZXIgdGhlIHNhbWUgcHJvY2Vzcy9ndWVzdCBt dXN0IGJlIGF3YXJlIG9mIGEgc2hhcmVkIElPQVNJRAo+IHNldC4KPiBJT0FTSURfU0VUX1RZUEVf TU0gdG9rZW4gdHlwZSB3YXMgaW50cm9kdWNlZCB0byBleHBsaWNpdGx5IG1hcmsgYW4KPiBJT0FT SUQgc2V0IHRoYXQgYmVsb25ncyB0byBhIHByb2Nlc3MsIHRodXMgdXNlIHRoZSBzYW1lIG1tX3N0 cnVjdAo+IHBvaW50ZXIgYXMgYSB0b2tlbi4gVXNlcnMgb2YgdGhlIHNhbWUgcHJvY2VzcyBjYW4g dGhlbiBpZGVudGlmeSB3aXRoCj4gZWFjaCBvdGhlciBiYXNlZCBvbiB0aGlzIHRva2VuLgo+IAo+ IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBNTSB0b2tlbiBzcGVjaWZpYyBldmVudCByZWdpc3RyYXRp b24gQVBJcy4gRXZlbnQKPiBzdWJzY3JpYmVycyBzdWNoIGFzIEtWTSBpbnN0YW5jZXMgY2FuIHJl Z2lzdGVyIElPQVNJRCBldmVudCBoYW5kbGVyCj4gd2l0aG91dCB0aGUga25vd2xlZGdlIG9mIGl0 cyBpb2FzaWRfc2V0LiBFdmVudCBoYW5kbGVycyBhcmUgcmVnaXN0ZXJlZAo+IGJhc2VkIG9uIGl0 cyBtbV9zdHJ1Y3QgcG9pbnRlciBhcyBhIHRva2VuLiBJbiBjYXNlIHdoZW4gc3Vic2NyaWJlcnMK PiByZWdpc3RlciBoYW5kbGVyICpwcmlvciogdG8gdGhlIGNyZWF0aW9uIG9mIHRoZSBpb2FzaWRf c2V0LCB0aGUKPiBoYW5kbGVy4oCZcyBub3RpZmljYXRpb24gYmxvY2sgaXMgc3RvcmVkIGluIGEg cGVuZGluZyBsaXN0IHdpdGhpbiBJT0FTSUQKPiBjb3JlLiBPbmNlIHRoZSBpb2FzaWRfc2V0IG9m IHRoZSBNTSB0b2tlbiBpcyBjcmVhdGVkLCB0aGUgbm90aWZpY2F0aW9uCj4gYmxvY2sgd2lsbCBi ZSByZWdpc3RlcmVkIGJ5IHRoZSBJT0FTSUQgY29yZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMaXUg WWkgTCA8eWkubC5saXVAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFd1IEhhbyA8aGFvLnd1 QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKYWNvYiBQYW4gPGphY29iLmp1bi5wYW5AbGlu dXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2lvbW11L2lvYXNpZC5jIHwgMTE3ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9s aW51eC9pb2FzaWQuaCB8ICAxNSArKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTMyIGluc2Vy dGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9pb2FzaWQuYyBiL2RyaXZl cnMvaW9tbXUvaW9hc2lkLmMKPiBpbmRleCA4OTRiMTdjMDZlYWQuLmQ1ZmFlYjU1OWE0MyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2lvbW11L2lvYXNpZC5jCj4gKysrIGIvZHJpdmVycy9pb21tdS9p b2FzaWQuYwo+IEBAIC04ODksNiArODg5LDI5IEBAIHZvaWQgaW9hc2lkX3NldF9wdXQoc3RydWN0 IGlvYXNpZF9zZXQgKnNldCkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MX0dQTChpb2FzaWRfc2V0X3B1 dCk7Cj4gIAo+ICsvKgo+ICsgKiBpb2FzaWRfZmluZF9tbV9zZXQgLSBSZXRyaWV2ZSBJT0FTSUQg c2V0IHdpdGggbW0gdG9rZW4KPiArICogVGFrZSBhIHJlZmVyZW5jZSBvZiB0aGUgc2V0IGlmIGZv dW5kLgo+ICsgKi8KPiArc3RhdGljIHN0cnVjdCBpb2FzaWRfc2V0ICppb2FzaWRfZmluZF9tbV9z ZXQoc3RydWN0IG1tX3N0cnVjdCAqdG9rZW4pCj4gK3sKPiArCXN0cnVjdCBpb2FzaWRfc2V0ICpz ZXQ7Cj4gKwl1bnNpZ25lZCBsb25nIGluZGV4Owo+ICsKPiArCXNwaW5fbG9jaygmaW9hc2lkX2Fs bG9jYXRvcl9sb2NrKTsKClRoaXMgY291bGQgZGVhZGxvY2sgc2luY2UgaW9hc2lkX3NldF9wdXQo KSB0YWtlcyB0aGUgbmJfbG9jayB3aGlsZSBob2xkaW5nCnRoZSBhbGxvY2F0b3JfbG9jay4KCj4g Kwo+ICsJeGFfZm9yX2VhY2goJmlvYXNpZF9zZXRzLCBpbmRleCwgc2V0KSB7Cj4gKwkJaWYgKHNl dC0+dHlwZSA9PSBJT0FTSURfU0VUX1RZUEVfTU0gJiYgc2V0LT50b2tlbiA9PSB0b2tlbikgewo+ ICsJCQlyZWZjb3VudF9pbmMoJnNldC0+cmVmKTsKPiArCQkJZ290byBleGl0X3VubG9jazsKPiAr CQl9Cj4gKwl9Cj4gKwlzZXQgPSBOVUxMOwo+ICtleGl0X3VubG9jazoKPiArCXNwaW5fdW5sb2Nr KCZpb2FzaWRfYWxsb2NhdG9yX2xvY2spOwo+ICsJcmV0dXJuIHNldDsKPiArfQo+ICsKPiAgLyoq Cj4gICAqIGlvYXNpZF9hZGp1c3Rfc2V0IC0gQWRqdXN0IHRoZSBxdW90YSBvZiBhbiBJT0FTSUQg c2V0Cj4gICAqIEBzZXQ6CUlPQVNJRCBzZXQgdG8gYmUgYXNzaWduZWQKPiBAQCAtMTEyMSw2ICsx MTQ0LDEwMCBAQCB2b2lkIGlvYXNpZF91bnJlZ2lzdGVyX25vdGlmaWVyKHN0cnVjdCBpb2FzaWRf c2V0ICpzZXQsCj4gIH0KPiAgRVhQT1JUX1NZTUJPTF9HUEwoaW9hc2lkX3VucmVnaXN0ZXJfbm90 aWZpZXIpOwo+ICAKPiArLyoqCj4gKyAqIGlvYXNpZF9yZWdpc3Rlcl9ub3RpZmllcl9tbSAtIFJl Z2lzdGVyIGEgbm90aWZpZXIgYmxvY2sgb24gdGhlIElPQVNJRCBzZXQKPiArICogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY3JlYXRlZCBieSB0aGUgbW1fc3RydWN0IHBvaW50ZXIgYXMg dGhlIHRva2VuCj4gKyAqCj4gKyAqIEBtbTogdGhlIG1tX3N0cnVjdCB0b2tlbiBvZiB0aGUgaW9h c2lkX3NldAo+ICsgKiBAbmI6IG5vdGZpZXIgYmxvY2sgdG8gYmUgcmVnaXN0ZXJlZCBvbiB0aGUg aW9hc2lkX3NldAoKTWF5YmUgYWRkIHRoYXQgdGhlIHByaW9yaXR5IGluIEBuYiBuZWVkcyB0byBi ZSBzZXQgYnkgdGhlIGNhbGxlciB1c2luZyBhCmlvYXNpZF9ub3RpZmllcl9wcmlvcml0eSB2YWx1 ZQoKPiArICoKPiArICogVGhpcyBhIHZhcmlhbnQgb2YgaW9hc2lkX3JlZ2lzdGVyX25vdGlmaWVy KCkgd2hlcmUgdGhlIGNhbGxlciBpbnRlbmRzIHRvCj4gKyAqIGxpc3RlbiB0byBJT0FTSUQgZXZl bnRzIGJlbG9uZyB0aGUgaW9hc2lkX3NldCBjcmVhdGVkIHVuZGVyIHRoZSBzYW1lCgogICAgICAg ICAgICAgICAgICAgICAgICAgdGhhdCBiZWxvbmcgdG8KCj4gKyAqIHByb2Nlc3MuIENhbGxlciBp cyBub3QgYXdhcmUgb2YgdGhlIGlvYXNpZF9zZXQsIG5vIG5lZWQgdG8gaG9sZCByZWZlcmVuY2UK PiArICogb2YgdGhlIGlvYXNpZF9zZXQuCj4gKyAqLwo+ICtpbnQgaW9hc2lkX3JlZ2lzdGVyX25v dGlmaWVyX21tKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLCBzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sgKm5i KQo+ICt7Cj4gKwlzdHJ1Y3QgaW9hc2lkX3NldF9uYiAqY3VycjsKPiArCXN0cnVjdCBpb2FzaWRf c2V0ICpzZXQ7Cj4gKwlpbnQgcmV0ID0gMDsKPiArCj4gKwlpZiAoIW1tKQo+ICsJCXJldHVybiAt RUlOVkFMOwo+ICsKPiArCXNwaW5fbG9jaygmaW9hc2lkX25iX2xvY2spOwo+ICsKPiArCS8qIENo ZWNrIGZvciBkdXBsaWNhdGVzLCBuYiBpcyB1bmlxdWUgcGVyIHNldCAqLwo+ICsJbGlzdF9mb3Jf ZWFjaF9lbnRyeShjdXJyLCAmaW9hc2lkX25iX3BlbmRpbmdfbGlzdCwgbGlzdCkgewo+ICsJCWlm IChjdXJyLT50b2tlbiA9PSBtbSAmJiBjdXJyLT5uYiA9PSBuYikgewo+ICsJCQlyZXQgPSAtRUJV U1k7Cj4gKwkJCWdvdG8gZXhpdF91bmxvY2s7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCS8qIENoZWNr IGlmIHRoZSB0b2tlbiBoYXMgYW4gZXhpc3Rpbmcgc2V0ICovCj4gKwlzZXQgPSBpb2FzaWRfZmlu ZF9tbV9zZXQobW0pOwo+ICsJaWYgKCFzZXQpIHsKPiArCQkvKiBBZGQgdG8gdGhlIHJzdmQgbGlz dCBhcyBpbmFjdGl2ZSAqLwo+ICsJCWN1cnItPmFjdGl2ZSA9IGZhbHNlOwoKY3VyciBpcyBpbnZh bGlkIGhlcmUKCj4gKwl9IGVsc2Ugewo+ICsJCS8qIFJFVklTSVQ6IE9ubHkgcmVnaXN0ZXIgZW1w dHkgc2V0IGZvciBub3cuIENhbiBhZGQgYW4gb3B0aW9uCj4gKwkJICogaW4gdGhlIGZ1dHVyZSB0 byBwbGF5YmFjayBleGlzdGluZyBQQVNJRHMuCj4gKwkJICovCgpZb3UgY2FuIGRyb3AgdGhpcyBj b21tZW50Cgo+ICsJCWlmIChzZXQtPm5yX2lvYXNpZHMpIHsKPiArCQkJcHJfd2FybigiSU9BU0lE IHNldCAlZCBub3QgZW1wdHlcbiIsIHNldC0+aWQpOwo+ICsJCQlyZXQgPSAtRUJVU1k7Cj4gKwkJ CWdvdG8gZXhpdF91bmxvY2s7Cj4gKwkJfQo+ICsJCWN1cnIgPSBremFsbG9jKHNpemVvZigqY3Vy ciksIEdGUF9BVE9NSUMpOwoKTmVlZHMgdG8gYmUgaW4gdGhlIGNvbW1vbiBwYXRoLCBiZWZvcmUg dGhpcyBibG9jawoKPiArCQlpZiAoIWN1cnIpIHsKPiArCQkJcmV0ID0gLUVOT01FTTsKPiArCQkJ Z290byBleGl0X3VubG9jazsKPiArCQl9Cj4gKwkJY3Vyci0+dG9rZW4gPSBtbTsKPiArCQljdXJy LT5uYiA9IG5iOwo+ICsJCWN1cnItPmFjdGl2ZSA9IHRydWU7Cj4gKwkJY3Vyci0+c2V0ID0gc2V0 Owo+ICsKPiArCQkvKiBTZXQgYWxyZWFkeSBjcmVhdGVkLCBhZGQgdG8gdGhlIG5vdGlmaWVyIGNo YWluICovCj4gKwkJYXRvbWljX25vdGlmaWVyX2NoYWluX3JlZ2lzdGVyKCZzZXQtPm5oLCBuYik7 Cj4gKwkJLyoKPiArCQkgKiBEbyBub3QgaG9sZCBhIHJlZmVyZW5jZSwgaWYgdGhlIHNldCBnZXRz IGRlc3Ryb3llZCwgdGhlIG5iCj4gKwkJICogZW50cnkgd2lsbCBiZSBtYXJrZWQgaW5hY3RpdmUu Cj4gKwkJICovCj4gKwkJaW9hc2lkX3NldF9wdXQoc2V0KTsKPiArCX0KPiArCj4gKwlsaXN0X2Fk ZCgmY3Vyci0+bGlzdCwgJmlvYXNpZF9uYl9wZW5kaW5nX2xpc3QpOwo+ICsKPiArZXhpdF91bmxv Y2s6Cj4gKwlzcGluX3VubG9jaygmaW9hc2lkX25iX2xvY2spOwo+ICsJcmV0dXJuIHJldDsKPiAr fQo+ICtFWFBPUlRfU1lNQk9MX0dQTChpb2FzaWRfcmVnaXN0ZXJfbm90aWZpZXJfbW0pOwo+ICsK PiArdm9pZCBpb2FzaWRfdW5yZWdpc3Rlcl9ub3RpZmllcl9tbShzdHJ1Y3QgbW1fc3RydWN0ICpt bSwgc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuYikKPiArewo+ICsJc3RydWN0IGlvYXNpZF9zZXRf bmIgKmN1cnI7Cj4gKwo+ICsJc3Bpbl9sb2NrKCZpb2FzaWRfbmJfbG9jayk7Cj4gKwlsaXN0X2Zv cl9lYWNoX2VudHJ5KGN1cnIsICZpb2FzaWRfbmJfcGVuZGluZ19saXN0LCBsaXN0KSB7Cj4gKwkJ aWYgKGN1cnItPnRva2VuID09IG1tICYmIGN1cnItPm5iID09IG5iKSB7Cj4gKwkJCWxpc3RfZGVs KCZjdXJyLT5saXN0KTsKPiArCQkJc3Bpbl91bmxvY2soJmlvYXNpZF9uYl9sb2NrKTsKPiArCQkJ aWYgKGN1cnItPmFjdGl2ZSkgewo+ICsJCQkJYXRvbWljX25vdGlmaWVyX2NoYWluX3VucmVnaXN0 ZXIoJmN1cnItPnNldC0+bmgsCj4gKwkJCQkJCQkJIG5iKTsKCkkgdGhpbmsgaXQncyBwb3NzaWJs ZSBmb3IgaW9hc2lkX3NldF9wdXRfbG9ja2VkKCkgdG8gZnJlZSB0aGUgc2V0IHJpZ2h0CmFmdGVy IHdlIHJlbGVhc2UgdGhlIGxvY2ssIHRoZW4gdGhpcyB1bnJlZ2lzdGVyKCkgd2lsbCBiZSB1c2Ut YWZ0ZXItZnJlZS4KQmVzdCBrZWVwIGhvbGRpbmcgdGhlIGxvY2sgZm9yIHRoaXMuCgo+ICsJCQl9 Cj4gKwkJCWtmcmVlKGN1cnIpOwo+ICsJCQlyZXR1cm47Cj4gKwkJfQo+ICsJfQo+ICsJcHJfd2Fy bigiTm8gaW9hc2lkIHNldCBmb3VuZCBmb3IgbW0gdG9rZW4gJWxseFxuIiwgICh1NjQpbW0pOwoK VXNlICVwCgpPdmVyYWxsIEkgdGhpbmsgZXJyb3IgbWVzc2FnZXMgaW4gdGhpcyBzZXJpZXMgY291 bGQgYmUgZGVtb3RlZCB0bwpwcl9kZWJ1Zywgc2luY2UgdGhleSdyZSB1c2VmdWwgd2hlbiBkZXZl bG9waW5nIHVzZXJzIHRvIHRoaXMgQVBJLCBidXQKZmlndXJpbmcgb3V0IHdoZXRoZXIgdGhleSBj YW4gYmUgdXNlci10cmlnZ2VyZWQgYW5kIG5lZWQgY2FyZSBpcyB0b28gbXVjaAp3b3JrLgoKVGhh bmtzLApKZWFuCgo+ICsJc3Bpbl91bmxvY2soJmlvYXNpZF9uYl9sb2NrKTsKPiArfQo+ICtFWFBP UlRfU1lNQk9MX0dQTChpb2FzaWRfdW5yZWdpc3Rlcl9ub3RpZmllcl9tbSk7Cj4gKwo+ICBNT0RV TEVfQVVUSE9SKCJKZWFuLVBoaWxpcHBlIEJydWNrZXIgPGplYW4tcGhpbGlwcGUuYnJ1Y2tlckBh cm0uY29tPiIpOwo+ICBNT0RVTEVfQVVUSE9SKCJKYWNvYiBQYW4gPGphY29iLmp1bi5wYW5AbGlu dXguaW50ZWwuY29tPiIpOwo+ICBNT0RVTEVfREVTQ1JJUFRJT04oIklPIEFkZHJlc3MgU3BhY2Ug SUQgKElPQVNJRCkgYWxsb2NhdG9yIik7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaW9h c2lkLmggYi9pbmNsdWRlL2xpbnV4L2lvYXNpZC5oCj4gaW5kZXggMWI1NTFjOTlkNTY4Li5jNmNj ODU1YWFkYjYgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9pb2FzaWQuaAo+ICsrKyBiL2lu Y2x1ZGUvbGludXgvaW9hc2lkLmgKPiBAQCAtMTMyLDYgKzEzMiw5IEBAIHZvaWQgaW9hc2lkX3Vu cmVnaXN0ZXJfbm90aWZpZXIoc3RydWN0IGlvYXNpZF9zZXQgKnNldCwKPiAgdm9pZCBpb2FzaWRf c2V0X2Zvcl9lYWNoX2lvYXNpZChzdHJ1Y3QgaW9hc2lkX3NldCAqc2RhdGEsCj4gIAkJCQl2b2lk ICgqZm4pKGlvYXNpZF90IGlkLCB2b2lkICpkYXRhKSwKPiAgCQkJCXZvaWQgKmRhdGEpOwo+ICtp bnQgaW9hc2lkX3JlZ2lzdGVyX25vdGlmaWVyX21tKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLCBzdHJ1 Y3Qgbm90aWZpZXJfYmxvY2sgKm5iKTsKPiArdm9pZCBpb2FzaWRfdW5yZWdpc3Rlcl9ub3RpZmll cl9tbShzdHJ1Y3QgbW1fc3RydWN0ICptbSwgc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuYik7Cj4g Kwo+ICAjZWxzZSAvKiAhQ09ORklHX0lPQVNJRCAqLwo+ICBzdGF0aWMgaW5saW5lIHZvaWQgaW9h c2lkX2luc3RhbGxfY2FwYWNpdHkoaW9hc2lkX3QgdG90YWwpCj4gIHsKPiBAQCAtMjM4LDUgKzI0 MSwxNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW9hc2lkX3NldF9mb3JfZWFjaF9pb2FzaWQoc3Ry dWN0IGlvYXNpZF9zZXQgKnNkYXRhLAo+ICAJCQkJCSAgICAgIHZvaWQgKmRhdGEpCj4gIHsKPiAg fQo+ICsKPiArc3RhdGljIGlubGluZSBpbnQgaW9hc2lkX3JlZ2lzdGVyX25vdGlmaWVyX21tKHN0 cnVjdCBtbV9zdHJ1Y3QgKm1tLAo+ICsJCQkJCSAgICAgIHN0cnVjdCBub3RpZmllcl9ibG9jayAq bmIpCj4gK3sKPiArCXJldHVybiAtRU5PVFNVUFA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxpbmUg dm9pZCBpb2FzaWRfdW5yZWdpc3Rlcl9ub3RpZmllcl9tbShzdHJ1Y3QgbW1fc3RydWN0ICptbSwK PiArCQkJCQkJIHN0cnVjdCBub3RpZmllcl9ibG9jayAqbmIpCj4gK3sKPiArfQo+ICsKPiAgI2Vu ZGlmIC8qIENPTkZJR19JT0FTSUQgKi8KPiAgI2VuZGlmIC8qIF9fTElOVVhfSU9BU0lEX0ggKi8K PiAtLSAKPiAyLjcuNAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9t bXU=