From: Oscar Salvador <osalvador@suse.de>
To: Laurent Cremmer <laurent@oss.volkswagen.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mina Almasry <almasrymina@google.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] hugetlb: fix locking in region_add,region_cgh,allocate_file_region_entries
Date: Fri, 23 Oct 2020 14:11:29 +0200 [thread overview]
Message-ID: <20201023121129.GB3925@linux> (raw)
In-Reply-To: <CAPHd0UAxtkV4sPobwvdvrmoGaaru3ib81-=o9-V0dV4h2sorvA@mail.gmail.com>
On Fri, Oct 23, 2020 at 01:32:54PM +0200, Laurent Cremmer wrote:
> I came to the same conclusion with the help of David's remarks :-) .
> And in the end, this patch would be more about fixing the readability
> of the code than fixing a live problem per-se. If it ain't broken,
> don't fix it as they say :-)
Yeah, definitely the code could benefit from a cleanup, so no one
has to stare at it for a while before he gets the idea.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2020-10-23 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 7:47 [PATCH] hugetlb: fix locking in region_add,region_cgh,allocate_file_region_entries Laurent Cremmer
2020-10-23 10:12 ` David Hildenbrand
2020-10-23 11:25 ` Laurent Cremmer
2020-10-23 11:39 ` David Hildenbrand
2020-10-23 11:02 ` Oscar Salvador
2020-10-23 11:32 ` Laurent Cremmer
2020-10-23 12:11 ` Oscar Salvador [this message]
2020-10-23 16:47 ` Mike Kravetz
2020-10-27 7:34 ` Laurent Cremmer
2020-10-28 19:18 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023121129.GB3925@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=laurent@oss.volkswagen.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rientjes@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.