From: Leif Lindholm <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: linux-efi@vger.kernel.org, grub-devel@gnu.org, daniel.kiper@oracle.com
Subject: Re: [PATCH 0/4] linux: implement LoadFile2 initrd loading
Date: Fri, 23 Oct 2020 13:50:55 +0100 [thread overview]
Message-ID: <20201023125055.GE1664@vanye> (raw)
In-Reply-To: <20201023120825.30466-1-ard.biesheuvel@arm.com>
On Fri, Oct 23, 2020 at 14:08:21 +0200, Ard Biesheuvel wrote:
> This implements the LoadFile2 initrd loading protocol, which is
> essentially a callback face into the bootloader to load the initrd
> data into a caller provided buffer. This means the bootloader no
> longer has to contain any policy regarding where to load the initrd
> (which differs between architectures and kernel versions) and no
> longer has to manipulate arch specific data structures such as DT
> or struct bootparams to inform the OS where the initrd resides in
> memory.
>
> Sample output from booting a recent Linux/arm64 kernel:
>
> grub> insmod part_msdos
> grub> linux (hd0,msdos1)/Image
> grub> initrd (hd0,msdos1)/initrd.img
> grub> boot
> EFI stub: Booting Linux Kernel...
> EFI stub: EFI_RNG_PROTOCOL unavailable, KASLR will be disabled
> EFI stub: Generating empty DTB
> EFI stub: Loaded initrd from LINUX_EFI_INITRD_MEDIA_GUID device path
> EFI stub: Exiting boot services and installing virtual address map...
> [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x411fd070]
I don't review enough grub code to be certain I've caught all aspects
of style adherence, so with that in mind, for 1-2/4:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
For 3-4/4, I did have some minor comments, but this is a really great
feature and I would like to see it merged.
/
Leif
> Cc: grub-devel@gnu.org
> Cc: daniel.kiper@oracle.com
> Cc: leif@nuviainc.com
>
> Ard Biesheuvel (4):
> loader/linux: permit NULL argument for argv[] in grub_initrd_load()
> efi: add definition of LoadFile2 protocol
> efi: implemented LoadFile2 initr loading protocol for Linux
> linux: ignore FDT unless we need to modify it
>
> grub-core/commands/efi/lsefi.c | 1 +
> grub-core/loader/arm64/linux.c | 139 ++++++++++++++++++--
> grub-core/loader/efi/fdt.c | 7 +-
> grub-core/loader/linux.c | 2 +-
> include/grub/efi/api.h | 15 +++
> 5 files changed, 149 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-10-23 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 12:08 [PATCH 0/4] linux: implement LoadFile2 initrd loading Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 1/4] loader/linux: permit NULL argument for argv[] in grub_initrd_load() Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 2/4] efi: add definition of LoadFile2 protocol Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 3/4] efi: implemented LoadFile2 initr loading protocol for Linux Ard Biesheuvel
2020-10-23 12:32 ` Leif Lindholm
2020-10-23 17:02 ` Ard Biesheuvel
2020-10-23 12:08 ` [PATCH 4/4] linux: ignore FDT unless we need to modify it Ard Biesheuvel
2020-10-23 12:47 ` Leif Lindholm
2020-10-23 13:12 ` Ard Biesheuvel
2020-10-23 13:16 ` Leif Lindholm
2020-10-23 12:50 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023125055.GE1664@vanye \
--to=leif@nuviainc.com \
--cc=ard.biesheuvel@arm.com \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.