From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kVwvY-000748-UC for mharc-grub-devel@gnu.org; Fri, 23 Oct 2020 09:16:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVwvX-000739-71 for grub-devel@gnu.org; Fri, 23 Oct 2020 09:16:15 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:38405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVwvQ-0000LV-Qf for grub-devel@gnu.org; Fri, 23 Oct 2020 09:16:14 -0400 Received: by mail-wm1-x344.google.com with SMTP id l15so1513241wmi.3 for ; Fri, 23 Oct 2020 06:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ymaoNpx4USYAYf0RlnokRrq8EkLmaYPAour0/EZLefE=; b=1l8gO+qVPtkcsJAgBWpwXY2Ou+/T/9yHUpwunV3G0TdUQFh+wjo4I/rBGok1pVHRj9 OjskioNp62Rstn+cWouVnQrkSSaCKyc2/lQSYaL9YWwL6sO8pwud/NWn8sbm+1sL7IlG /EO2q9qiHAhizRsFHdtjWlzwTLp78j/ucHDS+HfNYwZ1LgAleSb24cNKCDdEspd5WVVH C0OCmFOHUgEtwS7OqCTjFXfSkJoHRKZVYWefKZchiR+yjKEuS8YncI/TFgJxopnJZFcc xmunV2VW13pLKxmYlLyybud3NVsVwyfjUrE+OTFFeRQ1AkWBMVeOPkaAyfZMZ4AZLo9z i7OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ymaoNpx4USYAYf0RlnokRrq8EkLmaYPAour0/EZLefE=; b=IU/u0m5LHY6gzLUNSVP2UeoaQ8ZR21jC5YGJqnB5Qqjih7ZtWUdVp021tBANH6LKA9 BD68H3l4LyWaS8f313O75EzMbIRlbGIxgiB4+PealVI6Q0f2hj+QjcRVcRzDD+H7HILQ ad/wU7ECIwfw47cJ53n2D2O/hztLU0tQeX6kQI/a55CcUoiTGSTQoM5/shV8x0OmxnLh WXznBpCx1FlphdbA+1gqX8Iag0PfelFLfzGw3DBEM8rMO1dwoOrUom7lP9mzlcYTZtki qWlU47t60TZfhFH+h6Sp7mJ2qkvckHdfnEF/nh06J1L/txFj3h79rIuWKoNdGrcnFPJq vhgg== X-Gm-Message-State: AOAM533GnO42+Mfu9ztsDIOTv3jBCDOrlCXu2acIoAdCDi+GbGcfsFNi gk2qWcnIMZ7OpaFUXRQnLxDnrg== X-Google-Smtp-Source: ABdhPJz6j87/SGAA2x0ENcFWH767tcP8PW2eqSAoL+gQ1j9BXLaTDQ2V3C4acWX+Q/Dz3FXmwXYXcQ== X-Received: by 2002:a7b:c149:: with SMTP id z9mr295448wmi.0.1603458966343; Fri, 23 Oct 2020 06:16:06 -0700 (PDT) Received: from vanye (cpc92880-cmbg19-2-0-cust79.5-4.cable.virginm.net. [82.27.104.80]) by smtp.gmail.com with ESMTPSA id l3sm4533342wmg.32.2020.10.23.06.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 06:16:05 -0700 (PDT) Date: Fri, 23 Oct 2020 14:16:04 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Ard Biesheuvel , linux-efi , grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH 4/4] linux: ignore FDT unless we need to modify it Message-ID: <20201023131604.GF1664@vanye> References: <20201023120825.30466-1-ard.biesheuvel@arm.com> <20201023120825.30466-5-ard.biesheuvel@arm.com> <20201023124710.GD1664@vanye> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=leif@nuviainc.com; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 13:16:15 -0000 On Fri, Oct 23, 2020 at 15:12:50 +0200, Ard Biesheuvel wrote: > On Fri, 23 Oct 2020 at 14:47, Leif Lindholm wrote: > > > > On Fri, Oct 23, 2020 at 14:08:25 +0200, Ard Biesheuvel wrote: > > > Now that we implemented supported for the LoadFile2 protocol for initrd > > > loading, there is no longer a need to pass the initrd parameters via > > > the device tree. This means there is no longer a reason to update the > > > device tree in the first place, and so we can ignore it entirely. > > > > There is a change in behaviour here which I don't think matters, but > > I'll call it out anyway: > > If there was ever a kernel out there with an EFI stub that depended on > > a chosen node existing in the DT, and the one provide by firmware did > > not contain one, that setup would break from this *if* it didn't use > > an initrd. > > I checked the Linux source, and the original code contributed by Roy > already contained the logic to create the /chosen node if it wants > there already. So we should be fine here. Excellent. Then, with this information now in a public archive for any unfortunate souls doing anything crazy non-linux to find: Reviewed-by: Leif Lindholm