From: Denys Dmytriyenko <denys@ti.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [dunfell/master][PATCH] cairo: enable gles2 support
Date: Fri, 23 Oct 2020 13:34:29 -0400 [thread overview]
Message-ID: <20201023173429.GR19741@beryl> (raw)
In-Reply-To: <20201023173127.GQ19741@beryl>
On Fri, Oct 23, 2020 at 01:31:27PM -0400, Denys Dmytriyenko wrote:
> On Fri, Oct 23, 2020 at 11:20:26AM -0500, Dan Murphy wrote:
> > Gowtham
> >
> > On 10/22/20 6:50 AM, Gowtham Tammana wrote:
> > >add gles2 support for devices which can support it.
> > >
> > >Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> > >---
> > > meta-arago-distro/recipes-graphics/cairo/cairo_%.bbappend | 3 +++
> > > 1 file changed, 3 insertions(+)
> > > create mode 100644 meta-arago-distro/recipes-graphics/cairo/cairo_%.bbappend
> > >
> > >diff --git a/meta-arago-distro/recipes-graphics/cairo/cairo_%.bbappend b/meta-arago-distro/recipes-graphics/cairo/cairo_%.bbappend
> > >new file mode 100644
> > >index 00000000..3d67bb6a
> > >--- /dev/null
> > >+++ b/meta-arago-distro/recipes-graphics/cairo/cairo_%.bbappend
> > >@@ -0,0 +1,3 @@
> > >+PR_append = ".arago1"
> > >+
> > >+PACKAGECONFIG_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'egl glesv2', '', d)}"
> >
> > For completeness this patch breaks K2 builds as we discussed off line.
>
> Probably also need to check for "gpu" in MACHINE_FEATURES?
Also, if PACKAGECONFIG is the only change you are making, it may be better to
do it in arago.conf distro config, instead of creating a new bbappend - see
arago.conf for a bunch of other PACKAGECONFIG settings there.
--
Denys
next prev parent reply other threads:[~2020-10-23 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 11:50 [dunfell/master][PATCH] cairo: enable gles2 support Gowtham Tammana
2020-10-23 16:20 ` Dan Murphy
2020-10-23 17:31 ` Denys Dmytriyenko
2020-10-23 17:34 ` Denys Dmytriyenko [this message]
2020-10-23 18:00 ` Tammana, Gowtham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023173429.GR19741@beryl \
--to=denys@ti.com \
--cc=dmurphy@ti.com \
--cc=meta-arago@arago-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.