From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:6b17:0:0:0:0:0 with SMTP id d23csp654572lfa; Fri, 23 Oct 2020 09:16:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRcUlsjkdZNA+zdPIDdpXZXZAII2NsezYeD8gnSZKaNJHWYGiJds4/PoLfnPYRIm7wD4eU X-Received: by 2002:a0c:cd0e:: with SMTP id b14mr2985215qvm.3.1603469798849; Fri, 23 Oct 2020 09:16:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603469798; cv=none; d=google.com; s=arc-20160816; b=Fz7ye4UfUEC8ZuTaZ6/nIGuNqNwo0Q1paLSZMzBeJrt9MFYCQGutIYB70GNmPN63oA /ryELYEnB38GFuXm1QhyZ6kKO0HGoEXnr55V/V05vcBbE7RVZoGvlsnRZ9ObTpjAeRqV dx8DdS/s8BnovC4JkyaDZNrwIusTyL1bkNGl/QSjwNLqaFCSLPkIMqStJm0Say/pYvUH 1temFFhkpCNic0JI/HU5AbxZMuHU4tT952kjClamkATfoU120ByjaA2rFVLkuPGXPnEK ql5iPJCQ3ivDcJaUcbVi2bkJD8LuDJMGBvagmETZoV3WkX2KP33JH2JWA07Sz4Qql8T1 G85A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=rf5/DbVGf5xNwzm7YAsFh69eT8u+FhDSXb+hwn0eXSs=; b=pn6BbbUv7SyfcSqpVgk2s9XCLJn4raDHRkWgWRVW9Yl48iEjKE8YyB2R6+xZp7xAQe eow6Tg4RtA87NFtpxPnBvuA4GbM0loYR15tt4aORAKVXNBfB4A2JCVq2LoZUaA6QqZR1 HAweZq+8Jup9Urg5oXY+rgcYGkULra/GJXCXe7ZqvTrQjWMkiK17HdyyNCYoTyB1N+Q1 FhBl1vE/2lKNcI8A/vK1SgKXpp0LX6e13iWyFI7abMCeG7vFyG2XB29yCYEed5LtoYSa vTBIfzWLTejxbE2L4MXPOdbAFU2CF80gsKWk8V6HDFFqqo0UqOCZRpArjHHxbpBI/1VS /thg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=LQgdsBLB; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k143si1060133qke.11.2020.10.23.09.16.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Oct 2020 09:16:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=LQgdsBLB; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:56740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVzk6-0003Y8-1g for alex.bennee@linaro.org; Fri, 23 Oct 2020 12:16:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVzM3-0003I1-Uk for qemu-arm@nongnu.org; Fri, 23 Oct 2020 11:51:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVzM1-0004kL-6W for qemu-arm@nongnu.org; Fri, 23 Oct 2020 11:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603468304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rf5/DbVGf5xNwzm7YAsFh69eT8u+FhDSXb+hwn0eXSs=; b=LQgdsBLBptDqw01zI5HDaVSIHhX7uY/uG8+1zZorFgD7eEnwoNK+GkZm8ADkWki6Wi/2vi 4XLAjBa6CNy9m88KecrxyUYjWSiftRZgDT3/v46TWl9nKwcgItlTJm3Zq5/HHYTceNtVIz GLChbzT9GUXsUNfa4J+4ZNaNZXeUYos= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-QCsaEQK2PM27PIF4NnJKgQ-1; Fri, 23 Oct 2020 11:51:36 -0400 X-MC-Unique: QCsaEQK2PM27PIF4NnJKgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 28455804B71; Fri, 23 Oct 2020 15:51:35 +0000 (UTC) Received: from localhost (unknown [10.40.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id A75DE1002C17; Fri, 23 Oct 2020 15:51:32 +0000 (UTC) Date: Fri, 23 Oct 2020 17:51:30 +0200 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v3 8/9] hw/arm/raspi: Add the Raspberry Pi Zero machine Message-ID: <20201023175130.50a379bd@redhat.com> In-Reply-To: <20201018203358.1530378-9-f4bug@amsat.org> References: <20201018203358.1530378-1-f4bug@amsat.org> <20201018203358.1530378-9-f4bug@amsat.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 01:44:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Luc Michel , qemu-devel@nongnu.org, Andrew Baumann , qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: anoMHxBHyHIG On Sun, 18 Oct 2020 22:33:57 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > Similarly to the Pi A, the Pi Zero uses a BCM2835 SoC (ARMv6Z core). >=20 > Example booting the machine using content from [*]: >=20 > $ qemu-system-arm -M raspi0 -serial stdio \ > -kernel raspberrypi/firmware/boot/kernel.img \ > -dtb raspberrypi/firmware/boot/bcm2708-rpi-zero.dtb \ > -append 'printk.time=3D0 earlycon=3Dpl011,0x20201000 console=3DttyA= MA0' > [ 0.000000] Booting Linux on physical CPU 0x0 > [ 0.000000] Linux version 4.19.118+ (dom@buildbot) (gcc version 4.9.= 3 (crosstool-NG crosstool-ng-1.22.0-88-g8460611)) #1311 Mon Apr 27 14:16:15= BST 2020 > [ 0.000000] CPU: ARMv6-compatible processor [410fb767] revision 7 (A= RMv7), cr=3D00c5387d > [ 0.000000] CPU: VIPT aliasing data cache, unknown instruction cache > [ 0.000000] OF: fdt: Machine model: Raspberry Pi Zero > ... >=20 > [*] http://archive.raspberrypi.org/debian/pool/main/r/raspberrypi-firmwar= e/raspberrypi-kernel_1.20200512-2_armhf.deb >=20 > Reviewed-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/arm/raspi.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c > index 91a59d1d489..1510ca01afe 100644 > --- a/hw/arm/raspi.c > +++ b/hw/arm/raspi.c > @@ -319,6 +319,15 @@ static void raspi_machine_class_common_init(MachineC= lass *mc, > mc->default_ram_id =3D "ram"; > }; > =20 > +static void raspi0_machine_class_init(ObjectClass *oc, void *data) > +{ > + MachineClass *mc =3D MACHINE_CLASS(oc); > + RaspiMachineClass *rmc =3D RASPI_MACHINE_CLASS(oc); > + > + rmc->board_rev =3D 0x900092; shouldn't it be=20 920092=09Zero=091.2=09512MB=09Embest or 920093 Zero=091.3=09512MB=09Embest > + raspi_machine_class_common_init(mc, rmc->board_rev); > +}; > + > static void raspi1ap_machine_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc =3D MACHINE_CLASS(oc); > @@ -352,6 +361,10 @@ static void raspi3b_machine_class_init(ObjectClass *= oc, void *data) > =20 > static const TypeInfo raspi_machine_types[] =3D { > { > + .name =3D MACHINE_TYPE_NAME("raspi0"), > + .parent =3D TYPE_RASPI_MACHINE, > + .class_init =3D raspi0_machine_class_init, > + }, { > .name =3D MACHINE_TYPE_NAME("raspi1ap"), > .parent =3D TYPE_RASPI_MACHINE, > .class_init =3D raspi1ap_machine_class_init,