From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:6b17:0:0:0:0:0 with SMTP id d23csp746842lfa; Fri, 23 Oct 2020 11:20:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUkoWA7Ar5tYeg1Re2XWCWNbrCul7IjpyLw4RzxsD8kQUTiwVMWM7apcMBcW39G+5EyfC3 X-Received: by 2002:ac8:429a:: with SMTP id o26mr3226809qtl.334.1603477214752; Fri, 23 Oct 2020 11:20:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603477214; cv=none; d=google.com; s=arc-20160816; b=HGMpXY86/SjJuWjHfr4ccn0h+y/Xw9Hpm5dUPTjR3fOve96eMK4OOeU04rPintlSEV 3MPw57Mq6GCB0EJqoNi9LKJ8htvzqpT/FSk147vhOYx2MLsSK35010znb3FY2US12+Fa gp28PVPCxQyGyQ4hLoAIMQfkrSc0hK9rlwjOcCf29gLaxlMGs9B1Cf7gqEI9GLh9VUYu 8d9zUN2qqGrAEQtTh5qFl5MdfLuxVQozUe46N3wtmsAmQFM/OMhVb2iePp0cEGVlH72F v7Pb1mBbqVbqJYGsh6sK04CI57x9LSUTlntpJbHiU7NJOvO+awks0ysPzdnuP3OAo58X qVHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=9bv0VtzVGrXYb0S6ETwgSojAUj2F7tCGWZw5F6cc2Pw=; b=vDwxDBJMi7i2Iu2dLPCJeMyEqEIxaT1nU8vdOyNEV4urdYUHlpsYFWNa4kDFYsQgJs JlxktbvHpJgaSkNAiiQRXlJvVXOVT/8diLkvGWc5qOpliaLI2IU5eOiqnzMMj3nhK/CD un7Iqfjqg5fsR6Yb5NFD9n6e52ig+swME6hzB8cDVCWv+rESRZ3dc7n7M9bv3+8Q2qhL Vi5d5T99cz7KKByaOGiY4GiHLTKuuHLa02/O7cdC7aD1am12XRIhQGCfxZDJS4FnrIWs JO3av+Y7McRBaP1727BMZkjlS6Jz4CadtoHA7zC6Z7SirJiDLFZgEfx5+684lFi9RRt6 35/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=G9WTyHqa; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b1si1198565qtq.287.2020.10.23.11.20.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Oct 2020 11:20:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=G9WTyHqa; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:49834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kW1fi-0005GL-1t for alex.bennee@linaro.org; Fri, 23 Oct 2020 14:20:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW1fE-0005DL-F9 for qemu-arm@nongnu.org; Fri, 23 Oct 2020 14:19:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kW1fC-0007dl-Iu for qemu-arm@nongnu.org; Fri, 23 Oct 2020 14:19:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603477180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bv0VtzVGrXYb0S6ETwgSojAUj2F7tCGWZw5F6cc2Pw=; b=G9WTyHqaiFN7RLp7KFr/3bNEMEscVYDby0rgWWuIE344WfbWJxWXYS5YSobbOQ8lfn4ybf I3T96o8iueMP369SS7SV5UNaewlXSxL/hq+DYZ+hCkQmzYh/BT/mNEH8ZMHpUH0I7wBtG0 yTA4zoNfO4IwkiPJv48q6EHt2zpyTyQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-0oKgq6wENW-UZiUS5ZzwdA-1; Fri, 23 Oct 2020 14:19:39 -0400 X-MC-Unique: 0oKgq6wENW-UZiUS5ZzwdA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA97F1018F64; Fri, 23 Oct 2020 18:19:37 +0000 (UTC) Received: from localhost (unknown [10.40.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id A655A5D9CC; Fri, 23 Oct 2020 18:19:35 +0000 (UTC) Date: Fri, 23 Oct 2020 20:19:34 +0200 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH 08/24] vexpress-a15: Register "virtualization" as class property Message-ID: <20201023201934.4ab6a0e6@redhat.com> In-Reply-To: <20200921221045.699690-9-ehabkost@redhat.com> References: <20200921221045.699690-1-ehabkost@redhat.com> <20200921221045.699690-9-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 02:46:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Daniel P. Berrange" , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , John Snow Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 9Plpy8HUn57L On Mon, 21 Sep 2020 18:10:29 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Peter Maydell > Cc: qemu-arm@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/arm/vexpress.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c > index 0cc35749d7d..13339302af5 100644 > --- a/hw/arm/vexpress.c > +++ b/hw/arm/vexpress.c > @@ -769,12 +769,6 @@ static void vexpress_a15_instance_init(Object *obj) > * but can also be specifically set to on or off. > */ > vms->virt = true; > - object_property_add_bool(obj, "virtualization", vexpress_get_virt, > - vexpress_set_virt); > - object_property_set_description(obj, "virtualization", > - "Set on/off to enable/disable the ARM " > - "Virtualization Extensions " > - "(defaults to same as 'secure')"); > } > > static void vexpress_a9_instance_init(Object *obj) > @@ -822,6 +816,14 @@ static void vexpress_a15_class_init(ObjectClass *oc, void *data) > mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"); > > vmc->daughterboard = &a15_daughterboard; > + > + object_class_property_add_bool(oc, "virtualization", vexpress_get_virt, > + vexpress_set_virt); > + object_class_property_set_description(oc, "virtualization", > + "Set on/off to enable/disable the ARM " > + "Virtualization Extensions " > + "(defaults to same as 'secure')"); > + > } > > static const TypeInfo vexpress_info = {