From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF581C55178 for ; Fri, 23 Oct 2020 22:52:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A8E12137B for ; Fri, 23 Oct 2020 22:52:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A8E12137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEBF86E851; Fri, 23 Oct 2020 22:52:08 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 504056E839; Fri, 23 Oct 2020 22:52:07 +0000 (UTC) IronPort-SDR: PH9r20ZImY//Cl8eOWUNd7oZRDH9XyN+F7CTSJaYmGxlFoystp9s4Di9j0m9OKXsYAbHt+7M9p PiJ/EsVDe3Jg== X-IronPort-AV: E=McAfee;i="6000,8403,9783"; a="167862143" X-IronPort-AV: E=Sophos;i="5.77,410,1596524400"; d="scan'208";a="167862143" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 15:52:06 -0700 IronPort-SDR: 3lB6R6crZpjscfm5YpA2kGymX/e+mbbGX0VDo7rGavBni8rIb7r4fUmcuyarurRwngJCcjWlme uTrtK2h0XRzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,410,1596524400"; d="scan'208";a="359738119" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 23 Oct 2020 15:52:01 -0700 Received: by stinkbox (sSMTP sendmail emulation); Sat, 24 Oct 2020 01:52:00 +0300 Date: Sat, 24 Oct 2020 01:52:00 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Simon Ser Message-ID: <20201023225200.GF6112@intel.com> References: <20201023203957.3255-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Joonyoung Shim , Jingoo Han , "intel-gfx@lists.freedesktop.org" , Seung-Woo Kim , Chen-Yu Tsai , Stefan Agner , Maxime Ripard , Inki Dae , Kyungmin Park , "dri-devel@lists.freedesktop.org" , Gerd Hoffmann Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Oct 23, 2020 at 10:03:50PM +0000, Simon Ser wrote: > On Friday, October 23, 2020 10:39 PM, Ville Syrjala wrote: > = > > From: Ville Syrj=E4l=E4 ville.syrjala@linux.intel.com > > > > The code responsible for creating the IN_FORMATS > > blob is broken when the driver doesn't provide a > > .format_mod_supported() hook. It just copies in > > the format list, but leaves all the modifier information > > zeroed. That would indicate (in a very silly way) that > > there are in fact no supported format+modifier combinations. > > That is utter nonsense. > = > Should we WARN_ON when the driver enables allow_fb_modifiers but > doesn't populate format_mod_supported? .format_mod_supported() was supposed to be optional IIRC. But now that I look at it, it looks like only these drivers are lacking .format_mod_supported(): exynos, mxsfb, tiny/cirrus, tiny/gm12u320. There is some other oddity going on with sun4i which sometimes uses modifiers sometimes it doesn't. No idea what is going on there. But it does have .format_mod_supported() at least. So I guess if we can get exynos, mxsfb, and tiny/* to implement the hook then we could make it mandatory. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41AAAC388F9 for ; Fri, 23 Oct 2020 22:52:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7AF22168B for ; Fri, 23 Oct 2020 22:52:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7AF22168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D41D6E839; Fri, 23 Oct 2020 22:52:08 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 504056E839; Fri, 23 Oct 2020 22:52:07 +0000 (UTC) IronPort-SDR: PH9r20ZImY//Cl8eOWUNd7oZRDH9XyN+F7CTSJaYmGxlFoystp9s4Di9j0m9OKXsYAbHt+7M9p PiJ/EsVDe3Jg== X-IronPort-AV: E=McAfee;i="6000,8403,9783"; a="167862143" X-IronPort-AV: E=Sophos;i="5.77,410,1596524400"; d="scan'208";a="167862143" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 15:52:06 -0700 IronPort-SDR: 3lB6R6crZpjscfm5YpA2kGymX/e+mbbGX0VDo7rGavBni8rIb7r4fUmcuyarurRwngJCcjWlme uTrtK2h0XRzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,410,1596524400"; d="scan'208";a="359738119" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 23 Oct 2020 15:52:01 -0700 Received: by stinkbox (sSMTP sendmail emulation); Sat, 24 Oct 2020 01:52:00 +0300 Date: Sat, 24 Oct 2020 01:52:00 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Simon Ser Subject: Re: [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported() Message-ID: <20201023225200.GF6112@intel.com> References: <20201023203957.3255-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Joonyoung Shim , Jingoo Han , "intel-gfx@lists.freedesktop.org" , Seung-Woo Kim , Chen-Yu Tsai , Hans de Goede , Kyungmin Park , "dri-devel@lists.freedesktop.org" , Gerd Hoffmann Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Oct 23, 2020 at 10:03:50PM +0000, Simon Ser wrote: > On Friday, October 23, 2020 10:39 PM, Ville Syrjala wrote: > = > > From: Ville Syrj=E4l=E4 ville.syrjala@linux.intel.com > > > > The code responsible for creating the IN_FORMATS > > blob is broken when the driver doesn't provide a > > .format_mod_supported() hook. It just copies in > > the format list, but leaves all the modifier information > > zeroed. That would indicate (in a very silly way) that > > there are in fact no supported format+modifier combinations. > > That is utter nonsense. > = > Should we WARN_ON when the driver enables allow_fb_modifiers but > doesn't populate format_mod_supported? .format_mod_supported() was supposed to be optional IIRC. But now that I look at it, it looks like only these drivers are lacking .format_mod_supported(): exynos, mxsfb, tiny/cirrus, tiny/gm12u320. There is some other oddity going on with sun4i which sometimes uses modifiers sometimes it doesn't. No idea what is going on there. But it does have .format_mod_supported() at least. So I guess if we can get exynos, mxsfb, and tiny/* to implement the hook then we could make it mandatory. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel