From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Makefile: Fix u-boot-nodtb.bin target
Date: Sat, 24 Oct 2020 10:51:38 -0400 [thread overview]
Message-ID: <20201024145138.GC14816@bill-the-cat> (raw)
In-Reply-To: <20201007133940.21028-1-pali@kernel.org>
On Wed, Oct 07, 2020 at 03:39:40PM +0200, Pali Roh?r wrote:
> This change fixes two issues when building u-boot-nodtb.bin target:
>
> * Remove intermediate binary u-boot-nodtb.bin from disk when static_rela
> call (which modifies u-boot-nodtb.bin binary) failed. It is required
> because previous objcopy call creates binary and static_rela finish it.
>
> * Do not call static_rela cmd when u-boot-nodtb.bin binary was not
> created/updated by previous objcopy call.
>
> Second fix would ensure that u-boot-nodtb.bin binary is not updated when
> all prerequisites were up-to-date. And therefore final binary u-boot.bin
> is not updated in case all prerequisites were not modified and were
> up-to-date.
>
> Now running 'make SOURCE_DATE_EPOCH=0 u-boot.bin' second time now does not
> touch u-boot.bin binary in case nothing was modified, so GNU make can
> correctly detect that everything is up-to-date.
>
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201024/5d9046c4/attachment.sig>
next prev parent reply other threads:[~2020-10-24 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 13:39 [PATCH] Makefile: Fix u-boot-nodtb.bin target Pali Rohár
2020-10-12 3:34 ` Simon Glass
2020-10-24 14:51 ` Tom Rini [this message]
2020-11-02 13:25 ` Patrick DELAUNAY
2020-11-02 14:15 ` Pali Rohár
2020-11-04 8:53 ` Patrick DELAUNAY
2020-11-04 9:32 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201024145138.GC14816@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.