From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6887256226213658624 X-Received: by 2002:a17:902:b68d:b029:d3:e6e4:3d99 with SMTP id c13-20020a170902b68db02900d3e6e43d99mr4948872pls.62.1603616970643; Sun, 25 Oct 2020 02:09:30 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a17:90a:5d88:: with SMTP id t8ls2954660pji.2.canary-gmail; Sun, 25 Oct 2020 02:09:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwo0t53W2hfhKE9DkaGO7jIHvCZ5rlP4jwt5Bn2FnmtA8RNz4zd2nPbRcN0Mt8YsDtaHB+A X-Received: by 2002:a17:90a:74c5:: with SMTP id p5mr12934024pjl.169.1603616969152; Sun, 25 Oct 2020 02:09:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603616969; cv=none; d=google.com; s=arc-20160816; b=oUITq5Wluff39YVPJqWiberQ7/o0mso8OaszItf0Whd3ShdYGfxhqC98XaMpBJgWoQ O1AIwgo3ZPTdNALqgnzzP4U6EGjL8u2mUDO9TLq8Zq5VVA+bMGCSMhINd6JrgrHZugvq PlLdmdEi3LYWssHazaw6wA0h1tXm77OyZIVzbpBOM836oxXUdTtLjhk9TpzY81pDeaBD ArZkaqO63RrIeC2vUpwPienTv/yymWB0wErvTxmeL/8IP4aaWtFwvoWuRRLXIn3xbO0/ 85GlsFeg72281q0eHXTRap0VGKVTrSAFl8BKiuUWDPW+BvMpw2q3msuJzlHn2jiLfv+3 4OcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=2I6gPWvghFS4b7P8k9TCPW4T6Um3xbt4pGkzpNqsXQk=; b=kX5+E25crh33BEbDznLoC3Ru5BeeITl0zBJmiD7O+StJjOCyWkthEKIhP2u6T6ldVF cJaRUiQ7EmLTr3axGomqxqmeyh/r4wAMfCfRzz1BKSsliq05dAMiXNHk1y29YUUmBGMT /omv096AwzfudSjZOmpSdZUoYPPsisS+TYYf3JmyDxYkSSzhp4OOYe/cV+m0QLHDPhnz E/mEsZyKKNjqg/V1CSjS6jp5Jj++D8XDCxXhr9cnRwbdrieykveuM1tCtSKeA2ixC53W Vxdriv3Ko7T9tnpIwgbh2rZdOvl5Gbbcz7WaEEdTjKr0dcTATXs4PD2TmH+YnaFy+Lzp V2hA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mY5VioAl; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by gmr-mx.google.com with ESMTPS id cq16si440041pjb.2.2020.10.25.02.09.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Oct 2020 02:09:29 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mY5VioAl; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CBA1F208E4; Sun, 25 Oct 2020 09:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603616968; bh=+vy1EXexERftaSv96o2Ok7os9qft4gE2owD3yopXo2E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mY5VioAlxXreH7dso0CUwuk1/X0MSbyJ+P/AeY0IGm2B1FLAkwH35lbgFhCbL96Gd mHQK/lzE+bUm+uK/F43eLVwRvCDgdstcH+kdoWhzNwNnZ008q5LusVhWzl2W6iLup/ FgdBq2IrOKMoGgUXpD0iQc9MN3ZdTd8LpzOvzGW0= Date: Sun, 25 Oct 2020 10:09:24 +0100 From: Greg KH To: Amarjargal Gundjalam Cc: outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: most: fix empty /* line in block comments Message-ID: <20201025090924.GA99582@kroah.com> References: <20201024183134.GA15771@AJ-T14> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201024183134.GA15771@AJ-T14> On Sun, Oct 25, 2020 at 02:31:34AM +0800, Amarjargal Gundjalam wrote: > fix the following warning generated by checkpatch: > networking block comments don't use an empty /* line, use /* Comment. > > Signed-off-by: Amarjargal Gundjalam > --- > drivers/staging/most/net/net.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/most/net/net.c b/drivers/staging/most/net/net.c > index b6fecb06a0e6..bc0aefe804b6 100644 > --- a/drivers/staging/most/net/net.c > +++ b/drivers/staging/most/net/net.c > @@ -171,8 +171,7 @@ static int most_nd_set_mac_address(struct net_device *dev, void *p) > (dev->dev_addr[0] == 0 && dev->dev_addr[1] == 0 && > dev->dev_addr[2] == 0 && dev->dev_addr[3] == 0); > > - /* > - * Set default MTU for the given packet type. > + /* Set default MTU for the given packet type. This is a networking driver, so no, the comment style is correct, sorry for the confusion. greg k-h