From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: vt6655: Break multiple assignments in one line
Date: Sun, 25 Oct 2020 10:20:02 +0100 [thread overview]
Message-ID: <20201025092002.GA107423@kroah.com> (raw)
In-Reply-To: <20201025032331.GA9095@Zangetsu>
On Sat, Oct 24, 2020 at 08:23:31PM -0700, Marcos Antonio de Jesus Filho wrote:
> The kernel coding style disencourage multiple assignments in one
> line. Split this multiple assignments in one line into single assignments
> in multiple lines following this recommendation. Issue found by
> checkpatch.
>
> Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
> ---
> drivers/staging/vt6655/device_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 09ab6d6f2429..ec73b4ac82e6 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -670,7 +670,8 @@ static int device_init_td0_ring(struct vnt_private *priv)
>
> if (i > 0)
> priv->apTD0Rings[i - 1].next_desc = cpu_to_le32(priv->td0_pool_dma);
> - priv->apTailTD[0] = priv->apCurrTD[0] = &priv->apTD0Rings[0];
> + priv->apCurrTD[0] = &priv->apTD0Rings[0];
> + priv->apTailTD[0] = priv->apCurrTD[0];
The original here is fine, you can ignore this checkpatch warning here.
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-25 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 3:23 [PATCH] staging: vt6655: Break multiple assignments in one line Marcos Antonio de Jesus Filho
2020-10-25 9:20 ` Greg Kroah-Hartman [this message]
2020-10-27 9:59 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025092002.GA107423@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=mdejesusfilho@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.