From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Christian Langrock <christian.langrock@secunet.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<anthony.l.nguyen@intel.com>
Subject: Re: Subject: [PATCH net] drivers: net: ixgbe: Fix *_ipsec_offload_ok():, Use ip_hdr family
Date: Mon, 26 Oct 2020 08:33:56 -0700 [thread overview]
Message-ID: <20201026083356.00001999@intel.com> (raw)
In-Reply-To: <1581f61a-f405-008a-8f31-e9e696667d5a@secunet.com>
Christian Langrock wrote:
Please fix your subject, remove the word 'Subject: '
> Xfrm_dev_offload_ok() is called with the unencrypted SKB. So in case of
> interfamily ipsec traffic (IPv4-in-IPv6 and IPv6 in IPv4) the check
> assumes the wrong family of the skb (IP family of the state).
> With this patch the ip header of the SKB is used to determine the
> family.
>
missing "Fixes: " line? It's useful here because I think this looks
like a good candidate for stable bug fix.
> Signed-off-by: Christian Langrock <christian.langrock@secunet.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +-
> drivers/net/ethernet/intel/ixgbevf/ipsec.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
The patch looks ok otherwise, thanks!
prev parent reply other threads:[~2020-10-26 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:44 Subject: [PATCH net] drivers: net: ixgbe: Fix *_ipsec_offload_ok():, Use ip_hdr family Christian Langrock
2020-10-26 15:33 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026083356.00001999@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=christian.langrock@secunet.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.