diff for duplicates of <20201026101340.7c45b604@suse.de> diff --git a/a/1.txt b/N1/1.txt index ecb69d3..f391f05 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -53,7 +53,7 @@ On Sun, 25 Oct 2020 20:14:42 -0500, Mike Christie wrote: > > - pr_warn("Detected MISCOMPARE for addr: %p buf: %p\n", > > - addr, buf + offset); > > - kunmap_atomic(addr); -> > + for (i = 0; i < len && addr[i] == buf[offset + i]; i++); +> > + for (i = 0; i < len && addr[i] = buf[offset + i]; i++); > > I think it's a little nicer to put the ";" on the next line. It's just > not a common line of code so your eyes miss it. It should also make the @@ -90,7 +90,7 @@ Sure, will change this. > > - if (ret) > > + compare_len, > > + &miscmp_off); -> > + if (ret == TCM_MISCOMPARE_VERIFY) { +> > + if (ret = TCM_MISCOMPARE_VERIFY) { > > + /* > > + * SBC-4 r15: 5.3 COMPARE AND WRITE command > > + * In the sense data (see 4.18 and SPC-5) the offset from the diff --git a/a/content_digest b/N1/content_digest index a22cf30..e80ef96 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0311cb7dd-2cdb-e653-ab97-41d644c0d293@oracle.com\0" "From\0David Disseldorp <ddiss@suse.de>\0" "Subject\0Re: [PATCH 5/5] scsi: target: return COMPARE AND WRITE miscompare offsets\0" - "Date\0Mon, 26 Oct 2020 10:13:40 +0100\0" + "Date\0Mon, 26 Oct 2020 09:13:40 +0000\0" "To\0Mike Christie <michael.christie@oracle.com>\0" "Cc\0target-devel@vger.kernel.org" " linux-scsi@vger.kernel.org\0" @@ -64,7 +64,7 @@ "> > -\t\t\tpr_warn(\"Detected MISCOMPARE for addr: %p buf: %p\\n\",\n" "> > -\t\t\t\taddr, buf + offset);\n" "> > -\t\t\tkunmap_atomic(addr);\n" - "> > +\t\tfor (i = 0; i < len && addr[i] == buf[offset + i]; i++); \n" + "> > +\t\tfor (i = 0; i < len && addr[i] = buf[offset + i]; i++); \n" "> \n" "> I think it's a little nicer to put the \";\" on the next line. It's just \n" "> not a common line of code so your eyes miss it. It should also make the \n" @@ -101,7 +101,7 @@ "> > -\tif (ret)\n" "> > +\t\t\t\t compare_len,\n" "> > +\t\t\t\t &miscmp_off);\n" - "> > +\tif (ret == TCM_MISCOMPARE_VERIFY) {\n" + "> > +\tif (ret = TCM_MISCOMPARE_VERIFY) {\n" "> > +\t\t/*\n" "> > +\t\t * SBC-4 r15: 5.3 COMPARE AND WRITE command\n" "> > +\t\t * In the sense data (see 4.18 and SPC-5) the offset from the\n" @@ -121,4 +121,4 @@ "\n" Cheers, David -99d6cc73e0098817b1312b632b571d80a0101d19a1de1499c8f42337e609e0b1 +5660a79e069b6de08374fe25a0f03a4cc62b808da7ebde7be73b291aafa55427
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.