From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Marek Vasut" <marex@denx.de>, "Guido Günther" <agx@sigxcpu.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
dl-linux-imx <linux-imx@nxp.com>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Daniel Abrecht" <freedesktop-linux-dri-devel@danielabrecht.ch>
Subject: Re: [PATCH] Implement .format_mod_supported in mxsfb
Date: Mon, 26 Oct 2020 12:52:07 +0200 [thread overview]
Message-ID: <20201026105207.GI6112@intel.com> (raw)
In-Reply-To: <CAKMK7uEX38yzJGy6PWBs-L375kUGAPQK7SMPjT8Ze+3oKk38Mg@mail.gmail.com>
On Mon, Oct 26, 2020 at 10:05:17AM +0100, Daniel Vetter wrote:
> On Sun, Oct 25, 2020 at 4:52 PM Guido Günther <agx@sigxcpu.org> wrote:
> >
> > Hi Daniel,
> > On Sat, Oct 24, 2020 at 04:59:16PM +0000, Daniel Abrecht wrote:
> > > This will make sure applications which use the IN_FORMATS blob
> > > to figure out which modifiers they can use will pick up the
> > > linear modifier which is needed by mxsfb. Such applications
> > > will not work otherwise if an incompatible implicit modifier
> > > ends up being selected.
> >
> > Since this got broken by the switch away for the simple display
> > pipeline helper (ae1ed0093281939b80664a687689f12436c0e874) could
> > you add a fixes tag?
>
> mxsfb is also missing setting the allow_fb_modifiers flag, without
> which all this modifier stuff won't work great.
drm_universal_plane_init() automagically adds it if a modifier list
is passed in.
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-26 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 16:59 [PATCH] Implement .format_mod_supported in mxsfb Daniel Abrecht
2020-10-25 15:52 ` Guido Günther
2020-10-25 19:50 ` Daniel Abrecht
2020-10-26 9:05 ` Daniel Vetter
2020-10-26 10:52 ` Ville Syrjälä [this message]
2020-10-26 11:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026105207.GI6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=agx@sigxcpu.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedesktop-linux-dri-devel@danielabrecht.ch \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.