From: Deepak R Varma <mh12gx2825@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns
Date: Mon, 26 Oct 2020 19:28:19 +0530 [thread overview]
Message-ID: <20201026135819.GA14348@my--box> (raw)
In-Reply-To: <20201026041652.GM20115@casper.infradead.org>
On Mon, Oct 26, 2020 at 04:16:52AM +0000, Matthew Wilcox wrote:
> On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > > - dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p (acd = %p)\n", cur, cur->acd);
> > > + dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p (acd = %p)\n",
> > > + cur,
> > > + cur->acd);
>
> Why do you put 'cur' and 'cur->acd' on different lines?
Hello,
I was thinking it makes it more readable. However, I understand your
comment and will rearrange the changes accordingly. Thank you for
pointing it out.
>
> > > - rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED, KP_DRIVER_NAME_DMA_CONTROLLER, eng);
> > > + rv = request_irq(eng->irq,
> > > + ndd_irq_handler,
> > > + IRQF_SHARED,
> > > + KP_DRIVER_NAME_DMA_CONTROLLER,
> > > + eng);
>
> Likewise. I'd do:
>
> rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED,
> KP_DRIVER_NAME_DMA_CONTROLLER, eng);
>
Yes, will correct all such occurrences and resend another version.
Thank you,
Deepak.
next prev parent reply other threads:[~2020-10-26 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 7:31 [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns Deepak R Varma
2020-10-21 7:35 ` [PATCH v2 2/2] staging: kpc2000: kpc_dma: rename show function per convention Deepak R Varma
2020-10-26 4:05 ` Deepak R Varma
2020-10-26 4:04 ` [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns Deepak R Varma
2020-10-26 4:16 ` [Outreachy kernel] " Matthew Wilcox
2020-10-26 13:58 ` Deepak R Varma [this message]
2020-10-26 5:57 ` Greg Kroah-Hartman
2020-10-26 17:59 ` Deepak R Varma
2020-10-27 12:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026135819.GA14348@my--box \
--to=mh12gx2825@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.