From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFE8C4363A for ; Mon, 26 Oct 2020 16:04:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0300322404 for ; Mon, 26 Oct 2020 16:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603728292; bh=/ep5fRQ3cXsDaglk7g3bLJ2D08WYwFuAAN0xUQbcjo0=; h=From:To:Cc:Subject:Date:List-ID:From; b=iaUXrmDnWxuVW7BSl4JQoVbsvgbqLWS7kLq+psF5sfN+VTjaf4w6FwQVfZT9bPYZF TnshCAYW4vsQRwegvLuafzu5AGiTSQaaB+RFqf8L4G68tgAEEcreZYUxwL+j4ilixw ALPczPjAa5ew2oP59POME+YgpL3ax/feYoPdmbq8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1784786AbgJZQEq (ORCPT ); Mon, 26 Oct 2020 12:04:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:48736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1774040AbgJZQCu (ORCPT ); Mon, 26 Oct 2020 12:02:50 -0400 Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF89222265; Mon, 26 Oct 2020 16:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603728170; bh=/ep5fRQ3cXsDaglk7g3bLJ2D08WYwFuAAN0xUQbcjo0=; h=From:To:Cc:Subject:Date:From; b=BTfvdDFKrwTYELUJZSZBsQIfvx4s0TDaVG/4ZrmmwKB5sMr/Z8JXz09mTECaMAGTn VRloV8txZkHw6HZRgRkqex/1B22gU7NcZZQdQgROonzDNoPxnwzyNQ7Ch8MpwvVjI1 sCDXITzHfQzmFMwaJa3z++yuz5B/NSRHlgfv33Xk= From: Arnd Bergmann To: =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers Cc: Arnd Bergmann , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH] staging: wfx: avoid uninitialized variable use Date: Mon, 26 Oct 2020 17:02:22 +0100 Message-Id: <20201026160243.3705030-1-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Move the added check of the 'band' variable after the initialization. Pointed out by clang with drivers/staging/wfx/data_tx.c:34:19: warning: variable 'band' is uninitialized when used here [-Wuninitialized] if (rate->idx >= band->n_bitrates) { Fixes: 868fd970e187 ("staging: wfx: improve robustness of wfx_get_hw_rate()") Signed-off-by: Arnd Bergmann --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 41f6a604a697..36b36ef39d05 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -31,13 +31,13 @@ static int wfx_get_hw_rate(struct wfx_dev *wdev, } return rate->idx + 14; } + // WFx only support 2GHz, else band information should be retrieved + // from ieee80211_tx_info + band = wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]; if (rate->idx >= band->n_bitrates) { WARN(1, "wrong rate->idx value: %d", rate->idx); return -1; } - // WFx only support 2GHz, else band information should be retrieved - // from ieee80211_tx_info - band = wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]; return band->bitrates[rate->idx].hw_value; } -- 2.27.0