From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E9EC4363A for ; Mon, 26 Oct 2020 16:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36BBA2084C for ; Mon, 26 Oct 2020 16:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603729046; bh=xV5Zqcht7LNtZR44htjLISewqjkESucpdCaz6BO+o6Y=; h=From:To:Subject:Date:List-ID:From; b=gK16nxnHSzMZSunUwLabKRhSwqMY6n7uRAQfNW/zT0RiL/1a7VswKkAgk33eNQOoF el6pRux2kCdc98RUnLWa+P3/bCwc0V5i1wdgwqrWbUhPUpPp5rFT2/K0UR20WHSKMR VvdPjOWldWwa1exqmcYc/FY8ZMRN5qzahqtXCe6M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1775316AbgJZQRZ (ORCPT ); Mon, 26 Oct 2020 12:17:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:60370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1737072AbgJZQRZ (ORCPT ); Mon, 26 Oct 2020 12:17:25 -0400 Received: from sol.attlocal.net (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3533D207F7 for ; Mon, 26 Oct 2020 16:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603729045; bh=xV5Zqcht7LNtZR44htjLISewqjkESucpdCaz6BO+o6Y=; h=From:To:Subject:Date:From; b=Z0gZQ5oNtPutqwX9O/eKccwdxzklhQfF5CM2u2Mpk7BD6eccq1N0TpZKXZV5rZRBq ZtFU3en3AdEHilpngzxV+EwSpsRBVUB7v6EUFwPDioonilKnr08AuMc8LfqX08mj4s /2ZClito93gNEx6ipKDmYsGOJQDp7vLg1aXsNNhU= From: Eric Biggers To: linux-crypto@vger.kernel.org Subject: [PATCH 0/4] crypto: testmgr - always print the actual driver name Date: Mon, 26 Oct 2020 09:16:58 -0700 Message-Id: <20201026161702.39201-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org When alg_test() is called from tcrypt.ko rather than from the algorithm registration code, "driver" is actually the algorithm name, not the driver name. So it shouldn't be used in places where a driver name is wanted, e.g. when reporting a test failure or when checking whether the driver is the generic driver or not. See https://lkml.kernel.org/r/20200910122248.GA22506@Red for an example where this caused a problem. The self-tests reported "alg: ahash: md5 test failed", but it wasn't mentioned which md5 implementation it was. Fix this by getting the driver name from the crypto tfm object that actually got allocated. Eric Biggers (4): crypto: aead - add crypto_aead_driver_name() crypto: testmgr - always print the actual hash driver name crypto: testmgr - always print the actual AEAD driver name crypto: testmgr - always print the actual skcipher driver name crypto/testmgr.c | 121 +++++++++++++++++++----------------------- include/crypto/aead.h | 5 ++ 2 files changed, 59 insertions(+), 67 deletions(-) base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec -- 2.29.1