From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [iptables PATCH 3/3] nft: Fix for concurrent noflush restore calls
Date: Mon, 26 Oct 2020 17:36:41 +0100 [thread overview]
Message-ID: <20201026163641.GA31480@salvia> (raw)
In-Reply-To: <20201026163102.GB5098@orbyte.nwl.cc>
On Mon, Oct 26, 2020 at 05:31:02PM +0100, Phil Sutter wrote:
> On Fri, Oct 16, 2020 at 05:28:50PM +0200, Pablo Neira Ayuso wrote:
> [...]
> > Makes sense. Thanks a lot for explaining. Probably you can include
> > this in the commit description for the record.
> >
> > > I realize the test case is not quite effective, ruleset should be
> > > emptied upon each iteration of concurrent restore job startup.
> >
> > Please, update the test and revamp.
>
> I pushed the commit already when you wrote "LGTM" in your first reply,
> sorry. Yet to cover for the above, I just submitted a patch which adds a
> bit of documentation to the test case (apart from improving its
> effectiveness).
No problem. Thanks for following up.
prev parent reply other threads:[~2020-10-26 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 14:48 [iptables PATCH 0/3] nft: Fix transaction refreshing Phil Sutter
2020-10-05 14:48 ` [iptables PATCH 1/3] nft: Make batch_add_chain() return the added batch object Phil Sutter
2020-10-05 21:07 ` Florian Westphal
2020-10-05 14:48 ` [iptables PATCH 2/3] nft: Fix error reporting for refreshed transactions Phil Sutter
2020-10-05 21:13 ` Florian Westphal
2020-10-05 14:48 ` [iptables PATCH 3/3] nft: Fix for concurrent noflush restore calls Phil Sutter
2020-10-12 12:54 ` Pablo Neira Ayuso
2020-10-13 10:08 ` Phil Sutter
2020-10-13 10:15 ` Pablo Neira Ayuso
2020-10-14 9:46 ` Phil Sutter
2020-10-16 15:28 ` Pablo Neira Ayuso
2020-10-26 16:31 ` Phil Sutter
2020-10-26 16:36 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026163641.GA31480@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.