[PATCH] MIPS: ingenic: remove unused platform_data header file

[PATCH] MIPS: ingenic: remove unused platform_data header file

[Sam Ravnborg]

There are no users of this headers file in the kernel.
All users are likely migrated to device tree which is a good thing.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: Harvey Hunt <harveyhuntnexus@gmail.com>
Cc: linux-mips@vger.kernel.org
---

I noticed this while surfing around in platform_data for no apperant
reason. So no fancy tooling or some such involved.

	Sam

 .../linux/platform_data/jz4740/jz4740_nand.h  | 25 -------------------
 1 file changed, 25 deletions(-)
 delete mode 100644 include/linux/platform_data/jz4740/jz4740_nand.h

diff --git a/include/linux/platform_data/jz4740/jz4740_nand.h b/include/linux/platform_data/jz4740/jz4740_nand.h
deleted file mode 100644
index b3f066d63059..000000000000
--- a/include/linux/platform_data/jz4740/jz4740_nand.h
+++ /dev/null
@@ -1,25 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-/*
- *  Copyright (C) 2009-2010, Lars-Peter Clausen <lars@metafoo.de>
- *  JZ4740 SoC NAND controller driver
- */
-
-#ifndef __JZ4740_NAND_H__
-#define __JZ4740_NAND_H__
-
-#include <linux/mtd/rawnand.h>
-#include <linux/mtd/partitions.h>
-
-#define JZ_NAND_NUM_BANKS 4
-
-struct jz_nand_platform_data {
-	int			num_partitions;
-	struct mtd_partition	*partitions;
-
-	unsigned char banks[JZ_NAND_NUM_BANKS];
-
-	void (*ident_callback)(struct platform_device *, struct mtd_info *,
-				struct mtd_partition **, int *num_partitions);
-};
-
-#endif
-- 
2.27.0

Re: [PATCH] MIPS: ingenic: remove unused platform_data header file

[Paul Cercueil]

Hi,

Le lun. 26 oct. 2020 à 20:20, Sam Ravnborg <sam@ravnborg.org> a écrit 
:
> There are no users of this headers file in the kernel.
> All users are likely migrated to device tree which is a good thing.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Harvey Hunt <harveyhuntnexus@gmail.com>
> Cc: linux-mips@vger.kernel.org
> ---
> 
> I noticed this while surfing around in platform_data for no apperant
> reason. So no fancy tooling or some such involved.

The jz4740-nand driver has been removed in Linux 5.3. Therefore:

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> 
> 	Sam
> 
>  .../linux/platform_data/jz4740/jz4740_nand.h  | 25 
> -------------------
>  1 file changed, 25 deletions(-)
>  delete mode 100644 include/linux/platform_data/jz4740/jz4740_nand.h
> 
> diff --git a/include/linux/platform_data/jz4740/jz4740_nand.h 
> b/include/linux/platform_data/jz4740/jz4740_nand.h
> deleted file mode 100644
> index b3f066d63059..000000000000
> --- a/include/linux/platform_data/jz4740/jz4740_nand.h
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - *  Copyright (C) 2009-2010, Lars-Peter Clausen <lars@metafoo.de>
> - *  JZ4740 SoC NAND controller driver
> - */
> -
> -#ifndef __JZ4740_NAND_H__
> -#define __JZ4740_NAND_H__
> -
> -#include <linux/mtd/rawnand.h>
> -#include <linux/mtd/partitions.h>
> -
> -#define JZ_NAND_NUM_BANKS 4
> -
> -struct jz_nand_platform_data {
> -	int			num_partitions;
> -	struct mtd_partition	*partitions;
> -
> -	unsigned char banks[JZ_NAND_NUM_BANKS];
> -
> -	void (*ident_callback)(struct platform_device *, struct mtd_info *,
> -				struct mtd_partition **, int *num_partitions);
> -};
> -
> -#endif
> --
> 2.27.0
> 

Re: [PATCH] MIPS: ingenic: remove unused platform_data header file

[Thomas Bogendoerfer]

On Mon, Oct 26, 2020 at 08:20:40PM +0100, Sam Ravnborg wrote:
> There are no users of this headers file in the kernel.
> All users are likely migrated to device tree which is a good thing.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Harvey Hunt <harveyhuntnexus@gmail.com>
> Cc: linux-mips@vger.kernel.org
> ---
> 
> I noticed this while surfing around in platform_data for no apperant
> reason. So no fancy tooling or some such involved.
> 
> 	Sam
> 
>  .../linux/platform_data/jz4740/jz4740_nand.h  | 25 -------------------
>  1 file changed, 25 deletions(-)
>  delete mode 100644 include/linux/platform_data/jz4740/jz4740_nand.h

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH] MIPS: ingenic: remove unused platform_data header file

[Sam Ravnborg]

Hi Thomas,

On Tue, Oct 27, 2020 at 01:10:43PM +0100, Thomas Bogendoerfer wrote:
> On Mon, Oct 26, 2020 at 08:20:40PM +0100, Sam Ravnborg wrote:
> > There are no users of this headers file in the kernel.
> > All users are likely migrated to device tree which is a good thing.
> > 
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Cercueil <paul@crapouillou.net>
> > Cc: Harvey Hunt <harveyhuntnexus@gmail.com>
> > Cc: linux-mips@vger.kernel.org
> > ---
> > 
> > I noticed this while surfing around in platform_data for no apperant
> > reason. So no fancy tooling or some such involved.
> > 
> > 	Sam
> > 
> >  .../linux/platform_data/jz4740/jz4740_nand.h  | 25 -------------------
> >  1 file changed, 25 deletions(-)
> >  delete mode 100644 include/linux/platform_data/jz4740/jz4740_nand.h
> 
> applied to mips-next.

Thanks for the quick response. Hopefully I can contribute something a little
more useful next time :-)

But then cleaning out old cruft is never a waste of time.

	Sam