All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Matyukevich <geomatsi@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] package/gpsd: enable python support and modules
Date: Mon, 26 Oct 2020 22:24:06 +0300	[thread overview]
Message-ID: <20201026192406.GA6556@curiosity> (raw)
In-Reply-To: <708ec24d77457a28b10a6970a474b834a489c060.camel@calian.com>

Hi Robert,

> > @@ -186,6 +185,18 @@ endif
> >  ifeq ($(BR2_PACKAGE_GPSD_MAX_DEV),y)
> >  GPSD_SCONS_OPTS += max_devices=$(BR2_PACKAGE_GPSD_MAX_DEV_VALUE)
> >  endif
> > +ifeq ($(BR2_PACKAGE_PYTHON3),y)
> > +	GPSD_SCONS_OPTS += \
> > +		python=yes \
> > +		python_libdir="/usr/lib/python$(PYTHON3_VERSION_MAJOR)/
> > site-packages"
> > +else ifeq ($(BR2_PACKAGE_PYTHON),y)
> > +	GPSD_SCONS_OPTS += \
> > +		python=yes \
> > +		python_libdir="/usr/lib/python$(PYTHON_VERSION_MAJOR)/s
> > ite-packages"
> > +else
> > +	GPSD_SCONS_OPTS = \
> 
> This should presumably be += like the other cases, otherwise it will
> wipe out all the other options.
> 
> > +		python=no
> > +endif

Thanks for catching! I will fix this issue in v3.

Regards,
Sergey

      parent reply	other threads:[~2020-10-26 19:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-25 20:24 [Buildroot] [PATCH v2 0/2] package/gpsd: bump version Sergey Matyukevich
2020-10-25 20:24 ` [Buildroot] [PATCH v2 1/2] package/gpsd: bump version to 3.21 Sergey Matyukevich
2020-10-25 20:24 ` [Buildroot] [PATCH v2 2/2] package/gpsd: enable python support and modules Sergey Matyukevich
     [not found]   ` <708ec24d77457a28b10a6970a474b834a489c060.camel@calian.com>
2020-10-26 19:24     ` Sergey Matyukevich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026192406.GA6556@curiosity \
    --to=geomatsi@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.