From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH] crypto: arm64/poly1305-neon - reorder PAC authentication with SP update
Date: Mon, 26 Oct 2020 16:03:23 -0700 [thread overview]
Message-ID: <20201026230323.GA1947033@gmail.com> (raw)
In-Reply-To: <20201026230027.25813-1-ardb@kernel.org>
On Tue, Oct 27, 2020 at 12:00:27AM +0100, Ard Biesheuvel wrote:
> PAC pointer authentication signs the return address against the value
> of the stack pointer, to prevent stack overrun exploits from corrupting
> the control flow. However, this requires that the AUTIASP is issued with
> SP holding the same value as it held when the PAC value was generated.
> The Poly1305 NEON code got this wrong, resulting in crashes on PAC
> capable hardware.
>
> Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS ...")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm64/crypto/poly1305-armv8.pl | 2 +-
> arch/arm64/crypto/poly1305-core.S_shipped | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
This needs to be fixed at https://github.com/dot-asm/cryptogams too, I assume?
- Eric
next prev parent reply other threads:[~2020-10-26 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 23:00 [PATCH] crypto: arm64/poly1305-neon - reorder PAC authentication with SP update Ard Biesheuvel
2020-10-26 23:03 ` Eric Biggers [this message]
2020-10-26 23:04 ` Ard Biesheuvel
2020-10-26 23:06 ` Ard Biesheuvel
2020-10-29 13:27 ` Andy Polyakov
2020-11-06 7:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026230323.GA1947033@gmail.com \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.