From: Jonathan Nieder <jrnieder@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 21/30] patman: Require tags to be before sign-off
Date: Mon, 26 Oct 2020 23:05:32 -0700 [thread overview]
Message-ID: <20201027060532.GI2645313@google.com> (raw)
In-Reply-To: <CAPnjgZ3SoKM5dqHkaiqtFZC6t066fpLSm1qgH_0_HyxX1GOFMQ@mail.gmail.com>
Simon Glass wrote:
> On Sun, 25 Oct 2020 at 19:23, Sean Anderson <seanga2@gmail.com> wrote:
>> I also like to put SOBs on top because it groups all the commit-specific
>> information before any patman-specific tags. The last commit (the HEAD)
>> usually has several tags (Series-to/cc, Series-process-log,
>> Cover-letter, etc.) which are unrelated to the commit itself.
>>
>> The tool should do what is best for us humans, not what is convenient
>> for the tool.
>
> I suppose it can be done. But we have the same problem with Change-Id.
> Do you use gerit?
I assume this is mostly about Commit-Notes, when used without
following the rfc-style format that has subsequent lines indented.
If so, then this issue isn't specific to Gerrit: it applies when using
Git directly (the "git interpret-trailers" command, "git commit
--amend --signoff", and so on).
As long as you're following rfc822 syntax, all is fine, so in some
sense the issue here is the Commit-Notes tag. Should it go in the
commit message body instead of the trailer paragraph?
Thanks,
Jonathan
next prev parent reply other threads:[~2020-10-27 6:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 1:04 [PATCH v2 00/30] patman: Collect review tags and comments from Patchwork Simon Glass
2020-10-26 1:04 ` [PATCH v2 01/30] patman: Correct operation of -n Simon Glass
2020-10-26 1:04 ` [PATCH v2 02/30] azure/gitLab/travis: Add pygit2 as a dependency for tests Simon Glass
2020-10-26 1:04 ` [PATCH v2 03/30] patman: Update how tests are run Simon Glass
2020-10-26 1:04 ` [PATCH v2 04/30] patman: Fix whitespace errors in func_test Simon Glass
2020-10-26 1:04 ` [PATCH v2 05/30] patman: Use capture_sys_output() consistently Simon Glass
2020-10-26 1:04 ` [PATCH v2 06/30] patman: Fix remaining pylint3 warnings in func_test Simon Glass
2020-10-26 1:04 ` [PATCH v2 07/30] patman: Allow linking a series with patchwork Simon Glass
2020-10-26 1:04 ` [PATCH v2 08/30] patman: Fix indenting in patchstream Simon Glass
2020-10-26 1:04 ` [PATCH v2 09/30] patman: Fix constant style " Simon Glass
2020-10-26 1:04 ` [PATCH v2 10/30] patman: Rename functions " Simon Glass
2020-10-26 1:04 ` [PATCH v2 11/30] patman: Rename variables " Simon Glass
2020-10-26 1:04 ` [PATCH v2 12/30] patman: Drop unused args " Simon Glass
2020-10-26 1:04 ` [PATCH v2 13/30] patman: Fix up argument/return docs " Simon Glass
2020-10-26 1:04 ` [PATCH v2 14/30] patman: Move warning collection to a function Simon Glass
2020-10-26 1:04 ` [PATCH v2 15/30] patman: Attach warnings to individual patches Simon Glass
2020-10-26 1:04 ` [PATCH v2 16/30] patman: Convert 'Series-xxx' tag errors into warnings Simon Glass
2020-10-26 1:04 ` [PATCH v2 17/30] patman: Drop unused signoff member Simon Glass
2020-10-26 1:04 ` [PATCH v2 18/30] patman: Add a test for PatchStream tags Simon Glass
2020-10-26 1:04 ` [PATCH v2 19/30] patman: Add some tests for warnings Simon Glass
2020-10-26 1:04 ` [PATCH v2 20/30] patman: Convert testBasic() to use an interator Simon Glass
2020-10-26 1:04 ` [PATCH v2 21/30] patman: Require tags to be before sign-off Simon Glass
2020-10-26 1:23 ` Sean Anderson
2020-10-27 4:53 ` Simon Glass
2020-10-27 6:05 ` Jonathan Nieder [this message]
2020-10-27 20:33 ` Sean Anderson
2020-10-26 1:04 ` [PATCH v2 22/30] patman: Fix spelling of plural for warning Simon Glass
2020-10-26 1:04 ` [PATCH v2 23/30] patman: Don't ignore lines starting with hash Simon Glass
2020-10-26 1:04 ` [PATCH v2 24/30] patman: Allow showing a Commit as a string Simon Glass
2020-10-26 1:04 ` [PATCH v2 25/30] patman: Improve handling of files Simon Glass
2020-10-26 1:04 ` [PATCH v2 26/30] patman: Detect missing upstream in CountCommitsToBranch Simon Glass
2020-10-26 1:04 ` [PATCH v2 27/30] patman: Support checking for review tags in patchwork Simon Glass
2020-10-26 1:04 ` [PATCH v2 28/30] patman: Support updating a branch with review tags Simon Glass
2020-10-26 1:04 ` [PATCH v2 29/30] patman: Support parsing of review snippets Simon Glass
2020-10-26 1:04 ` [PATCH v2 30/30] patman: Support listing comments from patchwork Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027060532.GI2645313@google.com \
--to=jrnieder@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.