From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F91C388F9 for ; Tue, 27 Oct 2020 08:53:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EEEB22258 for ; Tue, 27 Oct 2020 08:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603788784; bh=SqUJ9x9risv90uZYTfnyI8hkuL48fOtSxMLCvQ2Gi28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HRq5UlWJl3GAVOBlInkh8WBgBuo+GsxDS9mK+erJTQPmoOJza2iKQ28Vidj6ooQmC 9qdGPPDPkrDtroECjADXdiqn8NuVxaGmgrhq/fDCU5RcJa0bEqhquWaUXmZ06Sfa0t 46KIsrY1jek8ezpRUH9hH9gUZnPVBPgO8BPlnF04= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895120AbgJ0Iw7 convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2020 04:52:59 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40599 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895116AbgJ0Iw7 (ORCPT ); Tue, 27 Oct 2020 04:52:59 -0400 Received: by mail-ed1-f68.google.com with SMTP id p93so576841edd.7; Tue, 27 Oct 2020 01:52:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=miK2E28wkgKpBF1Fb19w02StT2/a3W+EFB25jg9SneM=; b=Hb8Uuy7WFlcCsoIAS0qHGUuWg/TSfyWokYWQWRHBg0No6zSu+t3giURfdXdtiD+8KP VM6BrJBUrAqFpa9AdN9CH4QPSOHNNCtZx/uu2pJ5Q8mcpTAdUmPRRzhtmvJM1GdhPKKK VdAHIaxuF+oxOy5OTuv1E/kpwt6U7bEHKUmxfjnHrhJNgDp1n3EtTHvLX2VsFPwMxcfF Jp84pvpmKwfG8pzUYcY+9Q/BxwARdmYk+4qRZpBn3K5dRPyknujn4aB2JtZRwnQFDKgj 0pzppMv1bkGeKNdbpph1FGIROF0Z2p5VWbSFOJK+nDU2RZw7S4mLDCbPyR2NJr8Q19b2 20zA== X-Gm-Message-State: AOAM530Z7RhqsvzAjmBYEjZLy65is8zY4j8pqvMc4K4weZFfdJ0F0MtY HAotwad2mJQhFP3mvAgaNzY= X-Google-Smtp-Source: ABdhPJx3r/Ivqz3bC6fK7Dk3U50yBK7Yqy4j7oDemcQ7xJqnXXJr2+AP4pt/yaUfzlPS/UM2jTnfbg== X-Received: by 2002:a05:6402:135a:: with SMTP id y26mr1113530edw.114.1603788776652; Tue, 27 Oct 2020 01:52:56 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id m25sm503543edp.36.2020.10.27.01.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 01:52:55 -0700 (PDT) Date: Tue, 27 Oct 2020 09:52:53 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Chanwoo Choi , Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 00/52] Introduce memory interconnect for NVIDIA Tegra SoCs Message-ID: <20201027085253.GC4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201026150845.GA87050@kozik-lap> <48a5cfdd-c170-f6d3-001a-2d343ecb2c5e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <48a5cfdd-c170-f6d3-001a-2d343ecb2c5e@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Oct 26, 2020 at 10:14:10PM +0300, Dmitry Osipenko wrote: > 26.10.2020 18:08, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:43AM +0300, Dmitry Osipenko wrote: > >> Hello, > >> > >> This series brings initial support for memory interconnect to Tegra20, > >> Tegra30 and Tegra124 SoCs. > >> > >> For the starter only display controllers and devfreq devices are getting > >> interconnect API support, others could be supported later on. The display > >> controllers have the biggest demand for interconnect API right now because > >> dynamic memory frequency scaling can't be done safely without taking into > >> account bandwidth requirement from the displays. In particular this series > >> fixes distorted display output on T30 Ouya and T124 TK1 devices. > > > > Hi, > > > > You introduced in v6 multiple new patches. Could you describe the > > dependencies, if any? > > Hello, > > The v6 dropped some older patches and replaced them with the new > patches. Previously I wanted to postpone the more complex changes for > later times, like supporting OPP tables and DVFS, but then the review > started to take more time than was expected and there was enough time to > complete those features. > > There are five basic sets of patches: > > 1. DT bindings > 2. DT changes > 3. SoC, clk and memory > 4. devfreq > 5. DRM > > Each set could be applied separately. > > Memory patches have a build dependency on the SoC and clk patches. > > The "tegra-mc: Add interconnect framework" and "Add and use > devm_tegra_get_memory_controller()" are the root build dependencies for > all memory/ patches. Other patches are grouped per SoC generation > (Tegra20/30/124), patches within a SoC-gen group are interdependent. > > I suppose the best variant would be to merge the whole series via > tegra-tree in order to preserve logical order of the patches. Although, > merging each set of patches separately also should be okay to do. Thanks for explanation. I already have three patches for Tegra MC (and probably two more will be respun) so this might be conflict-prone. The easiest in such case is to provide me soc and clk patches on the branch, so I could keep all Tegra MC together. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EBC9C56201 for ; Tue, 27 Oct 2020 08:53:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D3FB207DE for ; Tue, 27 Oct 2020 08:53:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D3FB207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D207A6E1B2; Tue, 27 Oct 2020 08:52:59 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3248C6E1B2 for ; Tue, 27 Oct 2020 08:52:58 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id l16so588002eds.3 for ; Tue, 27 Oct 2020 01:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=miK2E28wkgKpBF1Fb19w02StT2/a3W+EFB25jg9SneM=; b=XLJimAi/ODuW+DWbnowHEfdvc5if7rtmGDTpD5p+k5GSIWaaPagGQYhKaUUIJntufT q9MOpnHrDfAEHkPa7uBcJ0a/31RaNTVWSYI7swT3ge6f/oSSgFic5LIKkNIxFOKPgXH3 4axhkSQ+n0TDGyqnMjLXZsJ+FOypd8XMs8FyAs3yiA8oRmu/RrmPMRv7Qt6cdUur6Vdg MCapujVcDqxqMPbUnjpnqwQ8qC6brkPE3czGJG2Pg5i3KUYvM9BI3Ev+S3vfiN853FZU JTJLXOK0LHj8tsuaamIqVEu56VB7vmsZW9lp0CHybL24nsp8HZ5Q97SnfKugFzGW6IuC q2Pg== X-Gm-Message-State: AOAM530S7KiTE0KdiuZy2/0XDacazLpcuMMlvFH1Ebfe9jmKGw1W9t3W HwhC070/lS5hcTcCa0wC0mGBLoLTuLKeap8A X-Google-Smtp-Source: ABdhPJx3r/Ivqz3bC6fK7Dk3U50yBK7Yqy4j7oDemcQ7xJqnXXJr2+AP4pt/yaUfzlPS/UM2jTnfbg== X-Received: by 2002:a05:6402:135a:: with SMTP id y26mr1113530edw.114.1603788776652; Tue, 27 Oct 2020 01:52:56 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id m25sm503543edp.36.2020.10.27.01.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 01:52:55 -0700 (PDT) Date: Tue, 27 Oct 2020 09:52:53 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 00/52] Introduce memory interconnect for NVIDIA Tegra SoCs Message-ID: <20201027085253.GC4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201026150845.GA87050@kozik-lap> <48a5cfdd-c170-f6d3-001a-2d343ecb2c5e@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <48a5cfdd-c170-f6d3-001a-2d343ecb2c5e@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBPY3QgMjYsIDIwMjAgYXQgMTA6MTQ6MTBQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI2LjEwLjIwMjAgMTg6MDgsIEtyenlzenRvZiBLb3psb3dza2kg0L/QuNGI0LXR gjoKPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjQzQU0gKzAzMDAsIERtaXRyeSBP c2lwZW5rbyB3cm90ZToKPiA+PiBIZWxsbywKPiA+Pgo+ID4+IFRoaXMgc2VyaWVzIGJyaW5ncyBp bml0aWFsIHN1cHBvcnQgZm9yIG1lbW9yeSBpbnRlcmNvbm5lY3QgdG8gVGVncmEyMCwKPiA+PiBU ZWdyYTMwIGFuZCBUZWdyYTEyNCBTb0NzLgo+ID4+Cj4gPj4gRm9yIHRoZSBzdGFydGVyIG9ubHkg ZGlzcGxheSBjb250cm9sbGVycyBhbmQgZGV2ZnJlcSBkZXZpY2VzIGFyZSBnZXR0aW5nCj4gPj4g aW50ZXJjb25uZWN0IEFQSSBzdXBwb3J0LCBvdGhlcnMgY291bGQgYmUgc3VwcG9ydGVkIGxhdGVy IG9uLiBUaGUgZGlzcGxheQo+ID4+IGNvbnRyb2xsZXJzIGhhdmUgdGhlIGJpZ2dlc3QgZGVtYW5k IGZvciBpbnRlcmNvbm5lY3QgQVBJIHJpZ2h0IG5vdyBiZWNhdXNlCj4gPj4gZHluYW1pYyBtZW1v cnkgZnJlcXVlbmN5IHNjYWxpbmcgY2FuJ3QgYmUgZG9uZSBzYWZlbHkgd2l0aG91dCB0YWtpbmcg aW50bwo+ID4+IGFjY291bnQgYmFuZHdpZHRoIHJlcXVpcmVtZW50IGZyb20gdGhlIGRpc3BsYXlz LiBJbiBwYXJ0aWN1bGFyIHRoaXMgc2VyaWVzCj4gPj4gZml4ZXMgZGlzdG9ydGVkIGRpc3BsYXkg b3V0cHV0IG9uIFQzMCBPdXlhIGFuZCBUMTI0IFRLMSBkZXZpY2VzLgo+ID4gCj4gPiBIaSwKPiA+ IAo+ID4gWW91IGludHJvZHVjZWQgaW4gdjYgbXVsdGlwbGUgbmV3IHBhdGNoZXMuIENvdWxkIHlv dSBkZXNjcmliZSB0aGUKPiA+IGRlcGVuZGVuY2llcywgaWYgYW55Pwo+IAo+IEhlbGxvLAo+IAo+ IFRoZSB2NiBkcm9wcGVkIHNvbWUgb2xkZXIgcGF0Y2hlcyBhbmQgcmVwbGFjZWQgdGhlbSB3aXRo IHRoZSBuZXcKPiBwYXRjaGVzLiBQcmV2aW91c2x5IEkgd2FudGVkIHRvIHBvc3Rwb25lIHRoZSBt b3JlIGNvbXBsZXggY2hhbmdlcyBmb3IKPiBsYXRlciB0aW1lcywgbGlrZSBzdXBwb3J0aW5nIE9Q UCB0YWJsZXMgYW5kIERWRlMsIGJ1dCB0aGVuIHRoZSByZXZpZXcKPiBzdGFydGVkIHRvIHRha2Ug bW9yZSB0aW1lIHRoYW4gd2FzIGV4cGVjdGVkIGFuZCB0aGVyZSB3YXMgZW5vdWdoIHRpbWUgdG8K PiBjb21wbGV0ZSB0aG9zZSBmZWF0dXJlcy4KPiAKPiBUaGVyZSBhcmUgZml2ZSBiYXNpYyBzZXRz IG9mIHBhdGNoZXM6Cj4gCj4gCTEuIERUIGJpbmRpbmdzCj4gCTIuIERUIGNoYW5nZXMKPiAJMy4g U29DLCBjbGsgYW5kIG1lbW9yeQo+IAk0LiBkZXZmcmVxCj4gCTUuIERSTQo+IAo+IEVhY2ggc2V0 IGNvdWxkIGJlIGFwcGxpZWQgc2VwYXJhdGVseS4KPiAKPiBNZW1vcnkgcGF0Y2hlcyBoYXZlIGEg YnVpbGQgZGVwZW5kZW5jeSBvbiB0aGUgU29DIGFuZCBjbGsgcGF0Y2hlcy4KPiAKPiBUaGUgInRl Z3JhLW1jOiBBZGQgaW50ZXJjb25uZWN0IGZyYW1ld29yayIgYW5kICJBZGQgYW5kIHVzZQo+IGRl dm1fdGVncmFfZ2V0X21lbW9yeV9jb250cm9sbGVyKCkiIGFyZSB0aGUgcm9vdCBidWlsZCBkZXBl bmRlbmNpZXMgZm9yCj4gYWxsIG1lbW9yeS8gcGF0Y2hlcy4gT3RoZXIgcGF0Y2hlcyBhcmUgZ3Jv dXBlZCBwZXIgU29DIGdlbmVyYXRpb24KPiAoVGVncmEyMC8zMC8xMjQpLCBwYXRjaGVzIHdpdGhp biBhIFNvQy1nZW4gZ3JvdXAgYXJlIGludGVyZGVwZW5kZW50Lgo+IAo+IEkgc3VwcG9zZSB0aGUg YmVzdCB2YXJpYW50IHdvdWxkIGJlIHRvIG1lcmdlIHRoZSB3aG9sZSBzZXJpZXMgdmlhCj4gdGVn cmEtdHJlZSBpbiBvcmRlciB0byBwcmVzZXJ2ZSBsb2dpY2FsIG9yZGVyIG9mIHRoZSBwYXRjaGVz LiBBbHRob3VnaCwKPiBtZXJnaW5nIGVhY2ggc2V0IG9mIHBhdGNoZXMgc2VwYXJhdGVseSBhbHNv IHNob3VsZCBiZSBva2F5IHRvIGRvLgoKVGhhbmtzIGZvciBleHBsYW5hdGlvbi4gSSBhbHJlYWR5 IGhhdmUgdGhyZWUgcGF0Y2hlcyBmb3IgVGVncmEgTUMgKGFuZApwcm9iYWJseSB0d28gbW9yZSB3 aWxsIGJlIHJlc3B1bikgc28gdGhpcyBtaWdodCBiZSBjb25mbGljdC1wcm9uZS4gVGhlCmVhc2ll c3QgaW4gc3VjaCBjYXNlIGlzIHRvIHByb3ZpZGUgbWUgc29jIGFuZCBjbGsgcGF0Y2hlcyBvbiB0 aGUgYnJhbmNoLApzbyBJIGNvdWxkIGtlZXAgYWxsIFRlZ3JhIE1DIHRvZ2V0aGVyLgoKQmVzdCBy ZWdhcmRzLApLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=