From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06ABC4363A for ; Tue, 27 Oct 2020 09:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8990022265 for ; Tue, 27 Oct 2020 09:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603789392; bh=tkAjnw0dYwpXwz/+ySJwzg4QklzQUNN/MU31rPDUmn8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qwpPaDHz4qfeRTHd9mP7Kf+VNV2xCv0wj4JflRV/mmTb+Ra30xFGJbfdGvNxLTp7e XyfTuiYp9fJ6/w6DsQ7SdV3RWM5mYav2b92O4vMAzGhzwaV0Kk8UQ3IOZwkrN0MYqh 7Jh4F7AEn4QYHQ5v45mDWktDMDF/Zz+hq9eGkRQg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895261AbgJ0JDJ (ORCPT ); Tue, 27 Oct 2020 05:03:09 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33051 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895257AbgJ0JDI (ORCPT ); Tue, 27 Oct 2020 05:03:08 -0400 Received: by mail-ed1-f67.google.com with SMTP id w23so627752edl.0; Tue, 27 Oct 2020 02:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Yrkq+w+CNrcs2d/CHfaDmYUZq0y1BCcvuJB0UBRduYM=; b=aI7yKdPROfMOTXi8+ThlRPkv+LA37S0nZv/3npSPlJ3BIjtGcuitGtk6DnsS0/8F1v azGuXdTLyImvNDvMIzjcqWDuh0ZvXjlD1k6xyPJR0TdH0E9qJ0SQcKmqfwrgk3sAveAH RRYIJ+cSk9Nr9MgnH9xpmJLCOBLFDRvOx71LDoeDLvxVNrcBsg0IYlhyDr2zfHK3m9rt 0lW0tU3rTK2YKeTZKF6gHkRfRE8cj50HZHNZ18LTXlpyLiYPA8Jr7uisYd7+CAx4POSy CeE4ZyghNrJaCxiPJOZ8QS3bnkqyfPnKlsA4z7+weUMCOhpv6Pk47bmgAUmjmmMToLbp E5fA== X-Gm-Message-State: AOAM531qDOVxCkQ2of8wY4x4yACjmiYTCyys20gsHQT4PGN+vJ3ADuL9 RMuhbgo07S89qnrmzHM+xhc= X-Google-Smtp-Source: ABdhPJzNdRHhqt+RsXfXzhPc0FfVZYTR4QTRInXFxqbry09ZA816h7phOrK/RR0xsohIY4dLm8QVeg== X-Received: by 2002:aa7:c6d9:: with SMTP id b25mr1096980eds.27.1603789386647; Tue, 27 Oct 2020 02:03:06 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id p4sm587298eji.105.2020.10.27.02.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:03:05 -0700 (PDT) Date: Tue, 27 Oct 2020 10:03:03 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 06/52] dt-bindings: memory: tegra20: emc: Document new interconnect property Message-ID: <20201027090303.GH4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-7-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025221735.3062-7-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Oct 26, 2020 at 01:16:49AM +0300, Dmitry Osipenko wrote: > External Memory Controller is interconnected with memory controller and > with external memory. Document new interconnect property which turns EMC > into interconnect provider. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > index 1b0d4417aad8..0a53adc6ccba 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > @@ -13,6 +13,7 @@ Properties: > - interrupts : Should contain EMC General interrupt. > - clocks : Should contain EMC clock. > - nvidia,memory-controller : Phandle of the Memory Controller node. > +- #interconnect-cells : Should be 0. > > Child device nodes describe the memory settings for different configurations and clock rates. > > @@ -21,6 +22,7 @@ Example: > memory-controller@7000f400 { > #address-cells = < 1 >; > #size-cells = < 0 >; > + #interconnect-cells = < 0 >; No spaces within <>. I see existing example, but bad pattern should not be continued just because it is already there. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A07C388F9 for ; Tue, 27 Oct 2020 09:03:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AED5D206DC for ; Tue, 27 Oct 2020 09:03:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AED5D206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1ECE46EB2E; Tue, 27 Oct 2020 09:03:09 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 166996EB2E for ; Tue, 27 Oct 2020 09:03:08 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id x1so627284eds.1 for ; Tue, 27 Oct 2020 02:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Yrkq+w+CNrcs2d/CHfaDmYUZq0y1BCcvuJB0UBRduYM=; b=fq/Yd+/8P0uEg/b+ddEBFIgC/J3BMvvkrqFx4fRLhCzP7lecueZXOUjtRMb8gNU5bi h1uYkvjw+UtaHfebhR2BbM69xspgTJBfIUArPsvhfemuW5LnfvYRTnSmuVRmbzZgWBQw t4DI2Kj9+2WYNHsTaGAibfZj0uByc0KIGhPH7sLO0t1kE1AYUf6LtpqeLPgycX23mKS3 8SLnhvkLZ6vFci05ZWocT/hAMI2u8A3A2C11p+tceZGkBL3kCRa8iN508/K+BSNyo3HI 7yurizKwqNDj9nELl9n915h5M7xQCwBFxuLt77rjWbgng3RoRKtJt5K/L0BARnEMM7BE MKUg== X-Gm-Message-State: AOAM5320cSbikyLWMT7iqvefM6em6TsLOHv/S7QtGvbA3V1rJCu6BoWk xxlrmKAgnLWWZnqX1YmZJ8E= X-Google-Smtp-Source: ABdhPJzNdRHhqt+RsXfXzhPc0FfVZYTR4QTRInXFxqbry09ZA816h7phOrK/RR0xsohIY4dLm8QVeg== X-Received: by 2002:aa7:c6d9:: with SMTP id b25mr1096980eds.27.1603789386647; Tue, 27 Oct 2020 02:03:06 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id p4sm587298eji.105.2020.10.27.02.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 02:03:05 -0700 (PDT) Date: Tue, 27 Oct 2020 10:03:03 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 06/52] dt-bindings: memory: tegra20: emc: Document new interconnect property Message-ID: <20201027090303.GH4244@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-7-digetx@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025221735.3062-7-digetx@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 01:16:49AM +0300, Dmitry Osipenko wrote: > External Memory Controller is interconnected with memory controller and > with external memory. Document new interconnect property which turns EMC > into interconnect provider. > > Acked-by: Rob Herring > Signed-off-by: Dmitry Osipenko > --- > .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > index 1b0d4417aad8..0a53adc6ccba 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > @@ -13,6 +13,7 @@ Properties: > - interrupts : Should contain EMC General interrupt. > - clocks : Should contain EMC clock. > - nvidia,memory-controller : Phandle of the Memory Controller node. > +- #interconnect-cells : Should be 0. > > Child device nodes describe the memory settings for different configurations and clock rates. > > @@ -21,6 +22,7 @@ Example: > memory-controller@7000f400 { > #address-cells = < 1 >; > #size-cells = < 0 >; > + #interconnect-cells = < 0 >; No spaces within <>. I see existing example, but bad pattern should not be continued just because it is already there. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel