All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [radeon-alex:amd-staging-drm-next 263/272] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning: this 'if' clause does not guard...
Date: Tue, 27 Oct 2020 09:33:29 +0800	[thread overview]
Message-ID: <202010270927.M5yCSBfY-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 6888 bytes --]

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   3458ef3969082647e64825452b8bfd06ee7c3351
commit: 254a8d162af6360334e20ee6601c0b38f31dfa2d [263/272] drm/amd/display: Using udelay for specific dongle while edid return defer
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
        git fetch --no-tags radeon-alex amd-staging-drm-next
        git checkout 254a8d162af6360334e20ee6601c0b38f31dfa2d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c: In function 'defer_delay_converter_wa':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     285 |  if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_0080E1 &&
         |  ^~
   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:291:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
     291 |   if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
         |   ^~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:86,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:36:
   At top level:
   drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw/dpp.h:50:42: warning: 'dpp_input_csc_matrix' defined but not used [-Wunused-const-variable=]
      50 | static const struct dpp_input_csc_matrix dpp_input_csc_matrix[] = {
         |                                          ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:31:
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_3' defined but not used [-Wunused-const-variable=]
     123 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_3[] = "dnomlA";
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:121:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_2' defined but not used [-Wunused-const-variable=]
     121 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT";
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:33,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:35,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:28:
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
      76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
         |                                ^~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
      75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
         |                                ^~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
      74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
         |                                ^~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
      73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
         |                                ^~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
      72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
         |                                ^~~~~~~~~~~

vim +/if +285 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c

4562236b3bc0a28 Harry Wentland 2017-09-12  278  
4562236b3bc0a28 Harry Wentland 2017-09-12  279  static uint32_t defer_delay_converter_wa(
4562236b3bc0a28 Harry Wentland 2017-09-12  280  	struct ddc_service *ddc,
4562236b3bc0a28 Harry Wentland 2017-09-12  281  	uint32_t defer_delay)
4562236b3bc0a28 Harry Wentland 2017-09-12  282  {
d0778ebfd58f565 Harry Wentland 2017-07-22  283  	struct dc_link *link = ddc->link;
4562236b3bc0a28 Harry Wentland 2017-09-12  284  
df3b7e32ed459a5 Qingqing Zhuo  2019-07-31 @285  	if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_0080E1 &&
4562236b3bc0a28 Harry Wentland 2017-09-12  286  		!memcmp(link->dpcd_caps.branch_dev_name,
4562236b3bc0a28 Harry Wentland 2017-09-12  287  			DP_DVI_CONVERTER_ID_4,
4562236b3bc0a28 Harry Wentland 2017-09-12  288  			sizeof(link->dpcd_caps.branch_dev_name)))
4562236b3bc0a28 Harry Wentland 2017-09-12  289  		return defer_delay > I2C_OVER_AUX_DEFER_WA_DELAY ?
4562236b3bc0a28 Harry Wentland 2017-09-12  290  			defer_delay : I2C_OVER_AUX_DEFER_WA_DELAY;
254a8d162af6360 jinlong zhang  2020-09-25  291  		if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
254a8d162af6360 jinlong zhang  2020-09-25  292  			!memcmp(link->dpcd_caps.branch_dev_name,
254a8d162af6360 jinlong zhang  2020-09-25  293  				DP_DVI_CONVERTER_ID_5,
254a8d162af6360 jinlong zhang  2020-09-25  294  				sizeof(link->dpcd_caps.branch_dev_name)))
254a8d162af6360 jinlong zhang  2020-09-25  295  		return defer_delay > I2C_OVER_AUX_DEFER_WA_DELAY_1MS ?
254a8d162af6360 jinlong zhang  2020-09-25  296  			I2C_OVER_AUX_DEFER_WA_DELAY_1MS : defer_delay;
4562236b3bc0a28 Harry Wentland 2017-09-12  297  
4562236b3bc0a28 Harry Wentland 2017-09-12  298  	return defer_delay;
4562236b3bc0a28 Harry Wentland 2017-09-12  299  }
4562236b3bc0a28 Harry Wentland 2017-09-12  300  

:::::: The code at line 285 was first introduced by commit
:::::: df3b7e32ed459a5348f7b408a9b8142b7358fde8 drm/amd/display: refactor Device ID for external chips

:::::: TO: Qingqing Zhuo <qingqing.zhuo@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65746 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: jinlong zhang <jinlong.zhang@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>,
	kbuild-all@lists.01.org, dri-devel@lists.freedesktop.org
Subject: [radeon-alex:amd-staging-drm-next 263/272] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning: this 'if' clause does not guard...
Date: Tue, 27 Oct 2020 09:33:29 +0800	[thread overview]
Message-ID: <202010270927.M5yCSBfY-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 6792 bytes --]

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   3458ef3969082647e64825452b8bfd06ee7c3351
commit: 254a8d162af6360334e20ee6601c0b38f31dfa2d [263/272] drm/amd/display: Using udelay for specific dongle while edid return defer
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
        git fetch --no-tags radeon-alex amd-staging-drm-next
        git checkout 254a8d162af6360334e20ee6601c0b38f31dfa2d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c: In function 'defer_delay_converter_wa':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     285 |  if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_0080E1 &&
         |  ^~
   drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:291:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
     291 |   if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
         |   ^~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:86,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:36:
   At top level:
   drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw/dpp.h:50:42: warning: 'dpp_input_csc_matrix' defined but not used [-Wunused-const-variable=]
      50 | static const struct dpp_input_csc_matrix dpp_input_csc_matrix[] = {
         |                                          ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:31:
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_3' defined but not used [-Wunused-const-variable=]
     123 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_3[] = "dnomlA";
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:121:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_2' defined but not used [-Wunused-const-variable=]
     121 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT";
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:33,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:35,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:28:
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
      76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
         |                                ^~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
      75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
         |                                ^~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
      74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
         |                                ^~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
      73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
         |                                ^~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
      72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
         |                                ^~~~~~~~~~~

vim +/if +285 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c

4562236b3bc0a28 Harry Wentland 2017-09-12  278  
4562236b3bc0a28 Harry Wentland 2017-09-12  279  static uint32_t defer_delay_converter_wa(
4562236b3bc0a28 Harry Wentland 2017-09-12  280  	struct ddc_service *ddc,
4562236b3bc0a28 Harry Wentland 2017-09-12  281  	uint32_t defer_delay)
4562236b3bc0a28 Harry Wentland 2017-09-12  282  {
d0778ebfd58f565 Harry Wentland 2017-07-22  283  	struct dc_link *link = ddc->link;
4562236b3bc0a28 Harry Wentland 2017-09-12  284  
df3b7e32ed459a5 Qingqing Zhuo  2019-07-31 @285  	if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_0080E1 &&
4562236b3bc0a28 Harry Wentland 2017-09-12  286  		!memcmp(link->dpcd_caps.branch_dev_name,
4562236b3bc0a28 Harry Wentland 2017-09-12  287  			DP_DVI_CONVERTER_ID_4,
4562236b3bc0a28 Harry Wentland 2017-09-12  288  			sizeof(link->dpcd_caps.branch_dev_name)))
4562236b3bc0a28 Harry Wentland 2017-09-12  289  		return defer_delay > I2C_OVER_AUX_DEFER_WA_DELAY ?
4562236b3bc0a28 Harry Wentland 2017-09-12  290  			defer_delay : I2C_OVER_AUX_DEFER_WA_DELAY;
254a8d162af6360 jinlong zhang  2020-09-25  291  		if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
254a8d162af6360 jinlong zhang  2020-09-25  292  			!memcmp(link->dpcd_caps.branch_dev_name,
254a8d162af6360 jinlong zhang  2020-09-25  293  				DP_DVI_CONVERTER_ID_5,
254a8d162af6360 jinlong zhang  2020-09-25  294  				sizeof(link->dpcd_caps.branch_dev_name)))
254a8d162af6360 jinlong zhang  2020-09-25  295  		return defer_delay > I2C_OVER_AUX_DEFER_WA_DELAY_1MS ?
254a8d162af6360 jinlong zhang  2020-09-25  296  			I2C_OVER_AUX_DEFER_WA_DELAY_1MS : defer_delay;
4562236b3bc0a28 Harry Wentland 2017-09-12  297  
4562236b3bc0a28 Harry Wentland 2017-09-12  298  	return defer_delay;
4562236b3bc0a28 Harry Wentland 2017-09-12  299  }
4562236b3bc0a28 Harry Wentland 2017-09-12  300  

:::::: The code at line 285 was first introduced by commit
:::::: df3b7e32ed459a5348f7b408a9b8142b7358fde8 drm/amd/display: refactor Device ID for external chips

:::::: TO: Qingqing Zhuo <qingqing.zhuo@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65746 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2020-10-27  1:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  1:33 kernel test robot [this message]
2020-10-27  1:33 ` [radeon-alex:amd-staging-drm-next 263/272] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning: this 'if' clause does not guard kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010270927.M5yCSBfY-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.