All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] ASoC: fsl_spdif: fix platform_get_irq.cocci warnings
Date: Tue, 27 Oct 2020 18:21:03 +0800	[thread overview]
Message-ID: <20201027102103.GA98220@d86794caeae7> (raw)
In-Reply-To: <202010271823.Urb3046K-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Shengjiu Wang <shengjiu.wang@nxp.com>
CC: Mark Brown <broonie@kernel.org>
CC: Timur Tabi <timur@kernel.org>
CC: Nicolin Chen <nicoleotsuka@gmail.com>
CC: Xiubo Li <Xiubo.Lee@gmail.com>
CC: Fabio Estevam <festevam@gmail.com>
CC: Liam Girdwood <lgirdwood@gmail.com>
CC: Jaroslav Kysela <perex@perex.cz>
CC: Takashi Iwai <tiwai@suse.com>
CC: alsa-devel(a)alsa-project.org

From: kernel test robot <lkp@intel.com>

sound/soc/fsl/fsl_spdif.c:1325:3-10: line 1325 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 516232e3609f ("ASoC: fsl_spdif: Add support for i.MX8QM platform")
CC: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   0dec50edcc9216535f82b1987c0a51efb3e23674
commit: 516232e3609f485be04445b03723fbaed64a5321 [1491/1813] ASoC: fsl_spdif: Add support for i.MX8QM platform
:::::: branch date: 5 hours ago
:::::: commit date: 16 hours ago

Please take the patch only if it's a positive warning. Thanks!

 fsl_spdif.c |    1 -
 1 file changed, 1 deletion(-)

--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1322,7 +1322,6 @@ static int fsl_spdif_probe(struct platfo
 	for (i = 0; i < spdif_priv->soc->interrupts; i++) {
 		irq = platform_get_irq(pdev, i);
 		if (irq < 0) {
-			dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
 			return irq;
 		}
 

      reply	other threads:[~2020-10-27 10:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 10:21 [linux-next:master 1491/1813] sound/soc/fsl/fsl_spdif.c:1325:3-10: line 1325 is redundant because platform_get_irq() already prints an error kernel test robot
2020-10-27 10:21 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027102103.GA98220@d86794caeae7 \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.