From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Elena Afanasova <eafanasova@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/3] staging/rtl8712: use BIT macro
Date: Tue, 27 Oct 2020 15:44:17 +0300 [thread overview]
Message-ID: <20201027124417.GW1042@kadam> (raw)
In-Reply-To: <20201020184404.GC20115@casper.infradead.org>
On Tue, Oct 20, 2020 at 07:44:04PM +0100, Matthew Wilcox wrote:
> On Tue, Oct 20, 2020 at 11:24:39AM -0700, Elena Afanasova wrote:
> > Reported by checkpatch.pl
>
> Checkpatch is wrong.
>
> > +++ b/drivers/staging/rtl8712/rtl871x_recv.h
> > @@ -8,7 +8,7 @@
> > #define NR_RECVFRAME 256
> >
> > #define RXFRAME_ALIGN 8
> > -#define RXFRAME_ALIGN_SZ (1 << RXFRAME_ALIGN)
> > +#define RXFRAME_ALIGN_SZ BIT(RXFRAME_ALIGN)
Yeah. It's weird to talk about size as a BIT() flag. The RXFRAME_ALIGN
is not needed. Just say:
-#define RXFRAME_ALIGN 8
-#define RXFRAME_ALIGN_SZ (1 << RXFRAME_ALIGN)
+#define RXFRAME_ALIGN_SZ 256
This is literally used for aligning the RX frame. It seems like a crazy
thing to me that to aligned at 256 bytes. I would have expected 64 bit
alignment or page alignment but not 256 byte alignment... Weird.
regards,
dan carpenter
next prev parent reply other threads:[~2020-10-27 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 18:24 [PATCH 1/3] staging/rtl8712: remove extra blank lines; fix code alignment Elena Afanasova
2020-10-20 18:24 ` [PATCH 2/3] staging/rtl8712: fix code style for comparison to NULL Elena Afanasova
2020-10-20 18:24 ` [PATCH 3/3] staging/rtl8712: use BIT macro Elena Afanasova
2020-10-20 18:44 ` [Outreachy kernel] " Matthew Wilcox
2020-10-27 12:44 ` Dan Carpenter [this message]
2020-10-21 4:28 ` [Outreachy kernel] [PATCH 1/3] staging/rtl8712: remove extra blank lines; fix code alignment Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027124417.GW1042@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eafanasova@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.