From: Matteo Croce <mcroce@linux.microsoft.com>
To: linux-kernel@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Petr Mladek <pmladek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
Mike Rapoport <rppt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Robin Holt <robinmholt@gmail.com>,
Fabian Frederick <fabf@skynet.be>,
stable@vger.kernel.org
Subject: [PATCH v2 0/2] fix parsing of reboot= cmdline
Date: Tue, 27 Oct 2020 14:35:43 +0100 [thread overview]
Message-ID: <20201027133545.58625-1-mcroce@linux.microsoft.com> (raw)
From: Matteo Croce <mcroce@microsoft.com>
The parsing of the reboot= cmdline has two major errors:
- a missing bound check can crash the system on reboot
- parsing of the cpu number only works if specified last
Fix both, along with a small code refactor.
v1->v2:
As Petr suggested, don't force base 10 in simple_strtoul(),
so hex values are accepted as well.
Matteo Croce (2):
reboot: fix overflow parsing reboot cpu number
reboot: fix parsing of reboot cpu number
kernel/reboot.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
--
2.28.0
next reply other threads:[~2020-10-27 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:35 Matteo Croce [this message]
2020-10-27 13:35 ` [PATCH v2 1/2] reboot: fix overflow parsing reboot cpu number Matteo Croce
2020-10-27 13:42 ` Greg KH
2020-10-30 14:13 ` Petr Mladek
2020-10-30 14:18 ` Matteo Croce
2020-10-27 13:35 ` [PATCH v2 2/2] reboot: fix parsing of " Matteo Croce
2020-10-27 13:42 ` Greg KH
2020-10-30 14:30 ` Petr Mladek
2020-11-01 1:57 ` Matteo Croce
2020-11-02 11:01 ` Petr Mladek
2020-11-03 11:43 ` Matteo Croce
2020-11-03 14:25 ` Petr Mladek
2020-11-03 15:43 ` Matteo Croce
2020-11-03 16:22 ` Petr Mladek
2020-10-27 13:42 ` [PATCH v2 0/2] fix parsing of reboot= cmdline Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027133545.58625-1-mcroce@linux.microsoft.com \
--to=mcroce@linux.microsoft.com \
--cc=arnd@arndb.de \
--cc=fabf@skynet.be \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pasha.tatashin@soleen.com \
--cc=pmladek@suse.com \
--cc=robinmholt@gmail.com \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.