From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2919C388F9 for ; Tue, 27 Oct 2020 16:20:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60DA621707 for ; Tue, 27 Oct 2020 16:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603815625; bh=9ubK2jU1YuQzm6hFAuu9SToBCJFIb5sgFqynAqoHh3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Cn8fiBKR6r8OJa8bCxAefBz7fzFDTgtqDA8UVBlzi1SjKVV2i8jQLGrbayquOVSzT 0Vbpk18qRUn5vDtFw27jG/C59shRNsQnIJxBTrWHNwr/ZkCYJlNTCLEBx5fsorVl7y eVptJ4kG7Ux+j6260QL6YRdRUs1iNtYRhKmLr2wU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1808726AbgJ0QUY (ORCPT ); Tue, 27 Oct 2020 12:20:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:44866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1808714AbgJ0QUU (ORCPT ); Tue, 27 Oct 2020 12:20:20 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E739C21556; Tue, 27 Oct 2020 16:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603815620; bh=9ubK2jU1YuQzm6hFAuu9SToBCJFIb5sgFqynAqoHh3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iMDTZxc5yZpyCOmxEonPRTO8fWjFPQe+ghh50hSS0rqd1/PdUKEcDPsmsbAdq9SP/ 9lLMYmqH+NmAg9xVWCJtHmVqiH1qVSQ+btYb2KiHbY/h3K6WSo1Pwd1X5IQ0sD/6GT WVfjAg8HsdCi9xkOzL8H/DJ8VD3HXDASfL0pWPYs= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 165B8403C2; Tue, 27 Oct 2020 13:20:18 -0300 (-03) Date: Tue, 27 Oct 2020 13:20:18 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Jin Yao , Jiri Olsa , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , LKML , Andi Kleen , Kan Liang , "Jin, Yao" Subject: Re: [PATCH] perf vendor events: Fix DRAM_BW_Use 0 issue for CLX/SKX Message-ID: <20201027162018.GH2479604@kernel.org> References: <20201023005334.7869-1-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Oct 22, 2020 at 06:02:31PM -0700, Ian Rogers escreveu: > On Thu, Oct 22, 2020 at 5:54 PM Jin Yao wrote: > > > > Ian reports an issue that the metric DRAM_BW_Use often remains 0. > > > > The metric expression for DRAM_BW_Use on CLX/SKX: > > > > "( 64 * ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) / 1000000000 ) / duration_time" > > > > The counts of uncore_imc/cas_count_read/ and uncore_imc/cas_count_write/ > > are scaled up by 64, that is to turn a count of cache lines into bytes, > > the count is then divided by 1000000000 to give GB. > > > > However, the counts of uncore_imc/cas_count_read/ and > > uncore_imc/cas_count_write/ have been scaled yet. > > > > The scale values are from sysfs, such as > > /sys/devices/uncore_imc_0/events/cas_count_read.scale. > > It's 6.103515625e-5 (64 / 1024.0 / 1024.0). > > > > So if we use original metric expression, the result is not correct. > > > > But the difficulty is, for SKL client, the counts are not scaled. > > > > The metric expression for DRAM_BW_Use on SKL: > > > > "64 * ( arb@event\\=0x81\\,umask\\=0x1@ + arb@event\\=0x84\\,umask\\=0x1@ ) / 1000000 / duration_time / 1000" > > > > root@kbl-ppc:~# perf stat -M DRAM_BW_Use -a -- sleep 1 > > > > Performance counter stats for 'system wide': > > > > 190 arb/event=0x84,umask=0x1/ # 1.86 DRAM_BW_Use > > 29,093,178 arb/event=0x81,umask=0x1/ > > 1,000,703,287 ns duration_time > > > > 1.000703287 seconds time elapsed > > > > The result is expected. > > > > So the easy way is just change the metric expression for CLX/SKX. > > This patch changes the metric expression to: > > > > "( ( ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) * 1048576 ) / 1000000000 ) / duration_time" > > > > 1048576 = 1024 * 1024. > > > > Before (tested on CLX): > > > > root@lkp-csl-2sp5 ~# perf stat -M DRAM_BW_Use -a -- sleep 1 > > > > Performance counter stats for 'system wide': > > > > 765.35 MiB uncore_imc/cas_count_read/ # 0.00 DRAM_BW_Use > > 5.42 MiB uncore_imc/cas_count_write/ > > 1001515088 ns duration_time > > > > 1.001515088 seconds time elapsed > > > > After: > > > > root@lkp-csl-2sp5 ~# perf stat -M DRAM_BW_Use -a -- sleep 1 > > > > Performance counter stats for 'system wide': > > > > 767.95 MiB uncore_imc/cas_count_read/ # 0.80 DRAM_BW_Use > > Nit, using ScaleUnit would allow this to be 0.80GB/s. > > > 5.02 MiB uncore_imc/cas_count_write/ > > 1001900010 ns duration_time > > > > 1.001900010 seconds time elapsed > > > > Fixes: 038d3b53c284 ("perf vendor events intel: Update CascadelakeX events to v1.08") > > Fixes: b5ff7f2799a4 ("perf vendor events: Update SkylakeX events to v1.21") > > Signed-off-by: Jin Yao > > Acked-by: Ian Rogers Thanks, applied. - Arnaldo > Thanks, > Ian > > > --- > > tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +- > > tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json > > index de3193552277..00f4fcffa815 100644 > > --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json > > +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json > > @@ -329,7 +329,7 @@ > > }, > > { > > "BriefDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]", > > - "MetricExpr": "( 64 * ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) / 1000000000 ) / duration_time", > > + "MetricExpr": "( ( ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) * 1048576 ) / 1000000000 ) / duration_time", > > "MetricGroup": "Memory_BW;SoC", > > "MetricName": "DRAM_BW_Use" > > }, > > diff --git a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json > > index f31794d3b926..0dd8b13b5cfb 100644 > > --- a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json > > +++ b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json > > @@ -323,7 +323,7 @@ > > }, > > { > > "BriefDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]", > > - "MetricExpr": "( 64 * ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) / 1000000000 ) / duration_time", > > + "MetricExpr": "( ( ( uncore_imc@cas_count_read@ + uncore_imc@cas_count_write@ ) * 1048576 ) / 1000000000 ) / duration_time", > > "MetricGroup": "Memory_BW;SoC", > > "MetricName": "DRAM_BW_Use" > > }, > > -- > > 2.17.1 > > -- - Arnaldo