From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] virtiofsd: Fix the help message of posix lock
Date: Tue, 27 Oct 2020 18:33:19 +0000 [thread overview]
Message-ID: <20201027183319.GR3369@work-vm> (raw)
In-Reply-To: <20201027081558.29904-1-zhangjiachen.jaycee@bytedance.com>
* Jiachen Zhang (zhangjiachen.jaycee@bytedance.com) wrote:
> The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote
> posix locks by default. But the --help message still says it is enabled
> by default. So fix it to output no_posix_lock.
>
> Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Thanks!
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tools/virtiofsd/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 85770d63f1..574dd09e91 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -161,7 +161,7 @@ void fuse_cmdline_help(void)
> " allowed (default: 10)\n"
> " -o posix_lock|no_posix_lock\n"
> " enable/disable remote posix lock\n"
> - " default: posix_lock\n"
> + " default: no_posix_lock\n"
> " -o readdirplus|no_readdirplus\n"
> " enable/disable readirplus\n"
> " default: readdirplus except with "
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-10-27 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 8:15 [PATCH] virtiofsd: Fix the help message of posix lock Jiachen Zhang
2020-10-27 8:42 ` Philippe Mathieu-Daudé
2020-10-27 18:33 ` Dr. David Alan Gilbert [this message]
2020-11-02 18:43 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027183319.GR3369@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhangjiachen.jaycee@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.