From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95694C388F9 for ; Tue, 27 Oct 2020 19:30:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35F452225E for ; Tue, 27 Oct 2020 19:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603827046; bh=p5EJuB08g8viGaFfnDYuER/Je2iyqjf4osgqG1fGga0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uPalrc8t3S3KtYAlPr9rLrfHWh52TlcrvYPveBjDkbZzafBMMeTvbpHnDxEgmKaL6 Q7eAnJnq2Qat8CkBE9WEUm+YaGTBLdHvl0lDHV5wbV9Q2OsELc3zcEhDxl+nBZsaCK q64dH7av+bmmhg0ole0vZh4QC5oUx7Af/5Nz82Vc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1830010AbgJ0Tap convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2020 15:30:45 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45100 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1830015AbgJ0Tap (ORCPT ); Tue, 27 Oct 2020 15:30:45 -0400 Received: by mail-ed1-f66.google.com with SMTP id dg9so2643928edb.12; Tue, 27 Oct 2020 12:30:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RBb2W6vnvr8BZ3JPOSPoABcC6/USapoO19wplu4GSWk=; b=lul+G3Ugz0pTOYAfoBoiOXduTzTI2SRlj9Cfcgol4qrfvTyDWaJ7DI3iAJyyV8xzbu SbN2RdZgJZZkirLeVJehXfHS77Vh/4YG6bg5Y0EXRN5aTo549VgqpzpsKpYAwVWPfhqO hk3EIv1zVoOotaBiDVdnZIA2bUCNoAXiOUNW2iIlYqZUl1SzRnlFRlClaIYTZ/TDpJp3 yR35hfxiqWwq/CBeeViDvgz3vcNUyfefZCZy6SfITwgYH6fjUYCiobhwiM63eT7DInNz BX8tqWwYAvigE8ZTnlBLp3hN0NZRhJq24D5Kck+J4f/75HNBuZxYEkN4FkmlmRYqehbX I1PQ== X-Gm-Message-State: AOAM533aItwOF1wQcfBGXVPf3GJxpKJJ/PA3cIYnL3olqrthbe2gzZdP mrbvB1vuvvrYwCsvZybqVc/mn+Em1pV+vFI3 X-Google-Smtp-Source: ABdhPJyZ/rq/EC6GsN4s/PCybZFKTFwJikds6RvGuu7wY5AqoMWIc9Vxh43XdGRJGg8dsyUGVp5G3w== X-Received: by 2002:a05:6402:1b1e:: with SMTP id by30mr3972107edb.369.1603827042919; Tue, 27 Oct 2020 12:30:42 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id s12sm1518324edu.28.2020.10.27.12.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:30:41 -0700 (PDT) Date: Tue, 27 Oct 2020 20:30:39 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property Message-ID: <20201027193039.GA140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> <20201027085417.GD4244@kozik-lap> <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Oct 27, 2020 at 10:17:19PM +0300, Dmitry Osipenko wrote: > 27.10.2020 11:54, Krzysztof Kozlowski пишет: > > On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: > >> Tegra20 External Memory Controller talks to DRAM chips and it needs to be > >> reprogrammed when memory frequency changes. Tegra Memory Controller sits > >> behind EMC and these controllers are tightly coupled. This patch adds the > >> new phandle property which allows to properly express connection of EMC > >> and MC hardware in a device-tree, it also put the Tegra20 EMC binding on > >> par with Tegra30+ EMC bindings, which is handy to have. > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > >> .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > >> index 567cffd37f3f..1b0d4417aad8 100644 > >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt > >> @@ -12,6 +12,7 @@ Properties: > >> irrespective of ram-code configuration. > >> - interrupts : Should contain EMC General interrupt. > >> - clocks : Should contain EMC clock. > >> +- nvidia,memory-controller : Phandle of the Memory Controller node. > > > > It looks like you adding a required property which is an ABI break. > The T20 EMC driver is unused so far in upstream and it will become used > only once this series is applied. Hence it's fine to change the ABI. The ABI is not about upstream, but downstream. There are no other upstreams using this ABI. Unless you have in mind that existing T20 EMC driver was a noop, doing absolutely nothing, therefore there is no breakage of any other users? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C68DC4363A for ; Tue, 27 Oct 2020 19:30:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2E5120756 for ; Tue, 27 Oct 2020 19:30:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2E5120756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3987F6EC24; Tue, 27 Oct 2020 19:30:45 +0000 (UTC) Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CF196EC24 for ; Tue, 27 Oct 2020 19:30:44 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id k9so550550edo.5 for ; Tue, 27 Oct 2020 12:30:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RBb2W6vnvr8BZ3JPOSPoABcC6/USapoO19wplu4GSWk=; b=nDr7Hit+C/Z/yobPmfI/v3ygzZ8ta4f5OZ5CwhDnwWaFlKyjAySyY88C5GW/CTmiO/ a0qy1CCi8yOhq41yMnZGV+3Yb9wAK86i90rBDj6TgJpdt7uxh43t+rzPAb+C3moUW8DU 15/V6eaEn9bio2cg2sp8z+HzwQdwc5+F3i33Y6BivzJz/vqHvschZewIT4E/iKAe9MbN rhrakKkw90VQ0wddIR0E003kMigRTIyZrEwGD8ZT0cEDebdIa4pmQaJrTDUI7gGyYlsy I9TZchAvT2WUxwnkUTKDf5bKZbE2zyYyLrheylGSSBBE9SpK9hch65AYZH/53y4PQyB+ zk3Q== X-Gm-Message-State: AOAM530l4u/akddU+BZkCK5CceBC+mi9JJ4l9bSFEaXRdL8D712bXIq+ pG2SqMWj3Pvn6nO+NDkyYuI= X-Google-Smtp-Source: ABdhPJyZ/rq/EC6GsN4s/PCybZFKTFwJikds6RvGuu7wY5AqoMWIc9Vxh43XdGRJGg8dsyUGVp5G3w== X-Received: by 2002:a05:6402:1b1e:: with SMTP id by30mr3972107edb.369.1603827042919; Tue, 27 Oct 2020 12:30:42 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id s12sm1518324edu.28.2020.10.27.12.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 12:30:41 -0700 (PDT) Date: Tue, 27 Oct 2020 20:30:39 +0100 From: Krzysztof Kozlowski To: Dmitry Osipenko Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property Message-ID: <20201027193039.GA140636@kozik-lap> References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> <20201027085417.GD4244@kozik-lap> <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBPY3QgMjcsIDIwMjAgYXQgMTA6MTc6MTlQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IDI3LjEwLjIwMjAgMTE6NTQsIEtyenlzenRvZiBLb3psb3dza2kg0L/QuNGI0LXR gjoKPiA+IE9uIE1vbiwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjQ3QU0gKzAzMDAsIERtaXRyeSBP c2lwZW5rbyB3cm90ZToKPiA+PiBUZWdyYTIwIEV4dGVybmFsIE1lbW9yeSBDb250cm9sbGVyIHRh bGtzIHRvIERSQU0gY2hpcHMgYW5kIGl0IG5lZWRzIHRvIGJlCj4gPj4gcmVwcm9ncmFtbWVkIHdo ZW4gbWVtb3J5IGZyZXF1ZW5jeSBjaGFuZ2VzLiBUZWdyYSBNZW1vcnkgQ29udHJvbGxlciBzaXRz Cj4gPj4gYmVoaW5kIEVNQyBhbmQgdGhlc2UgY29udHJvbGxlcnMgYXJlIHRpZ2h0bHkgY291cGxl ZC4gVGhpcyBwYXRjaCBhZGRzIHRoZQo+ID4+IG5ldyBwaGFuZGxlIHByb3BlcnR5IHdoaWNoIGFs bG93cyB0byBwcm9wZXJseSBleHByZXNzIGNvbm5lY3Rpb24gb2YgRU1DCj4gPj4gYW5kIE1DIGhh cmR3YXJlIGluIGEgZGV2aWNlLXRyZWUsIGl0IGFsc28gcHV0IHRoZSBUZWdyYTIwIEVNQyBiaW5k aW5nIG9uCj4gPj4gcGFyIHdpdGggVGVncmEzMCsgRU1DIGJpbmRpbmdzLCB3aGljaCBpcyBoYW5k eSB0byBoYXZlLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxkaWdl dHhAZ21haWwuY29tPgo+ID4+IC0tLQo+ID4+ICAuLi4vYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xs ZXJzL252aWRpYSx0ZWdyYTIwLWVtYy50eHQgICAgICAgICAgfCAyICsrCj4gPj4gIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL252aWRpYSx0ZWdyYTIw LWVtYy50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRy b2xsZXJzL252aWRpYSx0ZWdyYTIwLWVtYy50eHQKPiA+PiBpbmRleCA1NjdjZmZkMzdmM2YuLjFi MGQ0NDE3YWFkOCAxMDA2NDQKPiA+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL252aWRpYSx0ZWdyYTIwLWVtYy50eHQKPiA+PiArKysg Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL252 aWRpYSx0ZWdyYTIwLWVtYy50eHQKPiA+PiBAQCAtMTIsNiArMTIsNyBAQCBQcm9wZXJ0aWVzOgo+ ID4+ICAgIGlycmVzcGVjdGl2ZSBvZiByYW0tY29kZSBjb25maWd1cmF0aW9uLgo+ID4+ICAtIGlu dGVycnVwdHMgOiBTaG91bGQgY29udGFpbiBFTUMgR2VuZXJhbCBpbnRlcnJ1cHQuCj4gPj4gIC0g Y2xvY2tzIDogU2hvdWxkIGNvbnRhaW4gRU1DIGNsb2NrLgo+ID4+ICstIG52aWRpYSxtZW1vcnkt Y29udHJvbGxlciA6IFBoYW5kbGUgb2YgdGhlIE1lbW9yeSBDb250cm9sbGVyIG5vZGUuCj4gPiAK PiA+IEl0IGxvb2tzIGxpa2UgeW91IGFkZGluZyBhIHJlcXVpcmVkIHByb3BlcnR5IHdoaWNoIGlz IGFuIEFCSSBicmVhay4KPiBUaGUgVDIwIEVNQyBkcml2ZXIgaXMgdW51c2VkIHNvIGZhciBpbiB1 cHN0cmVhbSBhbmQgaXQgd2lsbCBiZWNvbWUgdXNlZAo+IG9ubHkgb25jZSB0aGlzIHNlcmllcyBp cyBhcHBsaWVkLiBIZW5jZSBpdCdzIGZpbmUgdG8gY2hhbmdlIHRoZSBBQkkuCgpUaGUgQUJJIGlz IG5vdCBhYm91dCB1cHN0cmVhbSwgYnV0IGRvd25zdHJlYW0uIFRoZXJlIGFyZSBubyBvdGhlcgp1 cHN0cmVhbXMgdXNpbmcgdGhpcyBBQkkuIFVubGVzcyB5b3UgaGF2ZSBpbiBtaW5kIHRoYXQgZXhp c3RpbmcgVDIwIEVNQwpkcml2ZXIgd2FzIGEgbm9vcCwgZG9pbmcgYWJzb2x1dGVseSBub3RoaW5n LCB0aGVyZWZvcmUgdGhlcmUgaXMgbm8KYnJlYWthZ2Ugb2YgYW55IG90aGVyIHVzZXJzPwoKQmVz dCByZWdhcmRzLApLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=